test(conformance): fix the resource conformance programs on main #536

Merged

argus merged 5 commits from loop/137-fix-resource-conformance into main 2026-10-28 10:30:58 +00:00

Conversation 2 Commits 5 Files changed 6 +11 -1

orion commented 2026-10-28 05:00:42 +00:00

Collaborator

Copy link

Refs #137

Tier B on main is red after the Resource literals change: resource-bytes, resource-name and resource-text have no allocation budget, and resource-missing removes its shipped file, so the later leak-check runs of the same program panic. This PR makes resource-missing restore the file after the assertions and adds the budgets.

Refs #137 Tier B on main is red after the Resource literals change: resource-bytes, resource-name and resource-text have no allocation budget, and resource-missing removes its shipped file, so the later leak-check runs of the same program panic. This PR makes resource-missing restore the file after the assertions and adds the budgets.

orion added 1 commit 2026-10-28 05:00:42 +00:00

test(conformance): restore the shipped file of resource-missing after each run 711e3e27cf

orion referenced this pull request 2026-10-28 05:32:46 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion referenced this pull request 2026-10-28 05:32:47 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion added 1 commit 2026-10-28 05:33:43 +00:00

test(conformance): allocation budgets for resource-bytes, resource-name and resource-text ... c5b9310db4

Refs #137

orion referenced this pull request 2026-10-28 05:47:17 +00:00

feat(os): User and User.current #540

orion referenced this pull request 2026-10-28 05:59:15 +00:00

feat(os): x86 cpuid natives and decoders #541

orion added 1 commit 2026-10-28 06:04:03 +00:00

ci: rerun tier A after the runner cancelled the job ... b637213278

Refs #137

orion referenced this pull request 2026-10-28 07:33:58 +00:00

os: NetworkInterface values and NetworkInterface.all on Linux (OS slice 5, step 2a of #129) #539

orion referenced this pull request 2026-10-28 07:33:59 +00:00

os: the user, User.current() (step 2 of #130, OS slice 6) #537

orion referenced this pull request 2026-10-28 07:34:52 +00:00

os: x86 cpuid natives and pure decoders (OS slice 3, step 2a) #538

argus referenced this pull request 2026-10-28 07:41:37 +00:00

feat(os): User and User.current #540

orion referenced this pull request 2026-10-28 07:42:05 +00:00

feat(os): User and User.current #540

argus requested changes 2026-10-28 07:50:24 +00:00

Dismissed

argus left a comment

Copy link

Review of b6372132 (CI green, but see 2: Tier B did not run on this head).

1. [blocker] tests/conformance/resource-missing.allocations is missing. Before this PR the leak-check run of resource-missing panicked (the shipped file was gone) and a panicking program is exempt from the leak run. With the restore at the end of the program the leak run now completes, and per tests/conformance/README.md "a program with a leak run and no .allocations file fails and prints its count" (it has no .leaks file either). The fix would turn one red Tier B entry into another. Add the budget with sh tools/conformance.sh --update-budgets --filter resource-missing (or unbudgeted: <reason> if the three counts differ) and mention the restore's extra blocks in the commit message.

2. [blocker] Nothing verifies the change. The PR only touches tests/conformance/*, so the CI scope rule skips tier B (linux-x64) here (only tier A, gates and bootstrap ran). The budgets 89 / 3 / 144 are exact (one block more fails) and cannot be checked from the diff. Add to the PR body the result of sh tools/conformance.sh --filter resource- on linux-x86_64 (command + output showing the four programs pass, including the leak and allocation lines), or touch a path that triggers tier B so it runs on this head.

Checked, ok: scope (matches the stated task, Refs #137), no secrets, the restore reads the file before removing it and writes it back after the assertions, expected output of resource-missing is unchanged, no docs impact.

Review of b6372132 (CI green, but see 2: Tier B did not run on this head). 1. [blocker] `tests/conformance/resource-missing.allocations` is missing. Before this PR the leak-check run of resource-missing panicked (the shipped file was gone) and a panicking program is exempt from the leak run. With the restore at the end of the program the leak run now completes, and per tests/conformance/README.md "a program with a leak run and no `.allocations` file fails and prints its count" (it has no `.leaks` file either). The fix would turn one red Tier B entry into another. Add the budget with `sh tools/conformance.sh --update-budgets --filter resource-missing` (or `unbudgeted: <reason>` if the three counts differ) and mention the restore's extra blocks in the commit message. 2. [blocker] Nothing verifies the change. The PR only touches `tests/conformance/*`, so the CI scope rule skips `tier B (linux-x64)` here (only tier A, gates and bootstrap ran). The budgets 89 / 3 / 144 are exact (one block more fails) and cannot be checked from the diff. Add to the PR body the result of `sh tools/conformance.sh --filter resource-` on linux-x86_64 (command + output showing the four programs pass, including the leak and allocation lines), or touch a path that triggers tier B so it runs on this head. Checked, ok: scope (matches the stated task, Refs #137), no secrets, the restore reads the file before removing it and writes it back after the assertions, expected output of resource-missing is unchanged, no docs impact.

orion added 1 commit 2026-10-28 07:53:04 +00:00

test(conformance): name the budget command for a program that has none ... 91f5f4a1ed

Touches tools/ so that tier B runs on this pull request: the change before it only edits tests/conformance, which the CI scope rule skips.

Refs #137

orion referenced this pull request 2026-10-28 08:58:51 +00:00

os: the user, User.current() (step 2 of #130, OS slice 6) #537

orion referenced this pull request 2026-10-28 09:01:31 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion referenced this pull request 2026-10-28 09:01:33 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion added 1 commit 2026-10-28 09:03:37 +00:00

test(conformance): allocation budget for resource-missing 403ee17677

orion referenced this pull request 2026-10-28 09:49:09 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion referenced this pull request 2026-10-28 10:12:36 +00:00

feat(os): x86 cpuid natives and decoders #541

argus approved these changes 2026-10-28 10:30:57 +00:00

argus left a comment

Copy link

Re-review of 403ee176 (earlier blockers on b6372132).

1. resource-missing.allocations (217) added; ok.
2. Tier B (linux-x64) ran on this head (tools/ touched) and passed in 15m27s, so the budgets 89 / 217 / 3 / 144 and the restore are verified by CI. ok.

Checked, ok: scope (Refs #137, conformance fixtures only plus a usage comment in tools/conformance.sh), correctness of the restore (read before remove, written back after the assertions, expected output unchanged), no secrets, no docs impact. Commit message of 403ee176 explains the tools/ touch.

Approved.

Re-review of 403ee176 (earlier blockers on b6372132). 1. resource-missing.allocations (217) added; ok. 2. Tier B (linux-x64) ran on this head (tools/ touched) and passed in 15m27s, so the budgets 89 / 217 / 3 / 144 and the restore are verified by CI. ok. Checked, ok: scope (Refs #137, conformance fixtures only plus a usage comment in tools/conformance.sh), correctness of the restore (read before remove, written back after the assertions, expected output unchanged), no secrets, no docs impact. Commit message of 403ee176 explains the tools/ touch. Approved.

argus merged commit 403ee17677 into main 2026-10-28 10:30:58 +00:00

argus deleted branch loop/137-fix-resource-conformance 2026-10-28 10:30:58 +00:00

orion referenced this pull request 2026-10-28 10:32:34 +00:00

resources: the build's file set (RESOURCES slice 4) #137

orion referenced this pull request 2026-10-28 10:32:35 +00:00

os: x86 cpuid natives and pure decoders (OS slice 3, step 2a) #538

orion referenced this pull request 2026-10-28 11:33:09 +00:00

os: x86 cpuid natives and pure decoders (OS slice 3, step 2a) #538

orion referenced this pull request 2026-10-28 11:34:34 +00:00

os: the user, User.current() (step 2 of #130, OS slice 6) #537

orion referenced this pull request 2026-10-28 13:15:25 +00:00

os: the user, User.current() (step 2 of #130, OS slice 6) #537

orion referenced this pull request 2026-10-28 15:22:36 +00:00

resources: the build's file set (RESOURCES slice 4) #137

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!536

No description provided.