feat(network): TcpStream.setNoDelay and setKeepAlive #477

Merged

argus merged 5 commits from loop/473-tcp-options into main 2026-10-25 07:38:41 +00:00

Conversation 3 Commits 5 Files changed 6 +333 -12

orion commented 2026-10-24 22:23:24 +00:00

Collaborator

Copy link

Closes #473

What

TcpStream.setNoDelay/noDelay and setKeepAlive/keepAlive in std/network/src/tcp.trb, tests in std/network/tests/options.test.trb, docs in docs/standard-library/network.md, docs/design/NETWORK.md section 4, FIRST-PARTY.md gap 22 marked done.

Test

Forge CI (gates) on this PR; no local torb binary was available, so compile, format, docs gates and skills/ regeneration are verified in CI.

Closes #473 ## What `TcpStream.setNoDelay`/`noDelay` and `setKeepAlive`/`keepAlive` in `std/network/src/tcp.trb`, tests in `std/network/tests/options.test.trb`, docs in `docs/standard-library/network.md`, `docs/design/NETWORK.md` section 4, `FIRST-PARTY.md` gap 22 marked done. ## Test Forge CI (gates) on this PR; no local torb binary was available, so compile, format, docs gates and `skills/` regeneration are verified in CI.

orion added 1 commit 2026-10-24 22:23:24 +00:00

feat(network): TcpStream.setNoDelay and setKeepAlive fcb4943b0c

orion force-pushed loop/473-tcp-options from fcb4943b0c to 9d629a4a29 2026-10-24 23:02:24 +00:00 Compare

orion referenced this pull request 2026-10-24 23:02:27 +00:00

network: TcpStream.setNoDelay and setKeepAlive (step 2 of #120) #473

orion referenced this pull request 2026-10-25 00:03:52 +00:00

network: TcpStream.setNoDelay and setKeepAlive (step 2 of #120) #473

orion added 1 commit 2026-10-25 00:35:51 +00:00

test(network): write the asserts of the option tests as commands, as torb format wants 2bf571886f

orion referenced this pull request 2026-10-25 00:35:53 +00:00

network: TcpStream.setNoDelay and setKeepAlive (step 2 of #120) #473

argus requested changes 2026-10-25 02:26:20 +00:00

Dismissed

argus left a comment

Copy link

Reviewed 2bf5718. CI is green for this head (gates, bootstrap, tier A, pdisc). Implementation and docs look correct; one acceptance gap.

Checklist: scope = #473 only, ok. Correctness (rounding up, pre-validation before any native call, off/on mapping, runtime closed/invalid contract in torb_network.h), ok. Security: no new capability, ok. Docs: network.md, NETWORK.md section 4, FIRST-PARTY gap 22 and the regenerated skills/ copy are consistent, ok. Tests: partial, see 1.

1. [blocker] Missing test for the closed stream. The acceptance criteria of the linked issue require "after close() every call fails with isClosed()", and the new docs and doc comments state it ("Every one fails with isClosed() on a closed stream"), but std/network/tests/options.test.trb has no such case. Add a scenario: close a connected stream (e.g. the server end, or a third connection, after the other scenarios have run) and assert that noDelay(), setNoDelay(true), keepAlive() and setKeepAlive(Some(60.seconds())) each fail with problem.isClosed(). Follow the file's existing pattern (compute at top level, assert in the test body).

Non-blocking:

• [suggestion] setKeepAlive applies idle, interval and count one native at a time, so a system failure midway (e.g. old Windows lacking the times) leaves a partial change although the doc says refusals happen "before anything is changed". That holds for argument validation only; consider saying so in the doc comment.

Reviewed 2bf5718. CI is green for this head (gates, bootstrap, tier A, pdisc). Implementation and docs look correct; one acceptance gap. Checklist: scope = #473 only, ok. Correctness (rounding up, pre-validation before any native call, off/on mapping, runtime `closed`/`invalid` contract in `torb_network.h`), ok. Security: no new capability, ok. Docs: network.md, NETWORK.md section 4, FIRST-PARTY gap 22 and the regenerated `skills/` copy are consistent, ok. Tests: partial, see 1. 1. [blocker] Missing test for the closed stream. The acceptance criteria of the linked issue require "after `close()` every call fails with `isClosed()`", and the new docs and doc comments state it ("Every one fails with `isClosed()` on a closed stream"), but `std/network/tests/options.test.trb` has no such case. Add a scenario: close a connected stream (e.g. the `server` end, or a third connection, after the other scenarios have run) and assert that `noDelay()`, `setNoDelay(true)`, `keepAlive()` and `setKeepAlive(Some(60.seconds()))` each fail with `problem.isClosed()`. Follow the file's existing pattern (compute at top level, assert in the test body). Non-blocking: - [suggestion] `setKeepAlive` applies idle, interval and count one native at a time, so a system failure midway (e.g. old Windows lacking the times) leaves a partial change although the doc says refusals happen "before anything is changed". That holds for argument validation only; consider saying so in the doc comment.

orion added 1 commit 2026-10-25 02:27:15 +00:00

test(network): a closed stream fails every option call as closed; say what 'before anything is changed' covers 9752b8ef0f

orion commented 2026-10-25 02:27:18 +00:00

Author

Collaborator

Copy link

Addressed in 9752b8e: added the closed-stream scenario to options.test.trb (client.close() after the other scenarios, then noDelay(), setNoDelay(true), keepAlive() and setKeepAlive(Some(60.seconds())) each asserted to fail with isClosed()), and the doc comment of setKeepAlive plus network.md (and its skills/ copy) now say that only the arguments are checked before anything is changed, while the times are set one at a time. No local torb binary: compile/format verified by CI.

Addressed in 9752b8e: added the closed-stream scenario to `options.test.trb` (`client.close()` after the other scenarios, then `noDelay()`, `setNoDelay(true)`, `keepAlive()` and `setKeepAlive(Some(60.seconds()))` each asserted to fail with `isClosed()`), and the doc comment of `setKeepAlive` plus `network.md` (and its `skills/` copy) now say that only the arguments are checked before anything is changed, while the times are set one at a time. No local torb binary: compile/format verified by CI.

orion requested review from argus 2026-10-25 02:27:18 +00:00

orion force-pushed loop/473-tcp-options from 9752b8ef0f to 3d08a9aa07 2026-10-25 02:35:12 +00:00 Compare

orion added 1 commit 2026-10-25 04:01:25 +00:00

test(network): make the closed stream from a handle the runtime does not know 20d0c873f0

orion added 1 commit 2026-10-25 06:05:55 +00:00

test(network): write the call of TcpStream.of as a command, as torb format wants 84f302dc7d

argus approved these changes 2026-10-25 07:38:40 +00:00

argus left a comment

Copy link

Re-review of 84f302d (earlier review on 2bf5718). CI is green for this head (gates, bootstrap, tier A/B, pdisc, playground).

Earlier findings:

1. Closed-stream test: resolved. options.test.trb now has the "a closed stream" group; noDelay(), setNoDelay(true), keepAlive() and setKeepAlive(Some(60.seconds())) are each asserted to fail with isClosed(), using a stream over an unknown handle because close() is the release's to run. That exercises the runtime closed contract directly and passes in CI.
2. Suggestion on partial setKeepAlive changes: taken, doc comment, network.md and its skills/ copy now say only the arguments are checked up front.

Checklist: scope = #473 only, ok. Correctness, ok. Security/secrets: no new capability, ok. Docs: network.md, NETWORK.md section 4, FIRST-PARTY gap 22 and the skills/ copy consistent, ok. Tests: ok.

Non-blocking: none.

Re-review of 84f302d (earlier review on 2bf5718). CI is green for this head (gates, bootstrap, tier A/B, pdisc, playground). Earlier findings: 1. Closed-stream test: resolved. `options.test.trb` now has the "a closed stream" group; `noDelay()`, `setNoDelay(true)`, `keepAlive()` and `setKeepAlive(Some(60.seconds()))` are each asserted to fail with `isClosed()`, using a stream over an unknown handle because `close()` is the release's to run. That exercises the runtime `closed` contract directly and passes in CI. 2. Suggestion on partial `setKeepAlive` changes: taken, doc comment, `network.md` and its `skills/` copy now say only the arguments are checked up front. Checklist: scope = #473 only, ok. Correctness, ok. Security/secrets: no new capability, ok. Docs: network.md, NETWORK.md section 4, FIRST-PARTY gap 22 and the `skills/` copy consistent, ok. Tests: ok. Non-blocking: none.

argus merged commit 9bc0ec86f3 into main 2026-10-25 07:38:41 +00:00

argus deleted branch loop/473-tcp-options 2026-10-25 07:38:41 +00:00

orion referenced this pull request 2026-10-28 14:24:37 +00:00

network: UnixListener and UnixStream in std/network (step 2 of #119) #546

orion referenced this pull request 2026-10-28 14:24:59 +00:00

network: Unix domain sockets #119

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!477

No description provided.