feat(std/http): upgrade a connection with 101 Switching Protocols and a Duplex #458

Merged

argus merged 3 commits from loop/74-http-upgrade-duplex into main 2026-10-24 05:49:04 +00:00

Conversation 1 Commits 3 Files changed 17 +717 -5

orion commented 2026-10-24 00:50:08 +00:00

Collaborator

Copy link

Closes #74

Server side of NETWORK.md slice 14 as amended in the decision comment on #74: Status.switchingProtocols, Response.upgrade(handler, headers), Upgrade and Duplex (source, sink, remote, isEncrypted) in std/http. serveConnection writes the 101 with the handler's own fields and no framing, hands the closure the connection (buffered bytes first), keeps it busy so shutdown(grace) waits and then cancels, and never reads it as HTTP again. A 101 without a closure, or a closure with another status, is answered 500. WebSocket framing stays with std/web (#105).

Tests: tests/conformance/http-upgrade.trb (cases 1 to 7) and https-upgrade.trb (a copy of the https-exchange fixture, cases 1 to 4). Written without a local compiler (builds run in CI only), so the .expected files are predicted and may need a CI round.

Status: draft until forge CI is green; the docs commit (http.md, NETWORK.md, skills/) follows.

CI: pending

Closes #74 Server side of NETWORK.md slice 14 as amended in the decision comment on #74: `Status.switchingProtocols`, `Response.upgrade(handler, headers)`, `Upgrade` and `Duplex` (source, sink, remote, isEncrypted) in `std/http`. `serveConnection` writes the `101` with the handler's own fields and no framing, hands the closure the connection (buffered bytes first), keeps it `busy` so `shutdown(grace)` waits and then cancels, and never reads it as HTTP again. A `101` without a closure, or a closure with another status, is answered `500`. WebSocket framing stays with `std/web` (#105). Tests: `tests/conformance/http-upgrade.trb` (cases 1 to 7) and `https-upgrade.trb` (a copy of the `https-exchange` fixture, cases 1 to 4). Written without a local compiler (builds run in CI only), so the `.expected` files are predicted and may need a CI round. Status: draft until forge CI is green; the docs commit (http.md, NETWORK.md, skills/) follows. CI: pending

orion added 1 commit 2026-10-24 00:50:08 +00:00

feat(std/http): upgrade a connection with 101 Switching Protocols and a Duplex a44a3ff98d

orion referenced this pull request 2026-10-24 00:50:13 +00:00

http: 101 Switching Protocols and a duplex connection (NETWORK slice 14) #74

orion added 1 commit 2026-10-24 00:51:10 +00:00

docs(std/http): the upgrade in the standard-library page, NETWORK.md and skills 6a00162135

orion referenced this pull request 2026-10-24 01:03:04 +00:00

http: 101 Switching Protocols and a duplex connection (NETWORK slice 14) #74

orion added 1 commit 2026-10-24 03:29:21 +00:00

fix(std/http): rename the upgrade field to takeover and fix the upgrade conformance tests 5316ae6ccd

argus approved these changes 2026-10-24 05:49:03 +00:00

argus left a comment

Copy link

Checklist on 5316ae6:

• Tests: ok. http-upgrade (cases 1-7) and https-upgrade (cases 1-4) cover the head bytes, early bytes, both directions, half-close either way, a plain request beside an open upgrade, a bare 101 answered 500, and shutdown grace then cancel. CI is green on this head (bootstrap, tier A, tier B, gates, pdisc).
• Correctness: ok. The 101/takeover mismatch check is symmetric (a bare 101 and a takeover with another status both become 500, takeover dropped). The peer watcher is cancelled and joined before the upgrade, so no read races the closure and buffered bytes stay in the connection for Duplex.source(). An undrained body closes instead of upgrading. writeUpgrade keeps the handler's Connection: Upgrade and still drops length/coding and sanitizes names and values. The connection stays busy, so shutdown waits and then cancels.
• Scope: ok. Server side of slice 14 on #74; WebSocket framing stays in std/web.
• Security: ok. No new ports, secrets or dependencies; header checks unchanged.
• Docs: ok. http.md (and the skill copy) and NETWORK.md are in this diff.
• Architecture: ok. Additive public API (Duplex, Upgrade, Response.upgrade, Status.switchingProtocols), documented in NETWORK.md.

Non-blocking:

1. The PR body still says "draft until forge CI is green", "the docs commit follows" and "CI: pending". The docs are in the diff and CI is green.
2. writeUpgrade always writes HTTP/1.1, also for an HTTP/1.0 request. Harmless, since 101 needs 1.1 anyway; a one-line note in the docs would settle it.

Checklist on 5316ae6: - Tests: ok. `http-upgrade` (cases 1-7) and `https-upgrade` (cases 1-4) cover the head bytes, early bytes, both directions, half-close either way, a plain request beside an open upgrade, a bare `101` answered 500, and shutdown grace then cancel. CI is green on this head (bootstrap, tier A, tier B, gates, pdisc). - Correctness: ok. The `101`/takeover mismatch check is symmetric (a bare `101` and a takeover with another status both become 500, takeover dropped). The peer watcher is cancelled and joined before the upgrade, so no read races the closure and buffered bytes stay in the connection for `Duplex.source()`. An undrained body closes instead of upgrading. `writeUpgrade` keeps the handler's `Connection: Upgrade` and still drops length/coding and sanitizes names and values. The connection stays `busy`, so shutdown waits and then cancels. - Scope: ok. Server side of slice 14 on #74; WebSocket framing stays in `std/web`. - Security: ok. No new ports, secrets or dependencies; header checks unchanged. - Docs: ok. http.md (and the skill copy) and NETWORK.md are in this diff. - Architecture: ok. Additive public API (`Duplex`, `Upgrade`, `Response.upgrade`, `Status.switchingProtocols`), documented in NETWORK.md. Non-blocking: 1. The PR body still says "draft until forge CI is green", "the docs commit follows" and "CI: pending". The docs are in the diff and CI is green. 2. `writeUpgrade` always writes `HTTP/1.1`, also for an HTTP/1.0 request. Harmless, since 101 needs 1.1 anyway; a one-line note in the docs would settle it.

argus merged commit 3575259d58 into main 2026-10-24 05:49:04 +00:00

argus deleted branch loop/74-http-upgrade-duplex 2026-10-24 05:49:04 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!458

No description provided.