torbscript/language
Watch
1
0
Fork
You've already forked language
 0
Code Issues 139 Pull requests 2 Projects Releases 18 Packages 3 Wiki Activity Actions

Script receivers 3/6: diagnostics catalogue #514

New issue
Open
opened 2026-10-26 21:47:21 +00:00 by orion · 3 comments
orion commented 2026-10-26 21:47:21 +00:00
Collaborator
Copy link

Slice 4 of Design: docs/design/SCRIPT-RECEIVERS.md (branch docs/script-receivers). Part of the script-receivers epic.

The diagnostics D3-D18 of section 9, with exact texts, notes, related information and quick fixes.

Acceptance

  • Every diagnostic pinned with its exact text in compiler/tests/receivers.test.trb or compiler/tests/sandbox.test.trb.
  • D7 (overlap) is reported at both patterns, each with related information at the other.
  • D14 (type argument differs from mapping of a mapped file) carries related info at the scripts line and the fix "Load it as U".
  • D15 (literal load of an unmapped file) is an information/hint diagnostic, not an error, does not fail torb check, and carries the fix "Add to project.trb" with a correct scripts line.
  • D18 (loads of one unmapped file with different types) is an error at the second and further loads, related info at the first load; replaces first-load-wins.
  • D16 replaces the misleading NoModule for a use of a script.
  • D17 is the SandboxError of a runtime path loaded with the wrong type, or of an unmapped script failing only at run time.

Amended 2026-10-26 (owner): the scripts mapping is optional; unmapped scripts stay valid and are typed by inference from literal Sandbox.load calls, else untyped (SCRIPT-RECEIVERS.md sections 1, 5, 6).$\n\nDecided 2026-10-26 (owner): D3 (pattern matches no file) is retired, no such diagnostic exists; the number stays unused. D15 is always shown, by default and not configurable. Extra acceptance:

  • No diagnostic (not even a hint) for a pattern that matches no file; test pins it.
  • D15 and its quick fix are always reported; no option, setting or client switch turns them off.
Slice 4 of Design: `docs/design/SCRIPT-RECEIVERS.md` (branch `docs/script-receivers`). Part of the script-receivers epic. The diagnostics D3-D18 of section 9, with exact texts, notes, related information and quick fixes. Acceptance - [ ] Every diagnostic pinned with its exact text in `compiler/tests/receivers.test.trb` or `compiler/tests/sandbox.test.trb`. - [ ] D7 (overlap) is reported at both patterns, each with related information at the other. - [ ] D14 (type argument differs from mapping of a mapped file) carries related info at the `scripts` line and the fix "Load it as `U`". - [ ] D15 (literal load of an unmapped file) is an information/hint diagnostic, not an error, does not fail `torb check`, and carries the fix "Add to project.trb" with a correct `scripts` line. - [ ] D18 (loads of one unmapped file with different types) is an error at the second and further loads, related info at the first load; replaces first-load-wins. - [ ] D16 replaces the misleading `NoModule` for a `use` of a script. - [ ] D17 is the `SandboxError` of a runtime path loaded with the wrong type, or of an unmapped script failing only at run time. Amended 2026-10-26 (owner): the `scripts` mapping is optional; unmapped scripts stay valid and are typed by inference from literal `Sandbox.load` calls, else untyped (SCRIPT-RECEIVERS.md sections 1, 5, 6).$\n\nDecided 2026-10-26 (owner): D3 (pattern matches no file) is retired, no such diagnostic exists; the number stays unused. D15 is always shown, by default and not configurable. Extra acceptance: - [ ] No diagnostic (not even a hint) for a pattern that matches no file; test pins it. - [ ] D15 and its quick fix are always reported; no option, setting or client switch turns them off.
orion commented 2026-10-26 21:47:52 +00:00
Author
Collaborator
Copy link

Design PR: #519 · Epic: #518

Design PR: https://git.torb.dev/torbscript/language/pulls/519 · Epic: https://git.torb.dev/torbscript/language/issues/518
orion commented 2026-10-28 20:58:26 +00:00
Author
Collaborator
Copy link

[loop:torbscript] intake: in scope (author orion, label loop, slice 3 of the script-receivers epic #518); no duplicate. The diagnostics D3-D18 need the receivers of #513 (and the reader of #512) in place. Just in time: refine when #513 has landed. next: waiting (#513 landed)

[loop:torbscript] intake: in scope (author orion, label `loop`, slice 3 of the script-receivers epic #518); no duplicate. The diagnostics D3-D18 need the receivers of #513 (and the reader of #512) in place. Just in time: refine when #513 has landed. next: waiting (#513 landed)
orion commented 2026-10-28 23:56:56 +00:00
Author
Collaborator
Copy link

[loop:torbscript] note from the refine of #513 (#513): the checks that need an error text move here. #514 now also owns D14 (type argument differs from the mapping), D18 and the removal of "first load decides" for unmapped files (#513 keeps that rule until then), D6/D7 for a pattern that matches an entry, test, library or two receivers, D8-D13 for an unresolvable receiver:/from: (in #513 such a file is silently untyped), and D16/D17. The examples/config-dsl line stays with #517.

[loop:torbscript] note from the refine of #513 (https://git.torb.dev/torbscript/language/issues/513): the checks that need an error text move here. #514 now also owns D14 (type argument differs from the mapping), D18 and the removal of "first load decides" for unmapped files (#513 keeps that rule until then), D6/D7 for a pattern that matches an entry, test, library or two receivers, D8-D13 for an unresolvable `receiver:`/`from:` (in #513 such a file is silently untyped), and D16/D17. The `examples/config-dsl` line stays with #517.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
loop/705-default-shadow
loop/691-tensor-core
loop/705-fix-candidate
orion/456-tierb-probe
loop/164-measure2
loop/207-measure
loop/164-prototype
probe/207-count
loop/205-measure
loop/140-hide-staged
nightly-20261103
nightly-20261031
nightly-20261029
nightly-20261027
nightly-20261026
nightly-20261025
nightly-20261024
nightly-20261023
nightly-20261021
nightly-20261020
nightly-20261015
nightly-20261014
nightly-20261013
nightly-20261011
nightly-20261010
nightly-20261009
nightly-20261008
seeds
Labels
Clear labels   
loop
Backlog item of the project loop (Orion), see CONTRIBUTING

  
ready
Refined to the definition of ready

No labels
loop
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torbscript/language#514
No description provided.