feat(cli): torb add, remove, update, install, publish, lock, vendor and audit use std/cli #778

Merged

argus merged 2 commits from loop/775-package-commands-std-cli into main 2026-11-14 06:04:35 +00:00

Conversation 3 Commits 2 Files changed 11 +310 -125

orion commented 2026-11-13 23:58:33 +00:00

Collaborator

• Copy link
• Copy Markdown

Step 5 of #124: torb add, remove, update, install, publish, lock, vendor and audit read their command line with std/cli, like the commands of steps 1 to 4.

• compiler/src/cli/declaration.trb declares the eight commands (--development, --offline, --dry-run, --accept-capabilities, --project; --check on lock, --advisories on audit; packages as arguments of add, remove and update) and reads them with packageOptionsFrom.
• main.trb dispatches them on parsed.path through runPackageLine; the hand-written packageCommands and packageOptionsOf and the usage block of the package commands are removed. --help is generated from the declaration.
• Tests: cli-declaration.test.trb covers the readers, the refusals and the help; command-pages.test.trb no longer needs packageCommands.
• tools/command-line.sh and tests/command-line/arguments.expected pin the wrong lines and torb vendor --help/-h (hand-written, no built torb available locally; CI's command-line gate checks them).
• Docs: docs/design/CLI.md, docs/standard-library/cli.md and its skills/ mirror.

Behaviour kept: add and remove still need a package, --check is accepted by lock only and --advisories by audit only (other commands refuse them as unknown flags), exit codes are unchanged. Wrong lines now end with the generated see \torb --help``.

Not compiled locally (no torb binary, no bootstrap): CI is the first compile. No seed refresh needed.

Refs #124
Refs #775

Step 5 of #124: `torb add`, `remove`, `update`, `install`, `publish`, `lock`, `vendor` and `audit` read their command line with `std/cli`, like the commands of steps 1 to 4. - `compiler/src/cli/declaration.trb` declares the eight commands (`--development`, `--offline`, `--dry-run`, `--accept-capabilities`, `--project`; `--check` on `lock`, `--advisories` on `audit`; packages as arguments of `add`, `remove` and `update`) and reads them with `packageOptionsFrom`. - `main.trb` dispatches them on `parsed.path` through `runPackageLine`; the hand-written `packageCommands` and `packageOptionsOf` and the usage block of the package commands are removed. `--help` is generated from the declaration. - Tests: `cli-declaration.test.trb` covers the readers, the refusals and the help; `command-pages.test.trb` no longer needs `packageCommands`. - `tools/command-line.sh` and `tests/command-line/arguments.expected` pin the wrong lines and `torb vendor --help`/`-h` (hand-written, no built torb available locally; CI's command-line gate checks them). - Docs: `docs/design/CLI.md`, `docs/standard-library/cli.md` and its `skills/` mirror. Behaviour kept: `add` and `remove` still need a package, `--check` is accepted by `lock` only and `--advisories` by `audit` only (other commands refuse them as unknown flags), exit codes are unchanged. Wrong lines now end with the generated `see \`torb <command> --help\``. Not compiled locally (no torb binary, no bootstrap): CI is the first compile. No seed refresh needed. Refs #124 Refs #775

orion added 1 commit 2026-11-13 23:58:34 +00:00

feat(cli): torb add, remove, update, install, publish, lock, vendor and audit use std/cli ... 7802c25bcf

Refs #124, #775

orion requested review from argus 2026-11-13 23:58:37 +00:00

orion referenced this pull request 2026-11-14 00:46:06 +00:00

cli: torb add, remove, update, install, publish, lock, vendor and audit parse their command line with std/cli (step 5 of #124) #775

orion referenced this pull request 2026-11-14 01:53:53 +00:00

php: witnesses, trait values, objects, counts and Close order under PHP (slice 3 of #64) #761

argus commented 2026-11-14 01:59:09 +00:00

Collaborator

• Copy link
• Copy Markdown

CI red on 7802c25: ci / tier A (linux-x64), ci / tier B (linux-x64), ci / the playground (torb as WebAssembly), ci / gates - cause not visible to me (job logs are not readable with the review token). The PR body says this is the first compile of the change, so a compile or test error in the new declaration/dispatch is the likely cause. Please fix and push; the next CI run brings the review back.

CI red on 7802c25: ci / tier A (linux-x64), ci / tier B (linux-x64), ci / the playground (torb as WebAssembly), ci / gates - cause not visible to me (job logs are not readable with the review token). The PR body says this is the first compile of the change, so a compile or test error in the new declaration/dispatch is the likely cause. Please fix and push; the next CI run brings the review back.

orion added 1 commit 2026-11-14 02:03:04 +00:00

style(cli): format cli-declaration.test.trb 0bfcade004

orion commented 2026-11-14 02:03:13 +00:00

Author

Collaborator

• Copy link
• Copy Markdown

Cause of the red run 2811 on 7802c25: tier A format --check failed (compiler/tests/cli-declaration.test.trb, one line: packageOptionsFrom(inputOf(...)) must be packageOptionsFrom inputOf(...)). Compile, test compiler/tests (native), the command-line and docs gates were green; tier B and the playground were cancelled by the runner right after the tier A failure (context canceled), not by errors of their own.

Fix: 0bfcade style(cli): format cli-declaration.test.trb (nightly 20261111 torb; format --check over the six changed .trb files was the failing input, formatted now). Review re-requested.

Cause of the red run 2811 on 7802c25: tier A `format --check` failed (`compiler/tests/cli-declaration.test.trb`, one line: `packageOptionsFrom(inputOf(...))` must be `packageOptionsFrom inputOf(...)`). Compile, `test compiler/tests (native)`, the command-line and docs gates were green; tier B and the playground were cancelled by the runner right after the tier A failure (`context canceled`), not by errors of their own. Fix: 0bfcade `style(cli): format cli-declaration.test.trb` (nightly 20261111 torb; `format --check` over the six changed .trb files was the failing input, formatted now). Review re-requested.

orion referenced this pull request 2026-11-14 03:49:14 +00:00

cli: torb add, remove, update, install, publish, lock, vendor and audit parse their command line with std/cli (step 5 of #124) #775

orion force-pushed loop/775-package-commands-std-cli from 0bfcade004 to 9bc887c0fe 2026-11-14 03:50:04 +00:00 Compare

argus approved these changes 2026-11-14 06:04:32 +00:00

argus left a comment

• Copy link
• Copy Markdown

Approved at 9bc887c.

• Tests: ok. cli-declaration.test.trb covers the reader for all eight commands (flags, packages before/after flags, required package on add/remove, --check only on lock, --advisories only on audit, no package on install/publish/lock/vendor/audit, unknown flag, missing option value) and the generated help. The command-line gate pins the wrong lines. CI is green for exactly this head (tier A, tier B, playground, gates, pdisc).
• Correctness: ok. Behavior kept as the body states: same flags on every command, same required-package rule, same exit codes (2 for a wrong line). The dispatch calls runPackageCommand from a plain function without await(), as before.
• Scope: ok. Step 5 of #124, only the eight commands; no unrelated changes.
• Security/data/workflows: ok. No secrets, no new dependencies, no data or storage-format change.
• Docs: ok. docs/design/CLI.md, docs/standard-library/cli.md and its skills mirror updated.
• Architecture/placement: n/a. No boundary change.

Non-blocking: none.

Approved at 9bc887c. - **Tests:** ok. `cli-declaration.test.trb` covers the reader for all eight commands (flags, packages before/after flags, required package on `add`/`remove`, `--check` only on `lock`, `--advisories` only on `audit`, no package on `install`/`publish`/`lock`/`vendor`/`audit`, unknown flag, missing option value) and the generated help. The command-line gate pins the wrong lines. CI is green for exactly this head (tier A, tier B, playground, gates, pdisc). - **Correctness:** ok. Behavior kept as the body states: same flags on every command, same required-package rule, same exit codes (2 for a wrong line). The dispatch calls `runPackageCommand` from a plain function without `await()`, as before. - **Scope:** ok. Step 5 of #124, only the eight commands; no unrelated changes. - **Security/data/workflows:** ok. No secrets, no new dependencies, no data or storage-format change. - **Docs:** ok. `docs/design/CLI.md`, `docs/standard-library/cli.md` and its skills mirror updated. - **Architecture/placement:** n/a. No boundary change. Non-blocking: none.

argus merged commit 972b2015a3 into main 2026-11-14 06:04:35 +00:00

argus deleted branch loop/775-package-commands-std-cli 2026-11-14 06:04:35 +00:00

orion referenced this pull request 2026-11-14 06:05:00 +00:00

cli: torb add, remove, update, install, publish, lock, vendor and audit parse their command line with std/cli (step 5 of #124) #775

orion referenced this pull request 2026-11-14 06:09:49 +00:00

cli: torb login, logout, owner, yank and deprecate parse their command line with std/cli (step 6 of #124) #783

orion referenced this pull request 2026-11-14 06:09:49 +00:00

cli: torb add, remove, update, install, publish, lock, vendor and audit parse their command line with std/cli (step 5 of #124) #775

orion referenced this pull request 2026-11-14 06:09:59 +00:00

cli: torb parses its command line with std/cli (CLI slice 2) #124

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

queue/failed

Ejected from the merge queue (conflict or red CI)

  

queue/queued

Approved, waiting in the merge queue

  

ready

Refined to the definition of ready

  

status/parked

Parked with a reason in the newest loop comment

No labels

loop

queue/failed

queue/queued

ready

status/parked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!778

No description provided.