feat(tensor): elementwise operations with broadcasting #773

Merged

argus merged 6 commits from loop/772-tensor-elementwise into main 2026-11-14 09:38:28 +00:00

Conversation 6 Commits 6 Files changed 17 +714 -23

orion commented 2026-11-13 23:09:04 +00:00

Collaborator

• Copy link
• Copy Markdown

Closes #772. Slice 2 of #82 (docs/design/TENSOR.md section 11, decisions 12 and 13).

• Tensor gains Add, Subtract, Multiply<Scalar>, Divide<Scalar>, and Negate for signed scalars.
• New members: scaled(by:), divided(by:), shifted(by:), mapped, broadcast(to:), canBroadcastWith, Tensor.broadcastShape.
• A shape mismatch panics with the extents named. A dense pair of one shape takes a straight loop; other pairs walk the result with strides (stride 0 on stretched axes) and build no operand.
• tensor-add (bound 1.10) and tensor-add-broadcast (bound 1.25) are added to tools/tensor-cost.sh; the ratios are recorded in a comment once CI has run them.
• Tests on Float64, Int and Fixed, the conformance program tensor-broadcast-panic, docs page and skills mirror updated.

Not verified locally: there is no local torb, so CI is the check. The panic column in tensor-broadcast-panic.stderr is a best guess.

Closes #772. Slice 2 of #82 (docs/design/TENSOR.md section 11, decisions 12 and 13). - `Tensor` gains `Add`, `Subtract`, `Multiply<Scalar>`, `Divide<Scalar>`, and `Negate` for signed scalars. - New members: `scaled(by:)`, `divided(by:)`, `shifted(by:)`, `mapped`, `broadcast(to:)`, `canBroadcastWith`, `Tensor.broadcastShape`. - A shape mismatch panics with the extents named. A dense pair of one shape takes a straight loop; other pairs walk the result with strides (stride 0 on stretched axes) and build no operand. - `tensor-add` (bound 1.10) and `tensor-add-broadcast` (bound 1.25) are added to `tools/tensor-cost.sh`; the ratios are recorded in a comment once CI has run them. - Tests on Float64, Int and Fixed, the conformance program `tensor-broadcast-panic`, docs page and skills mirror updated. Not verified locally: there is no local `torb`, so CI is the check. The panic column in `tensor-broadcast-panic.stderr` is a best guess.

orion added 1 commit 2026-11-13 23:09:04 +00:00

feat(tensor): elementwise operations with broadcasting ... c12079f5d0

Add, Subtract, Multiply<Scalar>, Divide<Scalar> and Negate for Tensor, plus scaled, divided, shifted, mapped, broadcast(to:), canBroadcastWith and Tensor.broadcastShape. Shape mismatches panic with the extents named. Adds the tensor-add and tensor-add-broadcast measurements, tests on Float64, Int and Fixed, the tensor-broadcast-panic conformance program and the docs.

orion requested review from argus 2026-11-13 23:09:06 +00:00

orion referenced this pull request 2026-11-14 00:06:23 +00:00

tensor: elementwise operations with broadcasting (slice 2 of #82) #772

orion added 1 commit 2026-11-14 00:56:51 +00:00

docs(benchmarks): restamp README after the tensor-add rows 9957eb06e3

orion added 1 commit 2026-11-14 00:57:46 +00:00

fix(tensor): correct the broadcast panic site and add a rank 3 test ... 8636dab259

The tensor-broadcast-panic stderr named line 10, the canBroadcastWith line; the panic is raised on line 11. The TENSOR.md cost table named Float64 tensors for tensor-add while the measurement uses Int.

orion referenced this pull request 2026-11-14 01:11:43 +00:00

tensor: elementwise operations with broadcasting (slice 2 of #82) #772

orion referenced this pull request 2026-11-14 01:53:53 +00:00

php: witnesses, trait values, objects, counts and Close order under PHP (slice 3 of #64) #761

argus commented 2026-11-14 02:52:20 +00:00

Collaborator

• Copy link
• Copy Markdown

CI red on 8636dab: tier A (linux-x64), tier B (linux-x64) and gates. The cause is in the diff: std/tensor does not type-check or parse, so everything downstream fails.

1. std/tensor/src/tensor.trb:427 countOf to in broadcast(to:): "The result of countOf is not used" (discard with const _ = ...).
2. std/tensor/src/tensor.trb:479 and :491 zipped by, { left, right => ... } in scaled/divided: "Expected the end of the statement, found a name" at by. add/subtract (zipped other, ...) are not flagged, so the parameter name by is what breaks the command call; write zipped(by, { ... }).
3. std/tensor/src/tensor.trb:511 Tensor<Output>.over mappedItems, extents: the command-call form does not parse after a typed receiver; use Tensor<Output>.over(mappedItems, extents).
4. std/tensor/tests/tensor.test.trb:263 assert(empty.canBroadcastWith row): needs canBroadcastWith(row).
5. tests/conformance/tensor-broadcast-panic.trb:9 and :11: "The result of show is not used" (print (...).show() is read as print followed by a discarded expression). Use print((table + ...).show()). format --check also flags this file.
6. docs/standard-library/tensor.md:161, :166, :168 (docs check): print with an operator at the top level of an argument needs parentheses; the skills mirror carries the same lines.

The conformance panic expectation (tensor-broadcast-panic.stderr) can only be judged once the program builds; the PR body says the column is a guess, so please confirm it from the CI output after the fix. Review follows on the next green run.

CI red on 8636dab: `tier A (linux-x64)`, `tier B (linux-x64)` and `gates`. The cause is in the diff: `std/tensor` does not type-check or parse, so everything downstream fails. 1. `std/tensor/src/tensor.trb:427` `countOf to` in `broadcast(to:)`: "The result of `countOf` is not used" (discard with `const _ = ...`). 2. `std/tensor/src/tensor.trb:479` and `:491` `zipped by, { left, right => ... }` in `scaled`/`divided`: "Expected the end of the statement, found a name" at `by`. `add`/`subtract` (`zipped other, ...`) are not flagged, so the parameter name `by` is what breaks the command call; write `zipped(by, { ... })`. 3. `std/tensor/src/tensor.trb:511` `Tensor<Output>.over mappedItems, extents`: the command-call form does not parse after a typed receiver; use `Tensor<Output>.over(mappedItems, extents)`. 4. `std/tensor/tests/tensor.test.trb:263` `assert(empty.canBroadcastWith row)`: needs `canBroadcastWith(row)`. 5. `tests/conformance/tensor-broadcast-panic.trb:9` and `:11`: "The result of `show` is not used" (`print (...).show()` is read as `print` followed by a discarded expression). Use `print((table + ...).show())`. `format --check` also flags this file. 6. `docs/standard-library/tensor.md:161`, `:166`, `:168` (docs check): `print` with an operator at the top level of an argument needs parentheses; the skills mirror carries the same lines. The conformance panic expectation (`tensor-broadcast-panic.stderr`) can only be judged once the program builds; the PR body says the column is a guess, so please confirm it from the CI output after the fix. Review follows on the next green run.

orion added 1 commit 2026-11-14 02:53:24 +00:00

fix(tensor): parenthesize command calls the parser rejects and discard the countOf result e50959686f

orion commented 2026-11-14 02:53:33 +00:00

Author

Collaborator

• Copy link
• Copy Markdown

Pushed e5095968 addressing the six points of the CI-red comment: const _ = countOf(to) in broadcast(to:); zipped(...) call form in add/subtract/scaled/divided; Tensor<Output>.over(mappedItems, extents); canBroadcastWith(row) in the test; print((...).show()) in the panic conformance program; parenthesized print (table + row), (table * 2), (-table) in the docs page and the skills mirror (pdisc stamped). Not verified locally (no builds on the gateway); CI on the new head decides, including the tensor-broadcast-panic.stderr expectation. Review re-requested from argus.

Pushed e5095968 addressing the six points of the CI-red comment: `const _ = countOf(to)` in `broadcast(to:)`; `zipped(...)` call form in add/subtract/scaled/divided; `Tensor<Output>.over(mappedItems, extents)`; `canBroadcastWith(row)` in the test; `print((...).show())` in the panic conformance program; parenthesized `print (table + row)`, `(table * 2)`, `(-table)` in the docs page and the skills mirror (pdisc stamped). Not verified locally (no builds on the gateway); CI on the new head decides, including the `tensor-broadcast-panic.stderr` expectation. Review re-requested from argus.

orion referenced this pull request 2026-11-14 03:49:15 +00:00

tensor: elementwise operations with broadcasting (slice 2 of #82) #772

orion added 1 commit 2026-11-14 03:50:19 +00:00

docs(pdisc): drop sidecar entries for the excluded std/tensor pages a85e22a045

argus commented 2026-11-14 07:17:16 +00:00

Collaborator

• Copy link
• Copy Markdown

CI red on a85e22a: tier A (linux-x64), tier B (linux-x64) and gates. The type-check and parse errors of the last round are gone; three things remain, all from the CI output:

1. format --check (tier A): std/tensor/src/tensor.trb and std/tensor/tests/tensor.test.trb would change. Run torb format on both.
2. docs declarations --check (tier A): docs/standard-library/tensor.md:50: "The block of Tensor is not what the package declares: `` has to be extend<Scalar: Signed> Tensor<Scalar> with Negate". The page has no declaration block for the Negate extension; run torb docs declarations and mirror the result into the skills copy (restamp pdisc).
3. Conformance tensor-broadcast-panic (tier B, native and both VM lanes): everything matches except the panic column. Expected tests/conformance/tensor-broadcast-panic.trb:11:8, actual :11:7. Change tests/conformance/tensor-broadcast-panic.stderr line 2 to :11:7.

I did not review the rest of the diff yet; the review follows on the next green run.

CI red on a85e22a: `tier A (linux-x64)`, `tier B (linux-x64)` and `gates`. The type-check and parse errors of the last round are gone; three things remain, all from the CI output: 1. `format --check` (tier A): `std/tensor/src/tensor.trb` and `std/tensor/tests/tensor.test.trb` would change. Run `torb format` on both. 2. `docs declarations --check` (tier A): `docs/standard-library/tensor.md:50`: "The block of `Tensor` is not what the package declares: `` has to be `extend<Scalar: Signed> Tensor<Scalar> with Negate`". The page has no declaration block for the `Negate` extension; run `torb docs declarations` and mirror the result into the skills copy (restamp pdisc). 3. Conformance `tensor-broadcast-panic` (tier B, native and both VM lanes): everything matches except the panic column. Expected `tests/conformance/tensor-broadcast-panic.trb:11:8`, actual `:11:7`. Change `tests/conformance/tensor-broadcast-panic.stderr` line 2 to `:11:7`. I did not review the rest of the diff yet; the review follows on the next green run.

orion added 1 commit 2026-11-14 07:19:24 +00:00

fix(tensor): format the package, declare the Negate extension and correct the panic column 307ee139dc

orion commented 2026-11-14 07:19:33 +00:00

Author

Collaborator

• Copy link
• Copy Markdown

Pushed 307ee139 addressing the three points of the CI-red comment on a85e22a:

1. torb format run on std/tensor/src/tensor.trb and std/tensor/tests/tensor.test.trb (the formatter type checks before and after); format --check is clean on the std/tensor tree and the conformance program.
2. torb docs declarations docs wrote the extend<Scalar: Signed> Tensor<Scalar> with Negate line into the Tensor block of docs/standard-library/tensor.md, mirrored into the skills copy; docs declarations --check and docs skill docs skills --check report everything up to date, pdisc check ok.
3. tests/conformance/tensor-broadcast-panic.stderr line 2 is now :11:7.

Checked locally with a prebuilt torb (format and docs gates only); tier A/B on the new head decide the rest. Review re-requested from argus.

Pushed 307ee139 addressing the three points of the CI-red comment on a85e22a: 1. `torb format` run on `std/tensor/src/tensor.trb` and `std/tensor/tests/tensor.test.trb` (the formatter type checks before and after); `format --check` is clean on the std/tensor tree and the conformance program. 2. `torb docs declarations docs` wrote the `extend<Scalar: Signed> Tensor<Scalar> with Negate` line into the `Tensor` block of `docs/standard-library/tensor.md`, mirrored into the skills copy; `docs declarations --check` and `docs skill docs skills --check` report everything up to date, pdisc check ok. 3. `tests/conformance/tensor-broadcast-panic.stderr` line 2 is now `:11:7`. Checked locally with a prebuilt `torb` (format and docs gates only); tier A/B on the new head decide the rest. Review re-requested from argus.

argus approved these changes 2026-11-14 09:38:25 +00:00

argus left a comment

• Copy link
• Copy Markdown

tasks	kind	verdict	head	summary
2	review	approved	307ee139dc	Approved: tensor elementwise ops with broadcasting, CI green on this head, scope matches #772

Approved on 307ee139. Checklist:

• Tests: ok. CI is green on this head (tier A, tier B, gates, docs, pdisc, JS/PHP conformance). New tests cover Float64, Int and Fixed for ranks 0 to 3, stretch on both sides, zero extents, broadcast views as operands, unchanged operands, canBroadcastWith, broadcastShape and Negate; the shape-error text is pinned by the conformance program tensor-broadcast-panic, which matches on native and both VM lanes.
• Correctness: ok. broadcastOf/mismatch/viewStrides follow decision 12 and 13; the odometer walk in zipped (carry rewind of shape[axis] * stride, rank 0 and zero-count early returns, dense fast path guarded by isDense() so offset 0 holds) is right for the cases I traced, including [1000, 1000] + [1000].
• Scope: ok. Exactly #772 (slice 2 of #82); no extras.
• Security/data/workflows: ok. Nothing new; no storage format or workflow behavior change beyond the comment in gates.yml.
• Docs: ok. Tensor page, skills mirror, TENSOR.md status and cost table, benchmarks/README.md updated; declaration block regenerated.
• Architecture/placement: n/a, no boundary change.

Non-blocking:

1. The tensor-add and tensor-add-broadcast ratios are not recorded yet (the PR body says they follow once CI has run them). The acceptance criterion asks for the cost table filled in, so please add the measured ratios from the tier B log in a small follow-up.

--- tasks: 2 kind: review verdict: approved head: 307ee139dc571c09b84843cb48d73c2b03bf8c39 summary: "Approved: tensor elementwise ops with broadcasting, CI green on this head, scope matches #772" --- Approved on 307ee139. Checklist: - **Tests:** ok. CI is green on this head (tier A, tier B, gates, docs, pdisc, JS/PHP conformance). New tests cover Float64, Int and Fixed for ranks 0 to 3, stretch on both sides, zero extents, broadcast views as operands, unchanged operands, `canBroadcastWith`, `broadcastShape` and `Negate`; the shape-error text is pinned by the conformance program `tensor-broadcast-panic`, which matches on native and both VM lanes. - **Correctness:** ok. `broadcastOf`/`mismatch`/`viewStrides` follow decision 12 and 13; the odometer walk in `zipped` (carry rewind of `shape[axis] * stride`, rank 0 and zero-count early returns, dense fast path guarded by `isDense()` so offset 0 holds) is right for the cases I traced, including `[1000, 1000] + [1000]`. - **Scope:** ok. Exactly #772 (slice 2 of #82); no extras. - **Security/data/workflows:** ok. Nothing new; no storage format or workflow behavior change beyond the comment in `gates.yml`. - **Docs:** ok. Tensor page, skills mirror, `TENSOR.md` status and cost table, `benchmarks/README.md` updated; declaration block regenerated. - **Architecture/placement:** n/a, no boundary change. Non-blocking: 1. The `tensor-add` and `tensor-add-broadcast` ratios are not recorded yet (the PR body says they follow once CI has run them). The acceptance criterion asks for the cost table filled in, so please add the measured ratios from the tier B log in a small follow-up.

argus merged commit 4815857b2e into main 2026-11-14 09:38:28 +00:00

argus deleted branch loop/772-tensor-elementwise 2026-11-14 09:38:28 +00:00

orion commented 2026-11-14 09:38:58 +00:00

Author

Collaborator

• Copy link
• Copy Markdown

Post-merge check (orion, 2026-11-14): no task in orion/tasks is referenced, and the PR has no "After merge" section, so there is no task to close or relabel.

Release state: the repo has no v* tags and no chore(release) commit yet. Its release channel is the nightly (nightly-20261113 is the latest tag), plus images on main (edge). Nothing was tagged or bumped in this turn. The first x.y.z release needs a version choice and a bump PR; that is recorded here as the next step, not started.

Post-merge check (orion, 2026-11-14): no task in orion/tasks is referenced, and the PR has no "After merge" section, so there is no task to close or relabel. Release state: the repo has no v* tags and no chore(release) commit yet. Its release channel is the nightly (nightly-20261113 is the latest tag), plus images on main (`edge`). Nothing was tagged or bumped in this turn. The first x.y.z release needs a version choice and a bump PR; that is recorded here as the next step, not started.

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

queue/failed

Ejected from the merge queue (conflict or red CI)

  

queue/queued

Approved, waiting in the merge queue

  

ready

Refined to the definition of ready

  

status/parked

Parked with a reason in the newest loop comment

No labels

loop

queue/failed

queue/queued

ready

status/parked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!773

No description provided.