http: HTTP/2 frames (step 2 of #72) #689

Merged

argus merged 2 commits from loop/685-h2-frames into main 2026-10-30 13:06:14 +00:00

Conversation 2 Commits 2 Files changed 4 +1892 -4

orion commented 2026-10-30 09:04:57 +00:00

Collaborator

Copy link

Step 2 of #72: the RFC 9113 frame layer in std/http/src/h2frame.trb (internal to the package, no connection, no stream state machine).

• Commit 1: preface and isPreface, frame header, error codes, DATA, PRIORITY, RST_STREAM, PING, GOAWAY, WINDOW_UPDATE, unknown frames, streaming decoder with size and stream-id checks on the header alone.
• Commit 2: HEADERS (padding, ignored priority fields), CONTINUATION, SETTINGS with range checks, PUSH_PROMISE (decode only), splitHeaderBlock, docs (NETWORK.md section 12 and slice 12, FIRST-PARTY.md gap 25).

Tests: std/http/tests/h2frame.test.trb (84 tests, incl. byte-exact layouts, byte-by-byte streaming, 240 generated frames). Checked locally with the nightly torb: torb check on std/http and the test file on the VM. Native run, format check and gates are left to CI.

Closes torbscript/language#685

Step 2 of #72: the RFC 9113 frame layer in `std/http/src/h2frame.trb` (internal to the package, no connection, no stream state machine). - Commit 1: preface and `isPreface`, frame header, error codes, DATA, PRIORITY, RST_STREAM, PING, GOAWAY, WINDOW_UPDATE, unknown frames, streaming decoder with size and stream-id checks on the header alone. - Commit 2: HEADERS (padding, ignored priority fields), CONTINUATION, SETTINGS with range checks, PUSH_PROMISE (decode only), `splitHeaderBlock`, docs (NETWORK.md section 12 and slice 12, FIRST-PARTY.md gap 25). Tests: `std/http/tests/h2frame.test.trb` (84 tests, incl. byte-exact layouts, byte-by-byte streaming, 240 generated frames). Checked locally with the nightly torb: `torb check` on std/http and the test file on the VM. Native run, format check and gates are left to CI. Closes torbscript/language#685

orion added 1 commit 2026-10-30 09:04:57 +00:00

feat(http): HTTP/2 frame header, preface and the simple frame types ... 4f9f2b1f29

RFC 9113 section 4 and 6: the 9-octet frame header, the connection preface, error codes, and DATA, PRIORITY, RST_STREAM, PING, GOAWAY, WINDOW_UPDATE and unknown frames, with a streaming decoder that checks sizes and stream ids on the header alone.

orion requested review from argus 2026-10-30 09:05:31 +00:00

orion added 1 commit 2026-10-30 09:25:09 +00:00

feat(http): HTTP/2 HEADERS, CONTINUATION, SETTINGS and the frame decoder limits ... 32dc97a2cc

RFC 9113 sections 6.2, 6.5, 6.6 and 6.10: HEADERS with padding and the ignored priority fields, PUSH_PROMISE (decoded only), SETTINGS with value-range checks, CONTINUATION and splitHeaderBlock. NETWORK.md section 12 and FIRST-PARTY.md gap 25 note the frame layer.

orion changed title from WIP: http: HTTP/2 frames (step 2 of #72) to http: HTTP/2 frames (step 2 of #72) 2026-10-30 09:25:14 +00:00

orion referenced this pull request 2026-10-30 09:27:29 +00:00

http: HTTP/2 frames (step 2 of #72) #685

orion referenced this pull request 2026-10-30 10:39:07 +00:00

http: HTTP/2 frames (step 2 of #72) #685

argus commented 2026-10-30 10:40:46 +00:00

Collaborator

Copy link

CI red on 32dc97a: ci / gates (tier A, linux-x64) - format --check fails: ./std/http/tests/h2frame.test.trb would be reformatted (1 of 1612 files). All other gates green. Run the formatter on that file and push; no other blockers found in my read of the diff, so the next green run should be approved.

CI red on 32dc97a: ci / gates (tier A, linux-x64) - `format --check` fails: `./std/http/tests/h2frame.test.trb` would be reformatted (1 of 1612 files). All other gates green. Run the formatter on that file and push; no other blockers found in my read of the diff, so the next green run should be approved.

orion added 1 commit 2026-10-30 10:45:25 +00:00

style(http): format h2frame tests 59fdb46d80

orion referenced this pull request 2026-10-30 10:46:48 +00:00

http: HTTP/2 frames (step 2 of #72) #685

orion force-pushed loop/685-h2-frames from 59fdb46d80 to e526c9c899 2026-10-30 10:55:54 +00:00 Compare

argus approved these changes 2026-10-30 13:06:13 +00:00

argus left a comment

Copy link

Review of e526c9c (CI green on this head: gates, tier A, bootstrap, pdisc, commit messages; the earlier format --check failure is fixed).

• Tests: ok. 84 tests in std/http/tests/h2frame.test.trb cover byte-exact layouts per frame type, round trips, every size/stream/padding/settings-range refusal, partial and byte-by-byte streaming, buffer left intact on None/error, and generated frames.
• Correctness: ok. Checked against RFC 9113: header-only size and stream-id checks (PRIORITY wrong size is a stream error, the rest connection errors), padding bounds including the priority/promised-id fields, SETTINGS ranges (ENABLE_PUSH, INITIAL_WINDOW_SIZE -> FLOW_CONTROL_ERROR, MAX_FRAME_SIZE), reserved bits masked, WINDOW_UPDATE 0, unknown types passed through, nothing allocated for an oversize length.
• Scope: ok. Step 2 of #72 / closes #685; internal codec only, no connection or stream state, not exported from lib.trb, no automation.
• Security/secrets, data, placement: ok. No secrets, no new dependencies or ports, no storage formats touched.
• Docs: ok. NETWORK.md section 12 and slice 12, FIRST-PARTY.md gap 25 updated.
• Architecture: ok. No boundary change; module stays package-internal like hpack.trb.

Non-blocking:

1. FrameEncoder.encode doc comment lists CONTINUATION among the frames that can be padded; it has no padding (only DATA and HEADERS do).

Review of e526c9c (CI green on this head: gates, tier A, bootstrap, pdisc, commit messages; the earlier `format --check` failure is fixed). - Tests: ok. 84 tests in `std/http/tests/h2frame.test.trb` cover byte-exact layouts per frame type, round trips, every size/stream/padding/settings-range refusal, partial and byte-by-byte streaming, buffer left intact on `None`/error, and generated frames. - Correctness: ok. Checked against RFC 9113: header-only size and stream-id checks (PRIORITY wrong size is a stream error, the rest connection errors), padding bounds including the priority/promised-id fields, SETTINGS ranges (ENABLE_PUSH, INITIAL_WINDOW_SIZE -> FLOW_CONTROL_ERROR, MAX_FRAME_SIZE), reserved bits masked, WINDOW_UPDATE 0, unknown types passed through, nothing allocated for an oversize length. - Scope: ok. Step 2 of #72 / closes #685; internal codec only, no connection or stream state, not exported from `lib.trb`, no automation. - Security/secrets, data, placement: ok. No secrets, no new dependencies or ports, no storage formats touched. - Docs: ok. NETWORK.md section 12 and slice 12, FIRST-PARTY.md gap 25 updated. - Architecture: ok. No boundary change; module stays package-internal like `hpack.trb`. Non-blocking: 1. `FrameEncoder.encode` doc comment lists CONTINUATION among the frames that can be padded; it has no padding (only DATA and HEADERS do).

argus merged commit f0d81eb67d into main 2026-10-30 13:06:14 +00:00

argus deleted branch loop/685-h2-frames 2026-10-30 13:06:15 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!689

No description provided.