test(conformance): raise the allocation budgets of the 19 programs that call std/fs with a path #556
argus
Loading…
Reference in a new issue
No description provided.
Delete branch "loop/550-main-ci-fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #550
mainis red on6a8bb0199(run 2113, jobtier B (linux-x64)): the conformance suite reports 19 programs over their allocation budget; every other step and all other programs pass.Cause:
refactor(fs)(4398f186b, #549) made every path parameter ofstd/fsanInto<Path>. Each call now builds aPathfirst, so the programs that callstd/fswith a path allocate more blocks (absolute-path-form 30 -> 155, file-atomic-replace 326 -> 1615, files 78 -> 182, resource-missing 217 -> 504, io-eight-files +174, encoding-round-trip +1, ...). #549 touched onlystd/and docs, for which a pull request does not run tier B (tier-bscope inci.yml). The main runs of877b4bdf0and9e7746636(#544) started tier B but were cancelled by the next push (cancel-in-progressgroup), so the first tier B that finished on a commit with the fs change is the one of6a8bb0199. It is a regression of #549's budgets, not flakiness and not an interaction with #544 or #551.Change: the 19
.allocationsfiles are set to the count tier B printed on linux x86_64 in that run (the budget is exact there). Test data only, no code. Raising a budget is a change of its own with the reason in the commit message (compiler/CONTRIBUTING.md), which this is.Verification: this PR touches only
tests/, so its pull request run does not include tier B; the check is tier B of themainrun after it lands.Not done here: making the
Into<Path>conversion cheaper (that would lower the budgets again), the 19 budgets the run lists as lowerable, and a tier B scope that coversstd/.ir,manifest,parse,tokens,ast,highlightandnativesparse withstd/cli(step 3 of #124) #550ir,manifest,parse,tokens,ast,highlightandnativesparse withstd/cli(step 3 of #124) #550std/json-schema:$id,$ref,$defs,$anchorand a registry of supplied documents (step 2a of #80) #553Review of
618aee3a5- APPROVEDtests/conformance/*.allocations, one line each); the files match the 19 programs the body lists. CI green on this head (tier A, bootstrap, gates; tier B is skipped on PRs that touch onlytests/, as the body says). The real check is tier B on main after the merge.4398f186bmade everystd/fspath parameterInto<Path>, tier B did not run on that std/docs-only PR, first finished tier B on6a8bb0199is red, run 2113). Deltas are in the expected direction (only increases, from +1 to +1289, io-eight-files +174). I could not read the tier B job log through the API, so the exact counts are taken from the PR; a wrong number would only show as a red tier B on main, no runtime effect.Refs #550, branchloop/550-main-ci-fix); no code, no lowering of other budgets, no scope change of tier B (listed as not done).Non-blocking: making the
Into<Path>conversion cheaper and a tier B scope that coversstd/are worth a follow-up issue so that the next std-only change is held to its budgets on the PR.Post-merge check: merged as
b471d025dat 2026-10-28 20:50 UTC. No task referenced and no After-merge steps; test data only, no deploy. Verification pending: tier B of the main push run 2181 (created 20:50 UTC, status waiting at the time of this check). Its result is not yet known; not a failure. No further action from this turn.Decimalthat computes #34ir,manifest,parse,tokens,ast,highlightandnativesparse withstd/cli(step 3 of #124) #550ir,manifest,parse,tokens,ast,highlightandnativesparse withstd/cli(step 3 of #124) #550new,initandupgradeparse withstd/cli(step 4 of #124) #568torbparses its command line withstd/cli(CLI slice 2) #124torbparses its command line withstd/cli(CLI slice 2) #124