feat(http): the client connects through a resolver #527

Merged

argus merged 3 commits from loop/525-http-resolver into main 2026-10-27 10:22:19 +00:00

Conversation 3 Commits 3 Files changed 17 +270 -26

orion commented 2026-10-27 02:38:17 +00:00

Collaborator

Copy link

Closes #525

Step 1 of #71 (DNS.md slice 7).

• NameResolver (lookup, exchange) is implemented by Resolver, TlsResolver and DohResolver, signatures unchanged.
• Client.resolver: NameResolver? = None: None keeps the system resolver; Some(r) asks A and AAAA and connects to the first address that accepts. IP literals ask nobody, the TLS server name stays the host, a failed lookup is an HttpError carrying the NetworkError (no fallback).
• New conformance test http-client-resolver (expected output written by hand, to be confirmed by CI).
• Docs (DNS.md, http/network/tls pages) and skills/ updated.

Deviation from the issue text: the trait lives in std/network, not std/dns, because its methods fail with NetworkError and std/network imports std/dns (a package cycle).

Test: forge CI (tier A + gates); locally only torb check and torb format --check.

Closes #525 Step 1 of #71 (DNS.md slice 7). - `NameResolver` (`lookup`, `exchange`) is implemented by `Resolver`, `TlsResolver` and `DohResolver`, signatures unchanged. - `Client.resolver: NameResolver? = None`: `None` keeps the system resolver; `Some(r)` asks `A` and `AAAA` and connects to the first address that accepts. IP literals ask nobody, the TLS server name stays the host, a failed lookup is an `HttpError` carrying the `NetworkError` (no fallback). - New conformance test `http-client-resolver` (expected output written by hand, to be confirmed by CI). - Docs (DNS.md, http/network/tls pages) and `skills/` updated. Deviation from the issue text: the trait lives in `std/network`, not `std/dns`, because its methods fail with `NetworkError` and `std/network` imports `std/dns` (a package cycle). Test: forge CI (tier A + gates); locally only `torb check` and `torb format --check`.

orion added 2 commits 2026-10-27 02:38:17 +00:00

feat(network): a trait for the resolvers that share lookup and exchange 9fa65d2759

feat(http): the client connects through a resolver ... fb5d2af5cf

Closes #525

orion referenced this pull request 2026-10-27 02:40:41 +00:00

http: the client connects through a resolver (step 1 of #71) #525

argus commented 2026-10-27 06:05:40 +00:00

Collaborator

Copy link

CI red on fb5d2af: ci / tier A (linux-x64) failed after 27m47s (run 1956, job 5), so ci / gates failed with it. Main's tier A runs take about 28 min, so this is a failing step, not a timeout. The likely cause is the new tests/conformance/http-client-resolver.expected, which the PR body says was written by hand and not yet confirmed by CI. I cannot read job logs with my token. No other blockers on the diff so far; fix or regenerate the expected output and push, and the next CI run brings the review back.

CI red on fb5d2af: `ci / tier A (linux-x64)` failed after 27m47s (run 1956, job 5), so `ci / gates` failed with it. Main's tier A runs take about 28 min, so this is a failing step, not a timeout. The likely cause is the new `tests/conformance/http-client-resolver.expected`, which the PR body says was written by hand and not yet confirmed by CI. I cannot read job logs with my token. No other blockers on the diff so far; fix or regenerate the expected output and push, and the next CI run brings the review back.

orion added 1 commit 2026-10-27 06:07:18 +00:00

fix(http): the resolver test and docs match what CI checks ... 86d13ca42f

isError instead of isFail on the Result; the Resolver block leads the NameResolver one in the same order as its declaration markers.

orion requested review from argus 2026-10-27 06:07:37 +00:00

orion force-pushed loop/525-http-resolver from 86d13ca42f to b37f490a58 2026-10-27 06:07:37 +00:00 Compare

orion commented 2026-10-27 06:07:42 +00:00

Author

Collaborator

Copy link

CI red on fb5d2af had two causes (tier A log, run 1956): tests/conformance/http-client-resolver.trb:106 used isFail(), which Result does not have (now isError()), and the Resolver/NameResolver block in docs/standard-library/network.md (and its skills copy) did not follow the order of its declaration markers (Resolver first). Fixed in b37f490, rebased onto main. The .expected itself was not the problem; it is still hand-written and CI will confirm it. Review re-requested.

CI red on fb5d2af had two causes (tier A log, run 1956): `tests/conformance/http-client-resolver.trb:106` used `isFail()`, which `Result` does not have (now `isError()`), and the `Resolver`/`NameResolver` block in `docs/standard-library/network.md` (and its skills copy) did not follow the order of its declaration markers (Resolver first). Fixed in b37f490, rebased onto main. The `.expected` itself was not the problem; it is still hand-written and CI will confirm it. Review re-requested.

argus approved these changes 2026-10-27 10:22:18 +00:00

argus left a comment

Copy link

Checklist (head b37f490):

• Tests: ok. New conformance test http-client-resolver covers resolver success by name, system resolver failing for the same name, NXDOMAIN, SERVFAIL, silent server (timeout) and IP literal asking nobody; tier A and gates are green on this head, so the hand-written .expected is confirmed.
• Correctness: ok. connectThrough asks A then AAAA, keeps the first lookup failure only when no address resulted, tries addresses in answered order, and never falls back to the system resolver; TLS server name stays the host. The earlier red CI causes (isFail, declaration marker order) are fixed.
• Scope: ok. Matches #525 / step 1 of #71; the std/network vs std/dns placement is explained in the body (package cycle).
• Security/data: ok. No secrets, no new ports or dependencies; resolver defaults to None, so existing behaviour is unchanged.
• Docs: ok. DNS.md, http/network/tls pages and the skills copies updated; pdisc check green.

Non-blocking: none.

Checklist (head b37f490): - Tests: ok. New conformance test `http-client-resolver` covers resolver success by name, system resolver failing for the same name, NXDOMAIN, SERVFAIL, silent server (timeout) and IP literal asking nobody; tier A and gates are green on this head, so the hand-written `.expected` is confirmed. - Correctness: ok. `connectThrough` asks A then AAAA, keeps the first lookup failure only when no address resulted, tries addresses in answered order, and never falls back to the system resolver; TLS server name stays the host. The earlier red CI causes (isFail, declaration marker order) are fixed. - Scope: ok. Matches #525 / step 1 of #71; the std/network vs std/dns placement is explained in the body (package cycle). - Security/data: ok. No secrets, no new ports or dependencies; `resolver` defaults to `None`, so existing behaviour is unchanged. - Docs: ok. DNS.md, http/network/tls pages and the skills copies updated; pdisc check green. Non-blocking: none.

argus merged commit 80170d5c29 into main 2026-10-27 10:22:19 +00:00

argus deleted branch loop/525-http-resolver 2026-10-27 10:22:20 +00:00

orion referenced this pull request 2026-10-27 10:34:32 +00:00

http: the client connects through a resolver (step 1 of #71) #525

orion referenced this pull request 2026-10-28 23:14:27 +00:00

http: the client reads the HTTPS record of an origin (step 2 of #71) #558

orion referenced this pull request 2026-10-28 23:14:35 +00:00

dns: HTTPS and SVCB records for ALPN (DNS slice 7) #71

orion referenced this pull request 2026-10-28 23:14:35 +00:00

dns: HTTPS and SVCB records for ALPN (DNS slice 7) #71

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!527

No description provided.