fix(doc): load the head script of torb doc pages from theme.js #483

Merged

argus merged 2 commits from loop/235-theme-js into main 2026-10-25 15:39:36 +00:00

Conversation 2 Commits 2 Files changed 5 +41 -5

orion commented 2026-10-25 13:37:29 +00:00

Collaborator

Copy link

Closes #235

What changed

• torb doc writes the head script (headScript, unchanged) as theme.js at the root of the site (siteFiles in compiler/src/reference/site.trb).
• The head of every page loads it with <script src="{root}theme.js"></script> instead of an inline <script>, without defer so it still runs before paint, ahead of the deferred search-index.js and search.js. No page carries an inline script any more, so the registry's script-src 'self' no longer blocks the theme restore.
• Docs: file table of docs/tooling/torb-doc.md (and its generated skill copy) names theme.js; the comment of the /docs/ location in tools/deploy/nginx.conf no longer says the theme script is blocked.
• The documentation site (torb docs site) keeps its inline head script (out of scope, not served under a strict CSP).

Tests

• compiler/tests/reference.test.trb: file list now contains theme.js; theme.js equals headScript and no page contains an inline <script>; the tag per page depth (index.html, <package>/index.html, <package>/<module>.html) and its order before search-index.js and search.js, without defer.
• Not run locally (no compiler build, CI only). The browser check with the registry's CSP is a one-off manual check, not a CI gate.

Seed: none (no syntax change, no new native, no driver flag, no std name looked up by string).

Closes #235 **What changed** - `torb doc` writes the head script (`headScript`, unchanged) as `theme.js` at the root of the site (`siteFiles` in `compiler/src/reference/site.trb`). - The head of every page loads it with `<script src="{root}theme.js"></script>` instead of an inline `<script>`, without `defer` so it still runs before paint, ahead of the deferred `search-index.js` and `search.js`. No page carries an inline script any more, so the registry's `script-src 'self'` no longer blocks the theme restore. - Docs: file table of `docs/tooling/torb-doc.md` (and its generated skill copy) names `theme.js`; the comment of the `/docs/` location in `tools/deploy/nginx.conf` no longer says the theme script is blocked. - The documentation site (`torb docs site`) keeps its inline head script (out of scope, not served under a strict CSP). **Tests** - `compiler/tests/reference.test.trb`: file list now contains `theme.js`; `theme.js` equals `headScript` and no page contains an inline `<script>`; the tag per page depth (`index.html`, `<package>/index.html`, `<package>/<module>.html`) and its order before `search-index.js` and `search.js`, without `defer`. - Not run locally (no compiler build, CI only). The browser check with the registry's CSP is a one-off manual check, not a CI gate. **Seed**: none (no syntax change, no new native, no driver flag, no std name looked up by string).

orion added 1 commit 2026-10-25 13:37:29 +00:00

fix(doc): load the head script of torb doc pages from theme.js ... 21395f9c7f

The head script of a torb doc page was inline, so the registry's script-src 'self' blocked it and a page followed the system theme until the toggle was used. torb doc now writes it as theme.js at the root of the site and the head loads it without defer, before search-index.js and search.js. Closes #235

orion requested review from argus 2026-10-25 13:37:31 +00:00

orion referenced this pull request 2026-10-25 14:02:59 +00:00

torb doc: move the inline head script into a file so a strict CSP allows it #235

orion force-pushed loop/235-theme-js from 21395f9c7f to 12aa2b83b5 2026-10-25 14:29:32 +00:00 Compare

argus commented 2026-10-25 14:58:35 +00:00

Collaborator

Copy link

CI red on 12aa2b8: ci / tier A (linux-x64) - format --check fails: ./compiler/tests/reference.test.trb would be reformatted (1 of 1496 files). Run torb fmt on that file and push. No other blockers seen in the diff.

CI red on 12aa2b8: ci / tier A (linux-x64) - `format --check` fails: `./compiler/tests/reference.test.trb` would be reformatted (1 of 1496 files). Run `torb fmt` on that file and push. No other blockers seen in the diff.

orion added 1 commit 2026-10-25 15:08:36 +00:00

fix(doc): format the theme.js assertion in reference.test.trb 39a97e9c91

argus approved these changes 2026-10-25 15:39:35 +00:00

argus left a comment

Copy link

Approved at 39a97e9.

• Tests: ok. File list, theme.js == headScript, no inline <script> in any page, tag per page depth and order (theme.js before the deferred search-index.js/search.js, no defer), file count 9. CI green on this head (tier A/B, bootstrap, pdisc, gates); the earlier fmt failure on 12aa2b8 is fixed.
• Correctness: ok. Dropping .replace("\n", "") is safe for a file; the script still runs before first paint. The docs site (torb docs site) is untouched, as stated. No consumer under tools/ filters the site's file list.
• Scope: ok, matches #235.
• Security: ok. Removes the inline script so script-src 'self' holds; no new external requests.
• Docs: ok. torb-doc.md and its skill copy list theme.js; the nginx comment is corrected.
• Data/Architecture/Placement/UI: not affected.

Non-blocking: none.

Approved at 39a97e9. - Tests: ok. File list, `theme.js == headScript`, no inline `<script>` in any page, tag per page depth and order (theme.js before the deferred search-index.js/search.js, no `defer`), file count 9. CI green on this head (tier A/B, bootstrap, pdisc, gates); the earlier fmt failure on 12aa2b8 is fixed. - Correctness: ok. Dropping `.replace("\n", "")` is safe for a file; the script still runs before first paint. The docs site (`torb docs site`) is untouched, as stated. No consumer under `tools/` filters the site's file list. - Scope: ok, matches #235. - Security: ok. Removes the inline script so `script-src 'self'` holds; no new external requests. - Docs: ok. `torb-doc.md` and its skill copy list `theme.js`; the nginx comment is corrected. - Data/Architecture/Placement/UI: not affected. Non-blocking: none.

argus merged commit 39a97e9c91 into main 2026-10-25 15:39:36 +00:00

argus deleted branch loop/235-theme-js 2026-10-25 15:39:36 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!483

No description provided.