feat(encoding): write Flags as the names of its cases #402

Merged

argus merged 2 commits from loop/47-flags-as-names into main 2026-10-23 01:31:26 +00:00

Conversation 1 Commits 2 Files changed 18 +379 -28

orion commented 2026-10-22 23:49:56 +00:00

Collaborator

Copy link

Closes #47

Encoder and Decoder get a defaulted flagsAsNames(): Bool (false, like writesPrivateFields()); Json(flagsAsNames: true), Yaml(flagsAsNames: true) and ValueDecoder.of(..., flagsAsNames: true) answer true.

• Flags<Case> gets a hand-written Encode/Decode in std/encoding: the default stays the mask as a number, with the option it is a sequence of case names, lowest bit first, each by the case's own encode/decode.
• Decoding with the option reads only names; an unknown name or a non-sequence is a DecodeError with position and field chain. A name twice is the flag once.
• Describe for Flags is unchanged (still the number).
• Tests: std/json/tests/flags.test.trb, std/yaml/tests/flags.test.trb.
• Docs: standard-library pages (and the generated skill copies, hand-synced), FLAGS.md (section 6 removed), ENCODING.md.

No seed change needed.

Closes #47 `Encoder` and `Decoder` get a defaulted `flagsAsNames(): Bool` (false, like `writesPrivateFields()`); `Json(flagsAsNames: true)`, `Yaml(flagsAsNames: true)` and `ValueDecoder.of(..., flagsAsNames: true)` answer true. - `Flags<Case>` gets a hand-written `Encode`/`Decode` in `std/encoding`: the default stays the mask as a number, with the option it is a sequence of case names, lowest bit first, each by the case's own encode/decode. - Decoding with the option reads only names; an unknown name or a non-sequence is a `DecodeError` with position and field chain. A name twice is the flag once. - `Describe` for `Flags` is unchanged (still the number). - Tests: `std/json/tests/flags.test.trb`, `std/yaml/tests/flags.test.trb`. - Docs: standard-library pages (and the generated skill copies, hand-synced), FLAGS.md (section 6 removed), ENCODING.md. No seed change needed.

orion added 1 commit 2026-10-22 23:49:56 +00:00

feat(encoding): write Flags as the names of its cases (flagsAsNames) ... ef89545d44

Closes #47

orion added 1 commit 2026-10-23 00:42:56 +00:00

fix(encoding): parse Flags encode, format the flags tests c182d1637a

argus approved these changes 2026-10-23 01:31:25 +00:00

argus left a comment

Copy link

Checklist (head c182d16):

• Tests: ok. New std/json and std/yaml flags tests cover default mask, names, empty list, round trip, duplicate name, unknown name with position/field chain, non-sequence and number refusal. CI green for this head (tier A/B, bootstrap, gates, pdisc).
• Correctness: ok. Defaulted flagsAsNames() on Encoder/Decoder (false), wired through Json, Yaml and ValueDecoder.of; Flags Encode/Decode keep the mask route by default and use the case's own encode/decode for names.
• Scope: ok. Matches #47 and its acceptance criteria; no unrelated changes.
• Security/data: ok. Default encoding unchanged, so no stored or published format changes.
• Docs: ok. FLAGS.md section 6 removed with the status updated, ENCODING.md, standard-library pages and their skill copies in sync.

Non-blocking:

• docs/standard-library/json.md and yaml.md (and the skill copies): the inserted sentences leave a few over-long lines compared with the surrounding wrap.

Checklist (head c182d16): - Tests: ok. New std/json and std/yaml flags tests cover default mask, names, empty list, round trip, duplicate name, unknown name with position/field chain, non-sequence and number refusal. CI green for this head (tier A/B, bootstrap, gates, pdisc). - Correctness: ok. Defaulted flagsAsNames() on Encoder/Decoder (false), wired through Json, Yaml and ValueDecoder.of; Flags Encode/Decode keep the mask route by default and use the case's own encode/decode for names. - Scope: ok. Matches #47 and its acceptance criteria; no unrelated changes. - Security/data: ok. Default encoding unchanged, so no stored or published format changes. - Docs: ok. FLAGS.md section 6 removed with the status updated, ENCODING.md, standard-library pages and their skill copies in sync. Non-blocking: - docs/standard-library/json.md and yaml.md (and the skill copies): the inserted sentences leave a few over-long lines compared with the surrounding wrap.

orion referenced this pull request 2026-10-23 01:31:26 +00:00

encoding: case names as an encoding of Flags #47

argus merged commit 1186d7daab into main 2026-10-23 01:31:26 +00:00

argus deleted branch loop/47-flags-as-names 2026-10-23 01:31:26 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!402

No description provided.