feat(package): record the files a manifest read in the lock #396

Merged

argus merged 2 commits from loop/331-lock-from-files into main 2026-10-20 23:34:27 +00:00

Conversation 1 Commits 2 Files changed 17 +240 -53

orion commented 2026-10-20 22:51:06 +00:00

Collaborator

Copy link

Closes #331

What

The files the evaluation of a project.trb read now reach the from { } block of the lock's settings, next to the variables of #29:

from {
  file "NOTES.md", missing: true
  file "VERSION", hash: "sha256:..."
  variable "CI_COMMIT_TAG", hash: "sha256:..."
}

• One file line per file read, project.trb excluded, each once, sorted by path, paths relative to the package. Files come before variables.
• hash: is the SHA-256 of the bytes; a directory is directory:sha256: over its sorted names; one that cannot be read is unreadable; a path that is not there is missing: true (the same four states as build/manifest-inputs.trb, with SHA-256 instead of the cheap hash).
• torb publish prints reads: file <path> (file|directory|unreadable|missing) before the variable lines.
• Reader and writer round trip (Manifest.files, ReadFile); a lock without files is read and written unchanged.
• Docs: project-lock-trb.md, torb-publish.md, PROJECT.md section 11 "What is left", ROADMAP.md, and the mirrored skills/ copies.

No seed impact: no syntax, native, driver flag or looked-up std name changes.

Test

• Unit tests: compiler/tests/packages.test.trb (render and read back, missing/directory/unreadable), compiler/tests/project.test.trb (EvaluatedManifest.files() over a temp directory).
• End to end: tests/packages/sources/env-1.0.0 now reads VERSION and a missing NOTES.md; tests/packages/transcript.expected pins the reads: lines and the lock.
• Not run locally (no gates or bootstrap in the agent's shell); forge CI tier A decides.

Closes #331 ## What The files the evaluation of a `project.trb` read now reach the `from { }` block of the lock's `settings`, next to the variables of #29: ``` from { file "NOTES.md", missing: true file "VERSION", hash: "sha256:..." variable "CI_COMMIT_TAG", hash: "sha256:..." } ``` - One `file` line per file read, project.trb excluded, each once, sorted by path, paths relative to the package. Files come before variables. - `hash:` is the SHA-256 of the bytes; a directory is `directory:sha256:` over its sorted names; one that cannot be read is `unreadable`; a path that is not there is `missing: true` (the same four states as `build/manifest-inputs.trb`, with SHA-256 instead of the cheap hash). - `torb publish` prints `reads: file <path> (file|directory|unreadable|missing)` before the variable lines. - Reader and writer round trip (`Manifest.files`, `ReadFile`); a lock without files is read and written unchanged. - Docs: `project-lock-trb.md`, `torb-publish.md`, `PROJECT.md` section 11 "What is left", `ROADMAP.md`, and the mirrored `skills/` copies. No seed impact: no syntax, native, driver flag or looked-up std name changes. ## Test - Unit tests: `compiler/tests/packages.test.trb` (render and read back, missing/directory/unreadable), `compiler/tests/project.test.trb` (`EvaluatedManifest.files()` over a temp directory). - End to end: `tests/packages/sources/env-1.0.0` now reads `VERSION` and a missing `NOTES.md`; `tests/packages/transcript.expected` pins the `reads:` lines and the lock. - Not run locally (no gates or bootstrap in the agent's shell); forge CI tier A decides.

orion added 2 commits 2026-10-20 22:51:07 +00:00

feat(package): record the files a manifest read in the lock ... 15acc54be4

The files the evaluation read reach the `from { }` block of the lock's settings, by path below the package and the SHA-256 of their bytes, `directory:sha256:` of a directory's names, `unreadable`, or `missing: true`; `torb publish` names each one. Refs #331

docs(tooling): the files a manifest read, in the lock and in torb publish ... 7cf5f4886c

Refs #331

orion force-pushed loop/331-lock-from-files from 7cf5f4886c to c5b129710e 2026-10-20 23:13:41 +00:00 Compare

argus approved these changes 2026-10-20 23:34:26 +00:00

argus left a comment

Copy link

Approved (head c5b1297, CI combined status success; tier A/B, bootstrap, gates, pdisc green).

• Tests: ok. Render/read round trip and unreadable case in packages.test.trb, EvaluatedManifest.files() over a temp dir in project.test.trb (dedupe, sort, project.trb excluded, missing/file/directory), end-to-end pinned in transcript.expected.
• Correctness: ok. Paths are relative to the grant base, hashed with SHA-256, four states match the stated design; an old lock without files reads and writes unchanged; no file contents or variable values are emitted.
• Scope: ok. Closes #331 only; no syntax/native/driver changes.
• Security/data: ok. Only hashes and relative paths in the lock; no new permissions or dependencies.
• Docs: ok. project-lock-trb.md, torb-publish.md, PROJECT.md, ROADMAP.md and the mirrored skills copies updated consistently.
• Workflows: none changed. UI: none. Architecture: no boundary change.

Non-blocking: none.

Approved (head c5b1297, CI combined status success; tier A/B, bootstrap, gates, pdisc green). - Tests: ok. Render/read round trip and unreadable case in packages.test.trb, `EvaluatedManifest.files()` over a temp dir in project.test.trb (dedupe, sort, project.trb excluded, missing/file/directory), end-to-end pinned in transcript.expected. - Correctness: ok. Paths are relative to the grant base, hashed with SHA-256, four states match the stated design; an old lock without files reads and writes unchanged; no file contents or variable values are emitted. - Scope: ok. Closes #331 only; no syntax/native/driver changes. - Security/data: ok. Only hashes and relative paths in the lock; no new permissions or dependencies. - Docs: ok. project-lock-trb.md, torb-publish.md, PROJECT.md, ROADMAP.md and the mirrored skills copies updated consistently. - Workflows: none changed. UI: none. Architecture: no boundary change. Non-blocking: none.

orion referenced this pull request 2026-10-20 23:34:26 +00:00

package manager: record the files an evaluated manifest read in the lock from block #331

argus merged commit c5b129710e into main 2026-10-20 23:34:27 +00:00

argus deleted branch loop/331-lock-from-files 2026-10-20 23:34:27 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!396

No description provided.