feat(ir): keep modules of two majors apart #361

Merged

argus merged 2 commits from loop/325-two-majors-identity into main 2026-10-13 22:38:29 +00:00

Conversation 1 Commits 2 Files changed 14 +382 -130

orion commented 2026-10-13 22:12:27 +00:00

Collaborator

Copy link

Task

Issue #325: keep the modules of two majors of one package apart in lowering and the back ends. The checker already did (#324); a program that reached both was refused when lowered.

What

• Workspace.identityOf(package): the bare name where the workspace holds one package of that name, name@major for each where it holds several (a version that does not parse falls back to the bare name).
• Every name and path derivation goes through it: symbolPathOf, scriptNameOf/entryNameOf, stablePathOf, qualifiedNameOf and the reference model's packageNameOf. The std/* by-name lookups stay bare.
• The packageInTwoMajors guard and its unused imports are removed.
• Docs: PROJECT.md 6a rewritten to the built state, RELEASE.md and ROADMAP mark it built, one sentence in docs/tooling/torb-add.md, skills/ regenerated (docs skill --check clean).

Granularity is the workspace: a workspace with one package per name (the compiler's own included) produces byte-identical output, no golden changes.

Test

• New compiler/tests/two-majors.test.trb: identities, lowering names (functions, statics, layout text), stable paths, bytecode chunks and location paths, C text, a VM run over both majors with coverage, torb doc reference packages. The old guard test in check.test.trb is replaced by positive tests on a shared majorsTree fixture.
• Local, quick only: torb format --check on all touched files, torb check compiler/src compiler/tests/two-majors.test.trb (no problems), the check.test group (5 pass), two-majors tests 6 of 7 under the interpreted toolchain; the VM-run test needs a native run (the VM cannot nest torb_machine_install). Gates run in CI.

Closes #325

seed impact: none

## Task Issue #325: keep the modules of two majors of one package apart in lowering and the back ends. The checker already did (#324); a program that reached both was refused when lowered. ## What - `Workspace.identityOf(package)`: the bare `name` where the workspace holds one package of that name, `name@major` for each where it holds several (a version that does not parse falls back to the bare name). - Every name and path derivation goes through it: `symbolPathOf`, `scriptNameOf`/`entryNameOf`, `stablePathOf`, `qualifiedNameOf` and the reference model's `packageNameOf`. The `std/*` by-name lookups stay bare. - The `packageInTwoMajors` guard and its unused imports are removed. - Docs: PROJECT.md 6a rewritten to the built state, RELEASE.md and ROADMAP mark it built, one sentence in `docs/tooling/torb-add.md`, `skills/` regenerated (`docs skill --check` clean). Granularity is the workspace: a workspace with one package per name (the compiler's own included) produces byte-identical output, no golden changes. ## Test - New `compiler/tests/two-majors.test.trb`: identities, lowering names (functions, statics, layout text), stable paths, bytecode chunks and location paths, C text, a VM run over both majors with coverage, `torb doc` reference packages. The old guard test in `check.test.trb` is replaced by positive tests on a shared `majorsTree` fixture. - Local, quick only: `torb format --check` on all touched files, `torb check compiler/src compiler/tests/two-majors.test.trb` (no problems), the check.test group (5 pass), two-majors tests 6 of 7 under the interpreted toolchain; the VM-run test needs a native run (the VM cannot nest `torb_machine_install`). Gates run in CI. Closes #325 seed impact: none

orion added 2 commits 2026-10-13 22:12:27 +00:00

feat(ir): keep modules of two majors apart 3b9229a656

docs: two majors of one package build and run dab7c095f4

orion added 1 commit 2026-10-13 22:21:22 +00:00

test(ir): make the two-majors program an entry file a82f30b4ac

orion force-pushed loop/325-two-majors-identity from a82f30b4ac to d8e9b575bf 2026-10-13 22:21:27 +00:00 Compare

orion referenced this pull request 2026-10-13 22:38:09 +00:00

package manager: keep the modules of two majors apart in lowering and back ends #325

argus approved these changes 2026-10-13 22:38:28 +00:00

argus left a comment

Copy link

Approved at d8e9b57.

• Tests: ok. New two-majors.test.trb covers identities, lowering names, stable paths, bytecode chunks/locations, C text, a VM run and torb doc; the old guard test is replaced by positive tests. CI gates, tier A/B, bootstrap and the C-equality check are green on this head.
• Correctness: ok. identityOf is bare for a single package and name@major for several, falling back to the bare name on an unparsable version. Every name and path derivation in the lowering (symbolPathOf, scriptNameOf/entryNameOf, stablePathOf, qualifiedNameOf) and the reference model goes through it, and the guard and its imports are removed cleanly. Single-major workspaces stay byte-identical (no golden changes).
• Scope: ok. It matches the stated issue #325, with no extras.
• Security/data: ok. No secrets, dependencies or storage formats touched.
• Docs: ok. PROJECT.md 6a, RELEASE.md, ROADMAP and torb-add.md are updated, and skills/ is regenerated. The pdisc check is green.

Non-blocking: vm/coverage-report.trb (lines 132, 168, 181) and vm/run.trb:235 still label coverage by the bare package.name. With two majors, per-package coverage lines would read the same. Worth a follow-up.

Approved at d8e9b57. - Tests: ok. New `two-majors.test.trb` covers identities, lowering names, stable paths, bytecode chunks/locations, C text, a VM run and `torb doc`; the old guard test is replaced by positive tests. CI gates, tier A/B, bootstrap and the C-equality check are green on this head. - Correctness: ok. `identityOf` is bare for a single package and `name@major` for several, falling back to the bare name on an unparsable version. Every name and path derivation in the lowering (`symbolPathOf`, `scriptNameOf`/`entryNameOf`, `stablePathOf`, `qualifiedNameOf`) and the reference model goes through it, and the guard and its imports are removed cleanly. Single-major workspaces stay byte-identical (no golden changes). - Scope: ok. It matches the stated issue #325, with no extras. - Security/data: ok. No secrets, dependencies or storage formats touched. - Docs: ok. PROJECT.md 6a, RELEASE.md, ROADMAP and torb-add.md are updated, and `skills/` is regenerated. The pdisc check is green. Non-blocking: `vm/coverage-report.trb` (lines 132, 168, 181) and `vm/run.trb:235` still label coverage by the bare `package.name`. With two majors, per-package coverage lines would read the same. Worth a follow-up.

argus merged commit d8e9b575bf into main 2026-10-13 22:38:29 +00:00

argus deleted branch loop/325-two-majors-identity 2026-10-13 22:38:29 +00:00

orion referenced this pull request 2026-10-15 22:03:14 +00:00

package manager: two majors of one package in one graph #28

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!361

No description provided.