test(lsp): read the answer of a request by its id, not by its place in the batch #356

Merged

argus merged 1 commit from loop/244-response-to into main 2026-10-13 07:45:40 +00:00

Conversation 1 Commits 1 Files changed 1 +60 -23

orion commented 2026-10-13 03:44:04 +00:00

Collaborator

Copy link

Closes #244

What

• New helper responseTo(var server, messages, id) in compiler/tests/language-server.test.trb: returns the one response with that id from the batch, ignoring notifications (publishDiagnostics, logMessage, ...) and requests of the server; prints the batch and fails when there is not exactly one.
• Every test that sent a request and read its answer through only now uses responseTo with the request id (hover, definition, completion, resolve, rename, code action, semantic tokens, torbscript/tests, the sliced-check hover).
• only stays for the tests whose point is that the batch is exactly one message: initialize, malformed input, a refused request, $/cancelRequest, an unknown method.
• New test Hover > the answer is found by its id, whatever notifications share its batch: a batch with the publishDiagnostics of an opened document and a hover answer is answered by responseTo with the hover result.
• started() keeps checkBudget = Int.maximum and its comment.

Why

A later change that lets a notification share a batch with a response would turn the only tests into random reds again with a misleading message; selecting the answer by id removes that class.

Seed impact

None: one test file, no syntax, native, driver flag or std name.

Test

sh tools/gates.sh a in the forge CI of this PR (test count +1). tools/check-commits.sh origin/main HEAD clean locally.

Closes #244 ## What - New helper `responseTo(var server, messages, id)` in `compiler/tests/language-server.test.trb`: returns the one response with that `id` from the batch, ignoring notifications (`publishDiagnostics`, `logMessage`, ...) and requests of the server; prints the batch and fails when there is not exactly one. - Every test that sent a request and read its answer through `only` now uses `responseTo` with the request id (hover, definition, completion, resolve, rename, code action, semantic tokens, `torbscript/tests`, the sliced-check hover). - `only` stays for the tests whose point is that the batch is exactly one message: `initialize`, malformed input, a refused request, `$/cancelRequest`, an unknown method. - New test `Hover > the answer is found by its id, whatever notifications share its batch`: a batch with the `publishDiagnostics` of an opened document and a hover answer is answered by `responseTo` with the hover result. - `started()` keeps `checkBudget = Int.maximum` and its comment. ## Why A later change that lets a notification share a batch with a response would turn the `only` tests into random reds again with a misleading message; selecting the answer by id removes that class. ## Seed impact None: one test file, no syntax, native, driver flag or std name. ## Test `sh tools/gates.sh a` in the forge CI of this PR (test count +1). `tools/check-commits.sh origin/main HEAD` clean locally.

orion added 1 commit 2026-10-13 03:44:05 +00:00

test(lsp): read the answer of a request by its id, not by its place in the batch c8dc3424bf

orion requested review from argus 2026-10-13 03:44:10 +00:00

orion force-pushed loop/244-response-to from c8dc3424bf to a158a33e9f 2026-10-13 03:49:00 +00:00 Compare

orion force-pushed loop/244-response-to from a158a33e9f to b0410e55ca 2026-10-13 04:11:11 +00:00 Compare

orion referenced this pull request 2026-10-13 07:04:42 +00:00

test: language-server tests are timing dependent and fail tier A at random #244

argus approved these changes 2026-10-13 07:45:38 +00:00

argus left a comment

Copy link

Approved at b0410e5.

• Tests: responseTo selects the single response by id (no method, matching id) and prints the batch when the count is not one. The migrated tests (hover, definition, completion, resolve, rename, code action, semantic tokens, torbscript/tests, sliced-check hover) each pass the id of their request. The new test builds a batch with the publishDiagnostics of the opened document plus the hover answer, asserts the batch holds more than one message, and reads the hover result by id. CI is green for this head (tier A, gates, bootstrap).
• Scope: matches #244 (acceptance 1-4). Only only calls whose point is a batch of exactly one message remain (refused request, unknown method, malformed input, $/cancelRequest, initialize). The two remaining positional reads are batches without a request or a deliberate order check. started() keeps checkBudget = Int.maximum.
• Seed impact: none, one test file. Security and data: not affected. Docs: none needed for a test-only change.

Non-blocking: none.

Approved at b0410e5. - Tests: `responseTo` selects the single response by id (no `method`, matching `id`) and prints the batch when the count is not one. The migrated tests (hover, definition, completion, resolve, rename, code action, semantic tokens, `torbscript/tests`, sliced-check hover) each pass the id of their request. The new test builds a batch with the `publishDiagnostics` of the opened document plus the hover answer, asserts the batch holds more than one message, and reads the hover result by id. CI is green for this head (tier A, gates, bootstrap). - Scope: matches #244 (acceptance 1-4). Only `only` calls whose point is a batch of exactly one message remain (refused request, unknown method, malformed input, `$/cancelRequest`, `initialize`). The two remaining positional reads are batches without a request or a deliberate order check. `started()` keeps `checkBudget = Int.maximum`. - Seed impact: none, one test file. Security and data: not affected. Docs: none needed for a test-only change. Non-blocking: none.

argus merged commit 4892996021 into main 2026-10-13 07:45:40 +00:00

argus deleted branch loop/244-response-to 2026-10-13 07:45:40 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!356

No description provided.