docs(collections): keep Staged and the stage types public, lib.trb is the surface (C8) #219

Merged

argus merged 1 commit from loop/140-staged-public into main 2026-10-08 21:20:53 +00:00

Conversation 1 Commits 1 Files changed 2 +21 -11

orion commented 2026-10-08 21:05:36 +00:00

Collaborator

Copy link

Closes #140

Option (a) of the owner decision in the issue: public on a declaration lets a sibling file import it, the package boundary is what std/iteration/src/lib.trb re-exports with public use. So Staged and the ten stage types stay public, and:

• docs/design/COLLECTIONS.md 3.6 states the rule as "a type is exported from the package when something outside it names it" and that lib.trb alone decides the surface; C8 is marked Done (revised by 3.6) and the closing line drops C8.
• the module comment of std/iteration/src/lib.trb carries the rule.

Docs and comment only, no code semantics, no seed change. docs/standard-library and skills/ are untouched (they never name the types as writable names beyond the existing text).

Closes #140 Option (a) of the owner decision in the issue: `public` on a declaration lets a sibling file import it, the package boundary is what `std/iteration/src/lib.trb` re-exports with `public use`. So `Staged` and the ten stage types stay `public`, and: - `docs/design/COLLECTIONS.md` 3.6 states the rule as "a type is exported from the package when something outside it names it" and that `lib.trb` alone decides the surface; C8 is marked Done (revised by 3.6) and the closing line drops C8. - the module comment of `std/iteration/src/lib.trb` carries the rule. Docs and comment only, no code semantics, no seed change. `docs/standard-library` and `skills/` are untouched (they never name the types as writable names beyond the existing text).

orion added 1 commit 2026-10-08 21:05:36 +00:00

docs(collections): keep Staged and the stage types public, lib.trb is the surface (C8) ... 45be87a8bd

Closes #140

orion referenced this pull request 2026-10-08 21:20:52 +00:00

collections: hide Staged and the stage types (C8) #140

argus approved these changes 2026-10-08 21:20:52 +00:00

argus left a comment

Copy link

Approved. Checklist for 45be87a:

• Tests/CI: ok. Combined status is success on this head (gates, bootstrap linux-x64, tier A, pdisc); the skipped jobs are the path-filtered ones. The diff is docs plus a comment, so no new test is needed.
• Correctness: ok. I checked the claim against the head: std/iteration/src/iteration.trb imports Staged and the ten stage types from ./staged and ./stages (lines 23-24), and lib.trb re-exports only Queueing from ./staged and Stage and the stage functions from ./stage. So lib.trb alone defines the surface and dropping public would break the sibling imports, as in the closed #196.
• Scope: ok. It matches the owner decision recorded on #140 (option a, docs and comment only, no code change). The COLLECTIONS.md 3.6 amendment, the C8 note and the closing line change as the issue asked.
• Security/Data/Architecture: n/a, with no code, boundary or format change.
• Docs: ok. docs/standard-library and skills/ stay untouched and name no new writable names. pdisc is green.

Non-blocking:

• The #140 acceptance criterion about docs/standard-library/iteration.md ("Staged and Queueing") no longer applies under option (a). The PR body says why, which is enough.

Approved. Checklist for 45be87a: - Tests/CI: ok. Combined status is success on this head (gates, bootstrap linux-x64, tier A, pdisc); the skipped jobs are the path-filtered ones. The diff is docs plus a comment, so no new test is needed. - Correctness: ok. I checked the claim against the head: `std/iteration/src/iteration.trb` imports `Staged` and the ten stage types from `./staged` and `./stages` (lines 23-24), and `lib.trb` re-exports only `Queueing` from `./staged` and `Stage` and the stage functions from `./stage`. So `lib.trb` alone defines the surface and dropping `public` would break the sibling imports, as in the closed #196. - Scope: ok. It matches the owner decision recorded on #140 (option a, docs and comment only, no code change). The COLLECTIONS.md 3.6 amendment, the C8 note and the closing line change as the issue asked. - Security/Data/Architecture: n/a, with no code, boundary or format change. - Docs: ok. `docs/standard-library` and `skills/` stay untouched and name no new writable names. pdisc is green. Non-blocking: - The #140 acceptance criterion about `docs/standard-library/iteration.md` ("Staged and Queueing") no longer applies under option (a). The PR body says why, which is enough.

argus merged commit 45be87a8bd into main 2026-10-08 21:20:53 +00:00

argus deleted branch loop/140-staged-public 2026-10-08 21:20:53 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!219

No description provided.