refactor(std/iteration): hide Staged and the stage types (C8) #196

Closed

orion wants to merge 1 commit from loop/140-hide-staged into main

pull from: loop/140-hide-staged

merge into: torbscript:main

torbscript:main

torbscript:loop/705-default-shadow

torbscript:loop/691-tensor-core

torbscript:loop/705-fix-candidate

torbscript:orion/456-tierb-probe

torbscript:loop/164-measure2

torbscript:loop/207-measure

torbscript:loop/164-prototype

torbscript:probe/207-count

torbscript:loop/205-measure

Conversation 1 Commits 1 Files changed 6 +30 -22

orion commented 2026-10-08 13:39:56 +00:00

Collaborator

Copy link

Closes #140

Drops public from Staged and the ten per-stage iterator types of std/iteration (COLLECTIONS.md 3.6: a type is public when something outside the package names it, and not otherwise). Queueing, the traits and std/stream's Staged are unchanged.

• Rule written into the module comment of std/iteration/src/lib.trb.
• docs/standard-library/iteration.md and the generated skill reference no longer present Staged as a nameable type.
• COLLECTIONS.md: C8 marked Done, closing line updated.
• Nothing outside std/iteration names the types (grepped std, compiler, tests, examples).

No syntax change, no seed refresh, not breaking.

Closes #140 Drops `public` from `Staged` and the ten per-stage iterator types of `std/iteration` (COLLECTIONS.md 3.6: a type is public when something outside the package names it, and not otherwise). `Queueing`, the traits and `std/stream`'s `Staged` are unchanged. - Rule written into the module comment of `std/iteration/src/lib.trb`. - `docs/standard-library/iteration.md` and the generated skill reference no longer present `Staged` as a nameable type. - COLLECTIONS.md: C8 marked Done, closing line updated. - Nothing outside `std/iteration` names the types (grepped std, compiler, tests, examples). No syntax change, no seed refresh, not breaking.

orion added 1 commit 2026-10-08 13:39:56 +00:00

refactor(std/iteration): hide Staged and the stage types (C8) ... 35db17e3ef

A type is public when something outside the package names it. Staged and the ten per-stage iterators are reached only through Iterate.through, map, filter and friends. Queueing stays public. Docs, skills and COLLECTIONS.md C8 follow.

orion force-pushed loop/140-hide-staged from 35db17e3ef to 1c139a022e 2026-10-08 13:54:25 +00:00 Compare

orion referenced this pull request 2026-10-08 14:06:08 +00:00

collections: hide Staged and the stage types (C8) #140

orion commented 2026-10-08 14:06:08 +00:00

Author

Collaborator

Copy link

Closing: removing public breaks the sibling-file imports in std/iteration/src/iteration.trb (see the finding on #140). The branch stays for option (b)/(a) once the owner decides.

Closing: removing `public` breaks the sibling-file imports in `std/iteration/src/iteration.trb` (see the finding on #140). The branch stays for option (b)/(a) once the owner decides.

orion closed this pull request 2026-10-08 14:06:08 +00:00

Some checks failed

Hide checks

ci / commit messages (pull_request) Successful in 6s

Details

ci / what the change touches (pull_request) Successful in 5s

Details

pdisc / pdisc (pull_request) Successful in 9s

Details

ci / which runners exist (pull_request) Successful in 1s

Details

ci / bootstrap and conformance (windows-x64) (pull_request) Has been skipped

Details

ci / bootstrap and conformance (linux-arm64) (pull_request) Has been skipped

Details

ci / bootstrap and conformance (macos-arm64) (pull_request) Has been skipped

Details

ci / the VS Code extension (editors/vscode) (pull_request) Successful in 12s

Details

ci / bootstrap (linux-x64) (pull_request) Failing after 3m51s

Details

ci / tier A (linux-x64) (pull_request) Has been skipped

Details

ci / tier B (linux-x64) (pull_request) Has been skipped

Details

ci / tools/release-sync and tools/registry (linux-x64) (pull_request) Has been skipped

Details

ci / cross-compiled on linux-x64 (windows-x64) (pull_request) Has been skipped

Details

ci / cross-compiled on linux-x64 (linux-arm64) (pull_request) Has been skipped

Details

ci / cross-compiled on linux-x64 (macos-arm64) (pull_request) Has been skipped

Details

ci / every host emits the same C (pull_request) Has been skipped

Details

ci / the playground (torb as WebAssembly) (pull_request) Has been skipped

Details

ci / pack the seed (pull_request) Failing after 5s

Details

ci / archives (pull_request) Has been skipped

Details

ci / gates (pull_request) Failing after 0s

Required

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!196

No description provided.