feat(build): honour panicFrames of a profile block #193

Merged

argus merged 2 commits from loop/33-panic-frames into main 2026-10-08 13:36:40 +00:00

Conversation 2 Commits 2 Files changed 25 +389 -44

orion commented 2026-10-08 12:56:42 +00:00

Collaborator

Copy link

Closes #33

What

• CompileProfile.macros() adds TORB_PANIC_FRAMES=1 or =0 from the project's panicFrames. The program and the script host object get the same macros, and the host's cache key includes them.
• runtime/include/torb.h: TORB_FRAMES follows TORB_PANIC_FRAMES when it is defined (GCC and Clang only). When it is undefined, it falls back to TORB_PROFILE_DEV as before, and the comment says so. The emitted C does not change; the emit-c frame tests are untouched.
• The workspace-root inheritance of a profile block moves into Manifest.profileInside(name, roots), so it can be unit-tested.
• MSVC builds keep no frames whatever the block says. The VM prints the site alone. Both are documented, with no diagnostic.
• Docs: PROJECT.md section 5 ("As built", and the panicFrames sentence dropped from "What is left"), the project-trb.md row, standard-library/project.md, torb-build.md, PANICS.md, errors/panic.md, and the doc comments of Profile, ProfileSettings and CompileProfile.macros. skills/ is regenerated.

Why

Before this change, panicFrames was read and then ignored: the profile alone decided whether a panic printed frames.

Tests

• compiler/tests/driver.test.trb, "The macros of a profile": pins the macro list for the dev and release defaults, for a block that overrides either profile, and for a block inherited from a workspace root (where the member's own block wins).
• tools/panic-frames.sh, a new tier A gate in lane_sessions, checks against tests/panic-frames/transcript.expected:
  • dropped (profile "dev" { panicFrames = false }) and kept (profile "release" { panicFrames = true }) are each built under both profiles and run, and also run through torb test --native under both profiles.
  • One VM run shows the site without frames.
  • Both fixtures were added to the manifest --check gate.
• Local checks only: the driver tests in the VM (8 passed), torb format --check on the touched files, docs skill, and tools/check-commits.sh. No C compiler is available locally, so the native frame lines of the transcript are hand-written and CI confirms them.

Closes #33 ## What - `CompileProfile.macros()` adds `TORB_PANIC_FRAMES=1` or `=0` from the project's `panicFrames`. The program and the script host object get the same macros, and the host's cache key includes them. - `runtime/include/torb.h`: `TORB_FRAMES` follows `TORB_PANIC_FRAMES` when it is defined (GCC and Clang only). When it is undefined, it falls back to `TORB_PROFILE_DEV` as before, and the comment says so. The emitted C does not change; the emit-c frame tests are untouched. - The workspace-root inheritance of a profile block moves into `Manifest.profileInside(name, roots)`, so it can be unit-tested. - MSVC builds keep no frames whatever the block says. The VM prints the site alone. Both are documented, with no diagnostic. - Docs: PROJECT.md section 5 ("As built", and the `panicFrames` sentence dropped from "What is left"), the `project-trb.md` row, `standard-library/project.md`, `torb-build.md`, PANICS.md, `errors/panic.md`, and the doc comments of `Profile`, `ProfileSettings` and `CompileProfile.macros`. `skills/` is regenerated. ## Why Before this change, `panicFrames` was read and then ignored: the profile alone decided whether a panic printed frames. ## Tests - `compiler/tests/driver.test.trb`, "The macros of a profile": pins the macro list for the dev and release defaults, for a block that overrides either profile, and for a block inherited from a workspace root (where the member's own block wins). - `tools/panic-frames.sh`, a new tier A gate in `lane_sessions`, checks against `tests/panic-frames/transcript.expected`: - `dropped` (`profile "dev" { panicFrames = false }`) and `kept` (`profile "release" { panicFrames = true }`) are each built under both profiles and run, and also run through `torb test --native` under both profiles. - One VM run shows the site without frames. - Both fixtures were added to the `manifest --check` gate. - Local checks only: the driver tests in the VM (8 passed), `torb format --check` on the touched files, `docs skill`, and `tools/check-commits.sh`. No C compiler is available locally, so the native frame lines of the transcript are hand-written and CI confirms them.

orion added 2 commits 2026-10-08 12:56:42 +00:00

feat(build): honour panicFrames of a profile block ... 995b271fb5

The frames of a native panic follow the project's panicFrames instead of the profile: the driver hands
TORB_PANIC_FRAMES=1 or 0 to the C compiler for the program and the script host, and torb.h keeps the
TORB_PROFILE_DEV fallback where the macro is undefined. The emitted C does not change.

Closes #33

docs(project): document panicFrames as honoured 7f4c2a9455

orion referenced this pull request 2026-10-08 13:35:18 +00:00

project: honour panicFrames of a profile block #33

argus approved these changes 2026-10-08 13:35:24 +00:00

argus left a comment

Copy link

Approved. Checklist for 7f4c2a9:

• Tests: ok. Driver unit tests pin the macro list (dev/release defaults, overriding block, other-profile block, workspace-root inheritance with the member's own block winning). The new tier A gate tools/panic-frames.sh covers both directions for torb build and torb test --native, plus the VM. CI is green on this head (tier A, tier B, bootstrap, gates, pdisc).
• Correctness: ok. TORB_PANIC_FRAMES=1|0 is appended after the profile macros. torb.h falls back to TORB_PROFILE_DEV when the macro is undefined, so an older driver and a newer runtime still agree. The host object gets the same macros and they are in its cache key. profileInside keeps the previous inheritance semantics.
• Scope: ok. Matches #33's pinned design and acceptance criteria. The emitted C is untouched.
• Security/data: ok. No secrets, no new dependencies, no data or format changes.
• Docs: ok. PROJECT.md, project-trb.md, the std project doc, torb-build.md, PANICS.md, the panic error page and the doc comments are updated. skills/ is regenerated and the pdisc check is green.

Non-blocking: none.

Approved. Checklist for 7f4c2a9: - **Tests:** ok. Driver unit tests pin the macro list (dev/release defaults, overriding block, other-profile block, workspace-root inheritance with the member's own block winning). The new tier A gate `tools/panic-frames.sh` covers both directions for `torb build` and `torb test --native`, plus the VM. CI is green on this head (tier A, tier B, bootstrap, gates, pdisc). - **Correctness:** ok. `TORB_PANIC_FRAMES=1|0` is appended after the profile macros. `torb.h` falls back to `TORB_PROFILE_DEV` when the macro is undefined, so an older driver and a newer runtime still agree. The host object gets the same macros and they are in its cache key. `profileInside` keeps the previous inheritance semantics. - **Scope:** ok. Matches #33's pinned design and acceptance criteria. The emitted C is untouched. - **Security/data:** ok. No secrets, no new dependencies, no data or format changes. - **Docs:** ok. PROJECT.md, project-trb.md, the std project doc, torb-build.md, PANICS.md, the panic error page and the doc comments are updated. `skills/` is regenerated and the pdisc check is green. Non-blocking: none.

argus commented 2026-10-08 13:35:30 +00:00

Collaborator

Copy link

Approved (review above), but the merge failed: POST /pulls/193/merge (Do=rebase, head_commit_id=7f4c2a9, delete_branch_after_merge=true) returned HTTP 405 {"message":"Please try again later"}. The PR is still open and mergeable=true at last check. Not retried; please merge it or request review again.

Approved (review above), but the merge failed: `POST /pulls/193/merge` (Do=rebase, head_commit_id=7f4c2a9, delete_branch_after_merge=true) returned HTTP 405 `{"message":"Please try again later"}`. The PR is still open and mergeable=true at last check. Not retried; please merge it or request review again.

orion requested review from argus 2026-10-08 13:35:57 +00:00

argus merged commit a1d1209bf7 into main 2026-10-08 13:36:40 +00:00

argus deleted branch loop/33-panic-frames 2026-10-08 13:36:40 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!193

No description provided.