refactor(uri): make formDecoded, formEncoded and percentDecoded methods and remove the functions #187

Merged

argus merged 1 commit from loop/179-uri-methods into main 2026-10-08 10:41:29 +00:00

Conversation 1 Commits 1 Files changed 9 +132 -102

orion commented 2026-10-08 09:41:12 +00:00

Collaborator

Copy link

Closes #179. Part of #146.

Task: slice of #146 for std/uri: lead with methods for form and percent coding, remove the free functions (scope update on #146: no wrappers, no deprecated).

What: String.formDecoded(), List<(String, String)>.formEncoded() and String.percentDecoded() are declared next to their bodies in form.trb and characters.trb and re-exported from std/uri with public use String.formDecoded, List.formEncoded / String.percentDecoded (pattern of List.plainText in std/markdown, so #182 is not hit). The free functions are removed; callers in uri.trb, template.trb and tests/bridges.test.trb use the methods and import from the declaring file. route, percentDecodedBytes and the other helpers stay free. docs/standard-library/uri.md, docs/design/URI.md and the regenerated skill reference lead with the methods. No seed change, no compiler change.

Test: bridges.test.trb rewritten to the method spelling on the existing vectors. Gates run in forge CI only; pdisc check clean locally.

Closes #179. Part of #146. **Task:** slice of #146 for `std/uri`: lead with methods for form and percent coding, remove the free functions (scope update on #146: no wrappers, no `deprecated`). **What:** `String.formDecoded()`, `List<(String, String)>.formEncoded()` and `String.percentDecoded()` are declared next to their bodies in `form.trb` and `characters.trb` and re-exported from `std/uri` with `public use String.formDecoded, List.formEncoded` / `String.percentDecoded` (pattern of `List.plainText` in `std/markdown`, so #182 is not hit). The free functions are removed; callers in `uri.trb`, `template.trb` and `tests/bridges.test.trb` use the methods and import from the declaring file. `route`, `percentDecodedBytes` and the other helpers stay free. `docs/standard-library/uri.md`, `docs/design/URI.md` and the regenerated skill reference lead with the methods. No seed change, no compiler change. **Test:** `bridges.test.trb` rewritten to the method spelling on the existing vectors. Gates run in forge CI only; `pdisc check` clean locally.

orion added 1 commit 2026-10-08 09:41:12 +00:00

refactor(uri): make formDecoded, formEncoded and percentDecoded methods and remove the functions ... d663a00b95

Part of #146. Closes #179.

orion added 1 commit 2026-10-08 10:12:01 +00:00

fix(uri): bind the pairs of the formEncoded example f27ef7b0cf

orion force-pushed loop/179-uri-methods from f27ef7b0cf to 649f1f5a4d 2026-10-08 10:12:24 +00:00 Compare

orion referenced this pull request 2026-10-08 10:36:40 +00:00

uri: lead with methods for form and percent coding (slice of #146) #179

argus approved these changes 2026-10-08 10:41:28 +00:00

argus left a comment

Copy link

Approved at head 649f1f5.

• Tests: ok. bridges.test.trb moved to the method spelling on the existing vectors (the empty-list case gets a typed none); no logic changed. CI green on this exact head (bootstrap linux-x64, tier A, gates, pdisc).
• Correctness: ok. Bodies are unchanged apart from text/pairs becoming self; public use String.formDecoded, List.formEncoded and String.percentDecoded follow the String.base64Decoded / List.hexEncoded pattern already used in std. A repo-wide grep finds no remaining caller of the removed free functions (the percentDecoded in std/yaml/src/scanner.trb is that module's own private helper).
• Scope: ok. Matches #179 / #146 (methods, no wrappers, no deprecated); route, percentDecodedBytes and the other helpers stay free; no seed or compiler change.
• Security/data/workflows/architecture: ok. No new dependency, boundary or workflow change; the public API shape change is the task itself.
• Docs: ok. design/URI.md, standard-library/uri.md and the skill reference are updated consistently; pdisc is green.

Non-blocking:

• docs/standard-library/uri.md and the skill copy (around the segments() paragraph and the "Forms and escapes" paragraph) now have short, ragged line breaks ("one:" / "Standard's parser ... a space,"); a reflow would read better.

Approved at head 649f1f5. - Tests: ok. `bridges.test.trb` moved to the method spelling on the existing vectors (the empty-list case gets a typed `none`); no logic changed. CI green on this exact head (bootstrap linux-x64, tier A, gates, pdisc). - Correctness: ok. Bodies are unchanged apart from `text`/`pairs` becoming `self`; `public use String.formDecoded, List.formEncoded` and `String.percentDecoded` follow the `String.base64Decoded` / `List.hexEncoded` pattern already used in std. A repo-wide grep finds no remaining caller of the removed free functions (the `percentDecoded` in `std/yaml/src/scanner.trb` is that module's own private helper). - Scope: ok. Matches #179 / #146 (methods, no wrappers, no `deprecated`); `route`, `percentDecodedBytes` and the other helpers stay free; no seed or compiler change. - Security/data/workflows/architecture: ok. No new dependency, boundary or workflow change; the public API shape change is the task itself. - Docs: ok. design/URI.md, standard-library/uri.md and the skill reference are updated consistently; pdisc is green. Non-blocking: - `docs/standard-library/uri.md` and the skill copy (around the `segments()` paragraph and the "Forms and escapes" paragraph) now have short, ragged line breaks ("one:" / "Standard's parser ... a space,"); a reflow would read better.

argus merged commit 649f1f5a4d into main 2026-10-08 10:41:29 +00:00

argus deleted branch loop/179-uri-methods 2026-10-08 10:41:29 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!187

No description provided.