refactor(markdown): lead with methods, remove htmlOf, markdownOf and plainText #183

Merged

argus merged 1 commit from loop/178-markdown-methods into main 2026-10-08 09:36:11 +00:00

Conversation 2 Commits 1 Files changed 12 +71 -85

orion commented 2026-10-08 07:45:25 +00:00

Collaborator

Copy link

Closes #178

Part of #146. Per the owner decision on #146 (scope update on #178), the free functions of this slice are removed, with no wrappers and no deprecation.

What

• MarkdownDocument.markdown() and MarkdownDocument.html() now hold the writers' bodies; markdownOf and htmlOf are gone.
• List<MarkdownInline>.plainText() replaces the free plainText(inlines); exported as List.plainText from std/markdown.
• Callers migrated: std/markdown (html writer, Markdown.html, docs example in lib.trb), its tests, and the compiler (reference/render, documentation/markdown, site-html, site-layout).
• Unchanged: parsedDocument and the internal scanner helpers; the unrelated private plainText in project/manifest.trb.
• docs/standard-library/markdown.md leads with the methods; the matching file under skills/ is updated to the same text.

Seed

No syntax change, no new native, no driver flag. The compiler now uses extend List<MarkdownInline> and use List.plainText from std/markdown; if the seed cannot build it, CI will show it here.

Test

No local build (CI only). Forge CI gates run on this PR; result recorded below in a comment.

Closes #178 Part of #146. Per the owner decision on #146 (scope update on #178), the free functions of this slice are removed, with no wrappers and no deprecation. ## What - `MarkdownDocument.markdown()` and `MarkdownDocument.html()` now hold the writers' bodies; `markdownOf` and `htmlOf` are gone. - `List<MarkdownInline>.plainText()` replaces the free `plainText(inlines)`; exported as `List.plainText` from `std/markdown`. - Callers migrated: `std/markdown` (html writer, `Markdown.html`, docs example in `lib.trb`), its tests, and the compiler (`reference/render`, `documentation/markdown`, `site-html`, `site-layout`). - Unchanged: `parsedDocument` and the internal scanner helpers; the unrelated private `plainText` in `project/manifest.trb`. - `docs/standard-library/markdown.md` leads with the methods; the matching file under `skills/` is updated to the same text. ## Seed No syntax change, no new native, no driver flag. The compiler now uses `extend List<MarkdownInline>` and `use List.plainText` from `std/markdown`; if the seed cannot build it, CI will show it here. ## Test No local build (CI only). Forge CI gates run on this PR; result recorded below in a comment.

orion added 1 commit 2026-10-08 07:45:25 +00:00

refactor(markdown): lead with methods, remove htmlOf, markdownOf and plainText ... 6066a76820

Part of #146.

orion added 1 commit 2026-10-08 08:18:50 +00:00

fix(markdown): declare List.plainText in the module it is imported from e666293db1

orion force-pushed loop/178-markdown-methods from e666293db1 to f164a187c8 2026-10-08 08:19:01 +00:00 Compare

orion force-pushed loop/178-markdown-methods from f164a187c8 to e4f80a3d6a 2026-10-08 08:43:48 +00:00 Compare

orion force-pushed loop/178-markdown-methods from e4f80a3d6a to 52e54203ec 2026-10-08 08:50:31 +00:00 Compare

orion force-pushed loop/178-markdown-methods from 52e54203ec to 02d1323a1f 2026-10-08 09:08:36 +00:00 Compare

orion commented 2026-10-08 09:35:35 +00:00

Author

Collaborator

Copy link

CI on 02d1323a: all checks green (bootstrap, tier A including std/example tests, doc check and the repository type check; tier B skipped as no IR/backend/runtime change).

CI on 02d1323a: all checks green (bootstrap, tier A including std/example tests, doc check and the repository type check; tier B skipped as no IR/backend/runtime change).

orion referenced this pull request 2026-10-08 09:35:35 +00:00

markdown: lead with methods on MarkdownDocument (slice of #146) #178

argus approved these changes 2026-10-08 09:36:10 +00:00

argus left a comment

Copy link

Checklist (head 02d1323a):

• Tests: ok. The existing std/markdown tests are migrated to inlines.plainText(); CI is green on this head (bootstrap, tier A with std/example tests, doc check, repo type check, pdisc, gates).
• Correctness: ok. The writer bodies moved into MarkdownDocument.html() / .markdown() unchanged; Markdown.html calls parse(text).html(); plainText keeps its body as extend List<MarkdownInline>, re-exported with public use List.plainText. A grep of the PR head finds no remaining callers of htmlOf, markdownOf or the free plainText for markdown (the markdownOf in playground/*.mjs and the private plainText in project/manifest.trb are unrelated).
• Scope: ok. It matches #178 as updated by the owner decision on #146 (free functions removed, no wrappers, all callers migrated).
• Security/data: ok. No secrets, dependencies or storage formats touched.
• Docs: ok. docs/standard-library/markdown.md leads with the methods, and the skills/ copy is identical.
• Architecture: no boundary change beyond the removed public exports, which the owner decided.

Non-blocking:

• docs/standard-library/markdown.md (and the skills copy), "html() and markdown()": the document.markdown() sentence runs past the wrapped line width; rewrap it on the next docs touch.

Checklist (head 02d1323a): - Tests: ok. The existing std/markdown tests are migrated to `inlines.plainText()`; CI is green on this head (bootstrap, tier A with std/example tests, doc check, repo type check, pdisc, gates). - Correctness: ok. The writer bodies moved into `MarkdownDocument.html()` / `.markdown()` unchanged; `Markdown.html` calls `parse(text).html()`; `plainText` keeps its body as `extend List<MarkdownInline>`, re-exported with `public use List.plainText`. A grep of the PR head finds no remaining callers of `htmlOf`, `markdownOf` or the free `plainText` for markdown (the `markdownOf` in `playground/*.mjs` and the private `plainText` in `project/manifest.trb` are unrelated). - Scope: ok. It matches #178 as updated by the owner decision on #146 (free functions removed, no wrappers, all callers migrated). - Security/data: ok. No secrets, dependencies or storage formats touched. - Docs: ok. `docs/standard-library/markdown.md` leads with the methods, and the `skills/` copy is identical. - Architecture: no boundary change beyond the removed public exports, which the owner decided. Non-blocking: - docs/standard-library/markdown.md (and the skills copy), "`html()` and `markdown()`": the `document.markdown()` sentence runs past the wrapped line width; rewrap it on the next docs touch.

argus merged commit 4a675e708c into main 2026-10-08 09:36:11 +00:00

argus deleted branch loop/178-markdown-methods 2026-10-08 09:36:12 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!183

No description provided.