feat(lint): run every rule on every program and drop --skip #180

Merged

argus merged 1 commit from loop/157-lint-no-configuration into main 2026-10-08 07:41:49 +00:00

Conversation 1 Commits 1 Files changed 9 +70 -51

orion commented 2026-10-08 07:20:25 +00:00

Collaborator

Copy link

Closes #157

What

torb lint has no configuration: every rule runs on every program, and no project, file or command line switches one off. The rule set belongs to the toolchain version, the same way torb format has no option.

• compiler/src/lint/command.trb: --skip is gone. It is now an unknown flag, so torb lint --skip <id> prints the usage and exits with 2. The usage says the rules "run on every program, and none can be switched off". --rule <id> stays as a focus for one run (torb lint --fix --rule deprecated); its help text says it narrows the output and does not change what is valid.
• compiler/tests/lint.test.trb: the command-line test drops the --skip case and now asserts --skip is refused. A new test checks the help text: --rule narrows, and nothing mentions --skip.
• There was no manifest setting, suppression comment or config file for lint or format to remove. The redundant-closure rule's doc comment already says "no setting and no suppression comment".

Docs

• docs/tooling/torb-lint.md: synopsis and flag list updated. A new section "No configuration" records the decision (owner, 2026-10-07) and replaces the "Where a project chooses its rules" entry under "What is not decided".
• docs/tooling/the-torb-command.md: the lint flag table loses --skip, --rule is reworded, and one sentence says every rule always runs.
• docs/design/PROJECT.md section 13: new non-goal "Not a place for lint or format settings".
• CONCEPT.md: new design principle 6, "The format is part of the language" (added, not edited: there was no such principle yet).
• skills/torbscript/references/tooling/{torb-lint,the-torb-command}.md: the generated copies, edited to match the generator's output (torb docs skill docs skills --check runs in CI).

Seed

None. This removes a lint driver flag that the build does not use, with no syntax change and no native.

Test

This worker had no torb binary or C compiler, so no local checks ran (not even torb format --check). tools/check-commits.sh origin/main is clean. Tier A gates, including format, docs-skill --check and the compiler suite with the lint.test.trb group "The command line", run in forge CI on this PR.

Closes #157 ## What `torb lint` has no configuration: every rule runs on every program, and no project, file or command line switches one off. The rule set belongs to the toolchain version, the same way `torb format` has no option. - `compiler/src/lint/command.trb`: `--skip` is gone. It is now an unknown flag, so `torb lint --skip <id>` prints the usage and exits with 2. The usage says the rules "run on every program, and none can be switched off". `--rule <id>` stays as a focus for one run (`torb lint --fix --rule deprecated`); its help text says it narrows the output and does not change what is valid. - `compiler/tests/lint.test.trb`: the command-line test drops the `--skip` case and now asserts `--skip` is refused. A new test checks the help text: `--rule` narrows, and nothing mentions `--skip`. - There was no manifest setting, suppression comment or config file for lint or format to remove. The redundant-closure rule's doc comment already says "no setting and no suppression comment". ## Docs - `docs/tooling/torb-lint.md`: synopsis and flag list updated. A new section "No configuration" records the decision (owner, 2026-10-07) and replaces the "Where a project chooses its rules" entry under "What is not decided". - `docs/tooling/the-torb-command.md`: the `lint` flag table loses `--skip`, `--rule` is reworded, and one sentence says every rule always runs. - `docs/design/PROJECT.md` section 13: new non-goal "Not a place for lint or format settings". - `CONCEPT.md`: new design principle 6, "The format is part of the language" (added, not edited: there was no such principle yet). - `skills/torbscript/references/tooling/{torb-lint,the-torb-command}.md`: the generated copies, edited to match the generator's output (`torb docs skill docs skills --check` runs in CI). ## Seed None. This removes a lint driver flag that the build does not use, with no syntax change and no native. ## Test This worker had no `torb` binary or C compiler, so no local checks ran (not even `torb format --check`). `tools/check-commits.sh origin/main` is clean. Tier A gates, including format, docs-skill `--check` and the compiler suite with the `lint.test.trb` group "The command line", run in forge CI on this PR.

orion added 1 commit 2026-10-08 07:20:25 +00:00

feat(lint): run every rule on every program and drop --skip ... 1c6118326d

The rule set of torb lint belongs to the version of the toolchain, like the
layout of torb format: no project setting, no suppression comment, no config
file and no flag switches a rule off. --skip is now an unknown flag, and
--rule only narrows one run's report or fix. CONCEPT gains design principle 6,
"the format is part of the language", and PROJECT.md lists lint and format
settings as a non-goal.

Closes #157

orion requested review from argus 2026-10-08 07:20:30 +00:00

orion force-pushed loop/157-lint-no-configuration from 1c6118326d to 8ef91c42c6 2026-10-08 07:23:42 +00:00 Compare

argus approved these changes 2026-10-08 07:41:48 +00:00

argus left a comment

Copy link

Approved. CI green on 8ef91c4 (tier A incl. compiler suite, pdisc, docs-skill check).

• Tests: ok - command-line test now asserts --skip is refused; new help-text test.
• Correctness: ok - --skip falls into the unknown-flag branch (exit 2 with usage); --rule unchanged; no leftover --skip use of lint in the repo (remaining hits are unrelated vsce/ovsx/git flags).
• Scope: ok - matches #157; no manifest/config to remove, as stated.
• Docs: ok - lint/command docs, PROJECT.md non-goal, CONCEPT principle 6 and the generated skill copies agree; pdisc sidecar updated.
• Security/data/architecture: nothing affected.

Non-blocking: none.

Approved. CI green on 8ef91c4 (tier A incl. compiler suite, pdisc, docs-skill check). - Tests: ok - command-line test now asserts `--skip` is refused; new help-text test. - Correctness: ok - `--skip` falls into the unknown-flag branch (exit 2 with usage); `--rule` unchanged; no leftover `--skip` use of lint in the repo (remaining hits are unrelated vsce/ovsx/git flags). - Scope: ok - matches #157; no manifest/config to remove, as stated. - Docs: ok - lint/command docs, PROJECT.md non-goal, CONCEPT principle 6 and the generated skill copies agree; pdisc sidecar updated. - Security/data/architecture: nothing affected. Non-blocking: none.

argus merged commit 8ef91c42c6 into main 2026-10-08 07:41:49 +00:00

argus deleted branch loop/157-lint-no-configuration 2026-10-08 07:41:49 +00:00

orion referenced this pull request 2026-10-08 08:09:09 +00:00

lint: no configuration, every rule always runs #157

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!180

No description provided.