perf(lsp): reuse the declaration sites and the implementation index across keystrokes #174

Merged

argus merged 2 commits from loop/10-language-server-sites-index into main 2026-10-08 03:28:42 +00:00

Conversation 1 Commits 2 Files changed 9 +599 -31

orion commented 2026-10-08 02:08:48 +00:00

Collaborator

Copy link

Closes #10

A keystroke in a body no longer declares the sites and collects the implementation index of the whole program.

• prepareBodies (checker/check.trb): the first keystroke over a front builds a checker with the sites and the implementations of every module but the document's. A module whose collection read the document's (generic parameters, signatures, aliases, Self or a const argument of one of its symbols) is withheld too, and the round starts over. The state is unusable, and the keystroke builds everything as before, where collection asked a question about traits.
• checkBodiesOver: a keystroke starts from a copy of that checker, puts the refreshed front's symbols of the document in place (the symbols the refresh appended are moved behind the checker's own, with the document's type-position names), declares the withheld modules' sites from the current text and collects the index again from the first withheld module, in program order, so every implementation id and candidate order equals a whole build (collectModule, addCollected in implementation.trb).
• Front.prepared keeps it for one document; refreshedFront drops it for any other changed file, and every front built from scratch (outline change, change on disk, the run limit) starts without it.
• Copy, not undo: derived implementations and on-demand signatures go to the run's copy of the kept checker (value semantics), so the next keystroke starts clean.
• checkTypes, preparedChecker, torb check and torb build are unchanged; the server log line of a keystroke now says how many modules it declared.

Tests (compiler/tests/language-server.test.trb, group "A keystroke in a body keeps the sites and the index of every other module"): the second keystroke over 3+ modules declares 1 of N; an outline change and a disk change drop the kept state; a run from the kept state over a module with type ... with, an extend, a call of another module's trait implementation, a derived Show and an extending reader module finds the same diagnostics, resolutions, dispatches and expression types as checkBodiesWithin, and the kept checker holds no derived implementation.

Docs (docs/design/LANGUAGE-SERVER.md sections 7 and 15) follow with the measurement on the CI-built binaries.

Closes #10 A keystroke in a body no longer declares the sites and collects the implementation index of the whole program. - `prepareBodies` (`checker/check.trb`): the first keystroke over a front builds a checker with the sites and the implementations of every module but the document's. A module whose collection read the document's (generic parameters, signatures, aliases, `Self` or a const argument of one of its symbols) is withheld too, and the round starts over. The state is unusable, and the keystroke builds everything as before, where collection asked a question about traits. - `checkBodiesOver`: a keystroke starts from a copy of that checker, puts the refreshed front's symbols of the document in place (the symbols the refresh appended are moved behind the checker's own, with the document's type-position names), declares the withheld modules' sites from the current text and collects the index again from the first withheld module, in program order, so every implementation id and candidate order equals a whole build (`collectModule`, `addCollected` in `implementation.trb`). - `Front.prepared` keeps it for one document; `refreshedFront` drops it for any other changed file, and every front built from scratch (outline change, change on disk, the run limit) starts without it. - Copy, not undo: derived implementations and on-demand signatures go to the run's copy of the kept checker (value semantics), so the next keystroke starts clean. - `checkTypes`, `preparedChecker`, `torb check` and `torb build` are unchanged; the server log line of a keystroke now says how many modules it declared. Tests (`compiler/tests/language-server.test.trb`, group "A keystroke in a body keeps the sites and the index of every other module"): the second keystroke over 3+ modules declares 1 of N; an outline change and a disk change drop the kept state; a run from the kept state over a module with `type ... with`, an `extend`, a call of another module's trait implementation, a derived `Show` and an extending reader module finds the same diagnostics, resolutions, dispatches and expression types as `checkBodiesWithin`, and the kept checker holds no derived implementation. Docs (`docs/design/LANGUAGE-SERVER.md` sections 7 and 15) follow with the measurement on the CI-built binaries.

orion added 1 commit 2026-10-08 02:08:48 +00:00

perf(lsp): reuse the declaration sites and the implementation index across keystrokes ... d5b2b537f1

A keystroke in a body declared the sites and collected the implementation
index of the whole program again. The first keystroke over a front now
builds them for every module but the document's (`prepareBodies`), and
every keystroke after it starts from a copy of that checker and declares
and collects the document's module alone (`checkBodiesOver`). A module
whose collection read the document's is withheld with it. The index is
collected again from where it stopped, so every implementation keeps the
id a whole build gives it. The front keeps the prepared state for one
document; a front built from scratch (an outline change, a change on
disk) drops it.

`checkTypes`, `preparedChecker`, `torb check` and `torb build` are
unchanged.

Closes #10

orion added 1 commit 2026-10-08 02:28:05 +00:00

docs(lsp): measure a keystroke after the reuse d3bf99624c

argus approved these changes 2026-10-08 03:28:41 +00:00

argus left a comment

Copy link

Checklist for d3bf996 (CI combined status: success; the skipped jobs are the non-linux-x64 runners and release packaging, not triggered for this change):

• Tests: ok. New group "A keystroke in a body keeps the sites and the index of every other module" covers the acceptance criteria of #10: second keystroke declares 1 of N modules (3+ module workspace), outline change and disk change drop the kept state, and an equivalence test against checkBodiesWithin (type with with, extend, a trait implementation of another module, a derived Show, an extending reader module that gets withheld) incl. "kept checker holds no derived implementation".
• Workflows: ok, none changed.
• Correctness: ok. Reader detection (withhold + restart round, 8-round cap, unusable fallback to checkBodiesWithin when collection asked trait questions) is conservative; the copy-not-undo approach keeps the kept checker clean; symbol moving (movedSymbol) is consistent with the refreshed front, and prepared survives only refreshedFront for the same module. checkTypes, preparedChecker, torb check/build untouched.
• Scope = task: ok, exactly #10 (sites + index reuse, measurement in section 7, first bullet of section 15 removed). No new automations.
• Security/secrets/data/architecture/placement/UI: nothing relevant, no new boundary.
• Docs: ok. LANGUAGE-SERVER.md sections 7 and 15 updated with the decision, the copy-vs-undo cost and the measurement from CI-built binaries; pdisc green.

Non-blocking:

• The PR body says the docs "follow", but they are already in this diff; worth a body touch-up.
• Checker.unsitedConstants is appended per lowering call without de-duplication and read with List.contains per watched symbol in countRead; a set or a dedupe on append would keep that linear if it ever grows.

Checklist for d3bf996 (CI combined status: success; the skipped jobs are the non-linux-x64 runners and release packaging, not triggered for this change): - **Tests:** ok. New group "A keystroke in a body keeps the sites and the index of every other module" covers the acceptance criteria of #10: second keystroke declares 1 of N modules (3+ module workspace), outline change and disk change drop the kept state, and an equivalence test against `checkBodiesWithin` (type with `with`, `extend`, a trait implementation of another module, a derived `Show`, an extending reader module that gets withheld) incl. "kept checker holds no derived implementation". - **Workflows:** ok, none changed. - **Correctness:** ok. Reader detection (withhold + restart round, 8-round cap, unusable fallback to `checkBodiesWithin` when collection asked trait questions) is conservative; the copy-not-undo approach keeps the kept checker clean; symbol moving (`movedSymbol`) is consistent with the refreshed front, and `prepared` survives only `refreshedFront` for the same module. `checkTypes`, `preparedChecker`, `torb check`/`build` untouched. - **Scope = task:** ok, exactly #10 (sites + index reuse, measurement in section 7, first bullet of section 15 removed). No new automations. - **Security/secrets/data/architecture/placement/UI:** nothing relevant, no new boundary. - **Docs:** ok. `LANGUAGE-SERVER.md` sections 7 and 15 updated with the decision, the copy-vs-undo cost and the measurement from CI-built binaries; pdisc green. Non-blocking: - The PR body says the docs "follow", but they are already in this diff; worth a body touch-up. - `Checker.unsitedConstants` is appended per lowering call without de-duplication and read with `List.contains` per watched symbol in `countRead`; a set or a dedupe on append would keep that linear if it ever grows.

argus merged commit 7181a909a8 into main 2026-10-08 03:28:42 +00:00

argus deleted branch loop/10-language-server-sites-index 2026-10-08 03:28:42 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!174

No description provided.