torbscript/language
Watch
1
0
Fork
You've already forked language
 0
Code Issues 139 Pull requests 2 Projects Releases 18 Packages 3 Wiki Activity Actions

Epic: scripts name their receiver in a header; LSP types scripts alone #505

New issue
Closed
opened 2026-10-26 21:35:54 +00:00 by orion · 3 comments
orion commented 2026-10-26 21:35:54 +00:00
Collaborator
Copy link

End goal: hover, highlighting and go-to-definition in Forgejo's code view for project.trb and imported scripts. Browser LSP part: https://git.dmb.zone/orion/infra/issues/2329 (client half of torbscript/wantFiles/torbscript/files is phase 2 there).

Design: docs/design/SCRIPT-RECEIVERS.md in the PR (docs/adr-receiver-types). Decision: first statement receiver ServerConfig from "./src/server-config"; project.trb reserved by name; load-site inference and "first load decides" removed.

Slices in order: see the child issues (comment below once created).

End goal: hover, highlighting and go-to-definition in Forgejo's code view for `project.trb` and imported scripts. Browser LSP part: https://git.dmb.zone/orion/infra/issues/2329 (client half of `torbscript/wantFiles`/`torbscript/files` is phase 2 there). Design: `docs/design/SCRIPT-RECEIVERS.md` in the PR (docs/adr-receiver-types). Decision: first statement `receiver ServerConfig from "./src/server-config"`; `project.trb` reserved by name; load-site inference and "first load decides" removed. Slices in order: see the child issues (comment below once created).
orion commented 2026-10-26 21:36:14 +00:00
Author
Collaborator
Copy link

Slices in order (each depends on the previous unless noted); design PR: #504.

  • #506 slice 1: parser, formatter, highlighters
  • #507 slice 2: graph + checker, migration
  • #508 slice 3: diagnostics
  • #509 slice 4: LSP features on scripts
  • #510 slice 5: forward-only reads + wantFiles/files contract
  • #511 slice 6: docs

Browser LSP client: https://git.dmb.zone/orion/infra/issues/2329

Slices in order (each depends on the previous unless noted); design PR: #504. - [ ] #506 slice 1: parser, formatter, highlighters - [ ] #507 slice 2: graph + checker, migration - [ ] #508 slice 3: diagnostics - [ ] #509 slice 4: LSP features on scripts - [ ] #510 slice 5: forward-only reads + wantFiles/files contract - [ ] #511 slice 6: docs Browser LSP client: https://git.dmb.zone/orion/infra/issues/2329
orion commented 2026-10-26 21:36:40 +00:00
Author
Collaborator
Copy link

Question q1 for torben (decision, blocking): Soll jedes Skript seinen Empfänger-Typ selbst in der ersten Zeile nennen?

v: 1
id: q1
to: torben
kind: decision
blocking: true
question: >-
  Soll jedes Skript seinen Typ selbst in Zeile 1 nennen (receiver ServerConfig from "./src/server-config")? Dann ist es allein typisierbar, auch im Browser. Sonst nur per Dateiname wie project.trb, was pro Projekt eine Zuordnung bräuchte.
options:
  - id: header
    label: Ja, Typ in der ersten Zeile des Skripts
    detail: Jede Datei ist allein typisierbar (Browser, Editor); Konflikte werden Fehler an der Ladestelle.
  - id: filename
    label: Nur über Dateinamen
    detail: Braucht pro Projekt eine Zuordnungs-Konfiguration und kann keine Typen nennen.
recommendation: header
asked_by: orion

Der Entwurf (PR #504) folgt der Empfehlung, bis eine Antwort kommt.

**Question q1** for torben (decision, blocking): Soll jedes Skript seinen Empfänger-Typ selbst in der ersten Zeile nennen? ```hos-question v: 1 id: q1 to: torben kind: decision blocking: true question: >- Soll jedes Skript seinen Typ selbst in Zeile 1 nennen (receiver ServerConfig from "./src/server-config")? Dann ist es allein typisierbar, auch im Browser. Sonst nur per Dateiname wie project.trb, was pro Projekt eine Zuordnung bräuchte. options: - id: header label: Ja, Typ in der ersten Zeile des Skripts detail: Jede Datei ist allein typisierbar (Browser, Editor); Konflikte werden Fehler an der Ladestelle. - id: filename label: Nur über Dateinamen detail: Braucht pro Projekt eine Zuordnungs-Konfiguration und kann keine Typen nennen. recommendation: header asked_by: orion ``` Der Entwurf (PR #504) folgt der Empfehlung, bis eine Antwort kommt.
orion commented 2026-10-28 05:38:08 +00:00
Author
Collaborator
Copy link

Superseded by the owner decision of 2026-10-26 (script receivers are declared in project.trb, no per-file header): design record PR #519 (merged), epic #518, slices #512-#517. Closing so the loop does not implement the retired header design. Reopen if the header design comes back.

Superseded by the owner decision of 2026-10-26 (script receivers are declared in `project.trb`, no per-file header): design record PR https://git.torb.dev/torbscript/language/pulls/519 (merged), epic https://git.torb.dev/torbscript/language/issues/518, slices #512-#517. Closing so the loop does not implement the retired header design. Reopen if the header design comes back.
orion closed this issue 2026-10-28 05:38:08 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
loop/705-default-shadow
loop/691-tensor-core
loop/705-fix-candidate
orion/456-tierb-probe
loop/164-measure2
loop/207-measure
loop/164-prototype
probe/207-count
loop/205-measure
loop/140-hide-staged
nightly-20261103
nightly-20261031
nightly-20261029
nightly-20261027
nightly-20261026
nightly-20261025
nightly-20261024
nightly-20261023
nightly-20261021
nightly-20261020
nightly-20261015
nightly-20261014
nightly-20261013
nightly-20261011
nightly-20261010
nightly-20261009
nightly-20261008
seeds
Labels
Clear labels   
loop
Backlog item of the project loop (Orion), see CONTRIBUTING

  
ready
Refined to the definition of ready

No labels
loop
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torbscript/language#505
No description provided.