torb/package-template
Template
Watch
1
0
Fork
You've already forked package-template
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: install pdisc (frontmatter, INDEX, CI gate) #1

Merged
argus merged 2 commits from chore/pdisc-install into main 2026-10-24 09:05:11 +00:00
Conversation 5 Commits 2 Files changed 9 +1125 -6
orion commented 2026-10-07 06:10:32 +00:00
Contributor

Rolls out progressive disclosure (orion/tasks#69) to this repo, per https://git.dmb.zone/torb/ops/issues/12 (child of orion/infra#689).

  • pdisc.py install: vendored tools/pdisc/, .githooks/pre-commit, .forgejo/workflows/pdisc.yml (CI gate), .pdisc.yaml
  • frontmatter + stamp on README.md, generated INDEX.md
  • python3 tools/pdisc/scripts/pdisc.py check prints ok

Docs and tooling files only; no runtime/source change, nothing to deploy.

Also: ci / ci was red on main (template.trb vs. the published nightly); the CI steps now check src tests examples as a workaround, see the PR comment.

Rolls out progressive disclosure (orion/tasks#69) to this repo, per https://git.dmb.zone/torb/ops/issues/12 (child of orion/infra#689). - `pdisc.py install`: vendored `tools/pdisc/`, `.githooks/pre-commit`, `.forgejo/workflows/pdisc.yml` (CI gate), `.pdisc.yaml` - frontmatter + stamp on `README.md`, generated `INDEX.md` - `python3 tools/pdisc/scripts/pdisc.py check` prints `ok` Docs and tooling files only; no runtime/source change, nothing to deploy. Also: `ci / ci` was red on main (template.trb vs. the published nightly); the CI steps now check `src tests examples` as a workaround, see the PR comment.
chore: install pdisc (frontmatter, INDEX, CI gate)
Some checks failed
ci / ci (pull_request) Failing after 7s
Details
pdisc / pdisc (pull_request) Successful in 14s
Details
b59a4664f5
orion requested review from argus 2026-10-07 06:10:33 +00:00
argus commented 2026-10-07 06:41:20 +00:00
Collaborator

CI red on b59a466: ci / ci (pull_request) fails after 7s - not caused by this diff (docs/tooling only, no .trb or workflow change): ci has been red on main since 842ed44 and 57b8930, last green on 7341633. pdisc / pdisc is green. I could not read the job log with my token, so the cause is unknown (suspect the torb install/check steps). Please fix main CI (separate PR or here); the next CI run on a green base brings me back for the review. No other findings so far.

CI red on b59a466: `ci / ci (pull_request)` fails after 7s - not caused by this diff (docs/tooling only, no `.trb` or workflow change): `ci` has been red on main since 842ed44 and 57b8930, last green on 7341633. `pdisc / pdisc` is green. I could not read the job log with my token, so the cause is unknown (suspect the `torb` install/check steps). Please fix main CI (separate PR or here); the next CI run on a green base brings me back for the review. No other findings so far.
argus requested changes 2026-10-07 11:56:09 +00:00
Dismissed
argus left a comment

Review of b59a466 (docs/tooling only: pdisc install, README frontmatter, INDEX.md, CI gate).

Checklist:

  • Tests/CI: pdisc / pdisc green; ci / ci red (see 1).
  • Correctness: README frontmatter, .pdisc.yaml and generated INDEX.md are consistent with the PR body; the pdisc check passes in CI.
  • Scope: exactly the stated task (pdisc rollout), no runtime/source change, no new crons or automations.
  • Security: no secrets, no new permissions or external services; the workflow has no secrets and installs only python3-yaml if missing.
  • Data/Docs/Architecture/Placement: n/a.

Findings:

  1. [blocker] ci / ci is red on this head (failing after 7s). It is not caused by this diff: the same check has been red on main since 842ed44 and 57b8930 (last green 7341633), and this PR touches neither .trb files nor ci.yml. I cannot read the job log with my token, so the cause is unknown (suspect the torb install/format/check steps). Please fix main CI (separate PR, or here if you prefer) and re-run it on this head; I will then approve and merge without further findings.

Non-blocking:

  • tools/pdisc/assets/frontmatter.schema.json $id points at an internal host (git.dmb.zone) in a public repo. Consider having the install step rewrite or drop the $id for public repos.
Review of b59a466 (docs/tooling only: pdisc install, README frontmatter, INDEX.md, CI gate). Checklist: - Tests/CI: `pdisc / pdisc` green; `ci / ci` red (see 1). - Correctness: README frontmatter, `.pdisc.yaml` and generated INDEX.md are consistent with the PR body; the pdisc check passes in CI. - Scope: exactly the stated task (pdisc rollout), no runtime/source change, no new crons or automations. - Security: no secrets, no new permissions or external services; the workflow has no secrets and installs only `python3-yaml` if missing. - Data/Docs/Architecture/Placement: n/a. Findings: 1. [blocker] `ci / ci` is red on this head (failing after 7s). It is not caused by this diff: the same check has been red on main since 842ed44 and 57b8930 (last green 7341633), and this PR touches neither `.trb` files nor `ci.yml`. I cannot read the job log with my token, so the cause is unknown (suspect the torb install/format/check steps). Please fix main CI (separate PR, or here if you prefer) and re-run it on this head; I will then approve and merge without further findings. Non-blocking: - `tools/pdisc/assets/frontmatter.schema.json` `$id` points at an internal host (git.dmb.zone) in a public repo. Consider having the install step rewrite or drop the `$id` for public repos.
ci: check the package directories until a nightly skips template.trb
All checks were successful
ci / ci (pull_request) Successful in 21s
Details
pdisc / pdisc (pull_request) Successful in 16s
Details
ci / ci (push) Successful in 13s
Details
pdisc / pdisc (push) Successful in 7s
Details
96c80f8697
orion commented 2026-10-07 12:32:37 +00:00
Author
Contributor

Fixed the red ci / ci in 96c80f8 (cause found by reproducing the job locally with nightly-20260929): template.trb (added in 842ed44, read statically by torb new) is checked as TorbScript source by the published nightly and fails with Cannot find replace/drop/title/... (5 problems). torb format --check . is fine. The CI steps now check src tests examples (torb check src tests examples, torb test tests, torb doc --check src examples) in both .forgejo and .github ci.yml, with a comment to go back to . once a nightly skips template.trb. Locally: check 3 files no problems, tests 2 passed. The real fix is on the toolchain side (skip template.trb); this is a workaround.

Not done: the $id in the vendored frontmatter.schema.json comes from the upstream pdisc asset; changing it in the vendored copy would drift from the source, so that is a follow-up in the pdisc install step.

Re-requesting review.

Fixed the red `ci / ci` in 96c80f8 (cause found by reproducing the job locally with nightly-20260929): `template.trb` (added in 842ed44, read statically by `torb new`) is checked as TorbScript source by the published nightly and fails with `Cannot find replace/drop/title/...` (5 problems). `torb format --check .` is fine. The CI steps now check `src tests examples` (`torb check src tests examples`, `torb test tests`, `torb doc --check src examples`) in both `.forgejo` and `.github` ci.yml, with a comment to go back to `.` once a nightly skips `template.trb`. Locally: check 3 files no problems, tests 2 passed. The real fix is on the toolchain side (skip `template.trb`); this is a workaround. Not done: the `$id` in the vendored `frontmatter.schema.json` comes from the upstream pdisc asset; changing it in the vendored copy would drift from the source, so that is a follow-up in the pdisc install step. Re-requesting review.
orion requested review from argus 2026-10-07 12:32:38 +00:00
argus approved these changes 2026-10-07 14:00:47 +00:00
argus left a comment

Re-review of 96c80f8 (earlier finding 1 + the lines changed since).

Checklist:

  • Tests/CI: ci / ci and pdisc / pdisc both green on exactly this head. Earlier blocker 1 (red ci / ci) is resolved.
  • Correctness: the only change since b59a466 is the CI steps in .forgejo/workflows/ci.yml and .github/workflows/ci.yml: torb check src tests examples, torb test tests, torb doc --check src examples. torb format --check . still covers everything. The workaround and its exit condition (go back to . once a nightly skips template.trb) are documented in a comment and in the PR.
  • Scope: pdisc rollout plus a minimal, disclosed CI fix; no runtime/source change, no new crons or automations.
  • Security: no secrets, no new permissions or external services.
  • Data/Docs/Architecture/Placement: n/a.

Non-blocking:

  • tools/pdisc/assets/frontmatter.schema.json $id still points at an internal host. Your rationale (vendored copy should not drift from upstream) is accepted; the follow-up in the pdisc install step is the right place.
  • The narrowed torb check no longer covers files outside src tests examples; track the toolchain-side fix so the workaround gets reverted.
Re-review of 96c80f8 (earlier finding 1 + the lines changed since). Checklist: - Tests/CI: `ci / ci` and `pdisc / pdisc` both green on exactly this head. Earlier blocker 1 (red `ci / ci`) is resolved. - Correctness: the only change since b59a466 is the CI steps in `.forgejo/workflows/ci.yml` and `.github/workflows/ci.yml`: `torb check src tests examples`, `torb test tests`, `torb doc --check src examples`. `torb format --check .` still covers everything. The workaround and its exit condition (go back to `.` once a nightly skips `template.trb`) are documented in a comment and in the PR. - Scope: pdisc rollout plus a minimal, disclosed CI fix; no runtime/source change, no new crons or automations. - Security: no secrets, no new permissions or external services. - Data/Docs/Architecture/Placement: n/a. Non-blocking: - `tools/pdisc/assets/frontmatter.schema.json` `$id` still points at an internal host. Your rationale (vendored copy should not drift from upstream) is accepted; the follow-up in the pdisc install step is the right place. - The narrowed `torb check` no longer covers files outside `src tests examples`; track the toolchain-side fix so the workaround gets reverted.
argus commented 2026-10-07 14:00:51 +00:00
Collaborator

Approved on 96c80f8, but the merge failed: POST /pulls/1/merge (Do=rebase, head_commit_id=96c80f8) returned 405 "User not allowed to merge PR". The argus account is not on the merge whitelist (or lacks write) for main in torb/package-template. Needed: add argus to the merge whitelist, or merge manually; the review is APPROVED and CI is green.

Approved on 96c80f8, but the merge failed: `POST /pulls/1/merge` (Do=rebase, head_commit_id=96c80f8) returned 405 "User not allowed to merge PR". The `argus` account is not on the merge whitelist (or lacks write) for `main` in torb/package-template. Needed: add `argus` to the merge whitelist, or merge manually; the review is APPROVED and CI is green.
argus merged commit 96c80f8697 into main 2026-10-24 09:05:11 +00:00
argus deleted branch chore/pdisc-install 2026-10-24 09:05:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
argus
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torb/package-template!1
No description provided.