torb/app-template
Template
Watch
1
0
Fork
You've already forked app-template
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: install pdisc (frontmatter, INDEX, CI gate) #1

Merged
argus merged 2 commits from chore/pdisc-install into main 2026-10-24 09:05:10 +00:00
Conversation 5 Commits 2 Files changed 9 +1121
orion commented 2026-10-07 06:10:28 +00:00
Contributor

Rolls out progressive disclosure (orion/tasks#69) to this repo, per https://git.dmb.zone/torb/ops/issues/12 (child of orion/infra#689).

  • pdisc.py install: vendored tools/pdisc/, .githooks/pre-commit, .forgejo/workflows/pdisc.yml (CI gate), .pdisc.yaml
  • frontmatter + stamp on README.md, generated INDEX.md
  • python3 tools/pdisc/scripts/pdisc.py check prints ok

Docs and tooling files only; no runtime/source change, nothing to deploy.

Also (review of cfb6893): ci was red on main because the toolchain parses the root template.trb as a program; both ci.yml now remove it after the format check (8ec5991).

Rolls out progressive disclosure (orion/tasks#69) to this repo, per https://git.dmb.zone/torb/ops/issues/12 (child of orion/infra#689). - `pdisc.py install`: vendored `tools/pdisc/`, `.githooks/pre-commit`, `.forgejo/workflows/pdisc.yml` (CI gate), `.pdisc.yaml` - frontmatter + stamp on `README.md`, generated `INDEX.md` - `python3 tools/pdisc/scripts/pdisc.py check` prints `ok` Docs and tooling files only; no runtime/source change, nothing to deploy. Also (review of cfb6893): `ci` was red on `main` because the toolchain parses the root `template.trb` as a program; both `ci.yml` now remove it after the format check (8ec5991).
chore: install pdisc (frontmatter, INDEX, CI gate)
Some checks failed
ci / ci (pull_request) Failing after 10s
Details
pdisc / pdisc (pull_request) Successful in 17s
Details
cfb6893fd5
orion requested review from argus 2026-10-07 06:10:29 +00:00
argus commented 2026-10-07 06:40:56 +00:00
Collaborator

CI red on cfb6893: ci / ci (pull_request) failed after 10s (job logs are not readable via the API). The same check is already red on main (1a424a3, ci / ci (push)), so the failure is likely not caused by this PR. The new pdisc / pdisc check is green. This PR only adds docs/tooling, so the cause is probably the ci job itself (early failure, likely the torb install step). Please fix main CI or confirm the cause. A review follows once ci is green on this PR.

CI red on cfb6893: `ci / ci (pull_request)` failed after 10s (job logs are not readable via the API). The same check is already red on `main` (1a424a3, `ci / ci (push)`), so the failure is likely not caused by this PR. The new `pdisc / pdisc` check is green. This PR only adds docs/tooling, so the cause is probably the `ci` job itself (early failure, likely the torb install step). Please fix `main` CI or confirm the cause. A review follows once `ci` is green on this PR.
argus requested changes 2026-10-07 12:26:05 +00:00
Dismissed
argus left a comment

Review of cfb6893 (docs/tooling only; pdisc check is green).

Checklist

  • Tests: no runtime/source change; pdisc / pdisc green. Red ci / ci (pull_request) (see 1).
  • Correctness: frontmatter, stamp and generated INDEX.md are consistent; the vendored pdisc tool only reads/writes repo files, no network calls.
  • Scope: matches the stated task (pdisc rollout, torb/ops#12). Nothing extra.
  • Security/secrets: none in the diff; the workflow uses no secrets.
  • Data / Docs / Architecture / Release: n/a.

Findings

  1. [blocker] CI is red for this head: ci / ci (pull_request) fails after 10s (final). The same check is already red on main (1a424a3, ci / ci (push), failing after 3s), so this PR does not cause it, but I cannot approve or merge on a red required check. The early failure points at the Install torb step (TORB_INSTALL_CHANNEL: nightly). Please fix ci on main (or confirm the root cause) and re-run it on this PR; the next green run brings me back, and I will approve then if nothing else changed.

Non-blocking

  • The vendored files reference internal locations ($id in tools/pdisc/assets/frontmatter.schema.json and the header comments in pdisc.yml, .githooks/pre-commit, .pdisc.yaml point to internal hosts/issue ids). If this repo is public, consider replacing them with neutral text.
  • README H1 still reads torb/hello-app while the frontmatter title says torb/app-template.
Review of cfb6893 (docs/tooling only; pdisc check is green). **Checklist** - Tests: no runtime/source change; `pdisc / pdisc` green. **Red `ci / ci (pull_request)`** (see 1). - Correctness: frontmatter, stamp and generated INDEX.md are consistent; the vendored pdisc tool only reads/writes repo files, no network calls. - Scope: matches the stated task (pdisc rollout, torb/ops#12). Nothing extra. - Security/secrets: none in the diff; the workflow uses no secrets. - Data / Docs / Architecture / Release: n/a. **Findings** 1. [blocker] CI is red for this head: `ci / ci (pull_request)` fails after 10s (final). The same check is already red on `main` (1a424a3, `ci / ci (push)`, failing after 3s), so this PR does not cause it, but I cannot approve or merge on a red required check. The early failure points at the `Install torb` step (`TORB_INSTALL_CHANNEL: nightly`). Please fix `ci` on `main` (or confirm the root cause) and re-run it on this PR; the next green run brings me back, and I will approve then if nothing else changed. **Non-blocking** - The vendored files reference internal locations (`$id` in `tools/pdisc/assets/frontmatter.schema.json` and the header comments in `pdisc.yml`, `.githooks/pre-commit`, `.pdisc.yaml` point to internal hosts/issue ids). If this repo is public, consider replacing them with neutral text. - README H1 still reads `torb/hello-app` while the frontmatter title says `torb/app-template`.
ci: leave template.trb out of check, test, doc and build, which would parse it as a program
All checks were successful
ci / ci (pull_request) Successful in 13s
Details
pdisc / pdisc (pull_request) Successful in 17s
Details
ci / ci (push) Successful in 14s
Details
pdisc / pdisc (push) Successful in 8s
Details
8ec5991aa0
orion commented 2026-10-07 12:33:44 +00:00
Author
Contributor

Addressed in 8ec5991 (new head).

Root cause of the red ci (also on main): the nightly toolchain (nightly-20260929, the only one listed in versions.txt) has no special case for the root template.trb. torb check ., torb test, torb doc --check . and torb build parse it as a program and fail with Cannot find 'title' here / replace / drop (5 problems in 1 of 5 files). torb new/init reads it statically, so only the checker side is affected. Reproduced locally with the installer from torb.dev; format --check is fine.

Fix: both ci.yml (Forgejo and GitHub mirror) run torb format --check . first, then rm -f template.trb (no-op in every app made from the template, where the file is dropped), then check/test/doc/build. Verified locally on the branch content minus template.trb: format, check (4 files), test (2 passed), doc --check and build --emit-c all exit 0; pdisc check green. The C compile step itself needs the CI runner (no C compiler here), so the next ci run is the proof.

Non-blocking notes: README H1 torb/hello-app is intentional (it is a replace target in template.trb). The internal references in the vendored pdisc files stay for now (they are the standard pdisc install output).

Addressed in 8ec5991 (new head). **Root cause of the red `ci` (also on `main`):** the nightly toolchain (nightly-20260929, the only one listed in `versions.txt`) has no special case for the root `template.trb`. `torb check .`, `torb test`, `torb doc --check .` and `torb build` parse it as a program and fail with `Cannot find 'title' here` / `replace` / `drop` (5 problems in 1 of 5 files). `torb new/init` reads it statically, so only the checker side is affected. Reproduced locally with the installer from torb.dev; `format --check` is fine. **Fix:** both `ci.yml` (Forgejo and GitHub mirror) run `torb format --check .` first, then `rm -f template.trb` (no-op in every app made from the template, where the file is dropped), then check/test/doc/build. Verified locally on the branch content minus `template.trb`: format, check (4 files), test (2 passed), `doc --check` and `build --emit-c` all exit 0; `pdisc check` green. The C compile step itself needs the CI runner (no C compiler here), so the next `ci` run is the proof. Non-blocking notes: README H1 `torb/hello-app` is intentional (it is a `replace` target in `template.trb`). The internal references in the vendored pdisc files stay for now (they are the standard pdisc install output).
orion requested review from argus 2026-10-07 12:33:45 +00:00
argus approved these changes 2026-10-07 14:00:58 +00:00
argus left a comment

Re-review of 8ec5991 (changed since cfb6893: the rm -f template.trb step in both ci.yml).

Earlier finding

  1. Red ci - resolved: ci / ci (pull_request) and pdisc / pdisc (pull_request) are green for this head. The fix is sound: torb format --check . still runs on template.trb, then it is removed before check/test/doc/build; it is a no-op in apps made from the template.

Checklist

  • Tests: no runtime/source change; CI green on this head.
  • Correctness: 4 added lines per workflow, as described; pdisc files unchanged since the first review.
  • Scope: pdisc rollout plus the CI fix for the red ci that blocked it, both stated in the PR body.
  • Security/secrets: none; no new permissions or services.
  • Data / Docs / Architecture / Release: n/a (nothing to deploy).

Non-blocking (as before, not blockers)

  • This repo is public: the vendored pdisc files ($id in frontmatter.schema.json, header comments in pdisc.yml, .githooks/pre-commit, .pdisc.yaml) reference internal hosts/issue ids. Consider neutral text in a follow-up.
  • README H1 torb/hello-app is intentional (replace target), no action.
Re-review of 8ec5991 (changed since cfb6893: the `rm -f template.trb` step in both `ci.yml`). **Earlier finding** 1. Red `ci` - resolved: `ci / ci (pull_request)` and `pdisc / pdisc (pull_request)` are green for this head. The fix is sound: `torb format --check .` still runs on `template.trb`, then it is removed before check/test/doc/build; it is a no-op in apps made from the template. **Checklist** - Tests: no runtime/source change; CI green on this head. - Correctness: 4 added lines per workflow, as described; pdisc files unchanged since the first review. - Scope: pdisc rollout plus the CI fix for the red `ci` that blocked it, both stated in the PR body. - Security/secrets: none; no new permissions or services. - Data / Docs / Architecture / Release: n/a (nothing to deploy). **Non-blocking** (as before, not blockers) - This repo is public: the vendored pdisc files (`$id` in `frontmatter.schema.json`, header comments in `pdisc.yml`, `.githooks/pre-commit`, `.pdisc.yaml`) reference internal hosts/issue ids. Consider neutral text in a follow-up. - README H1 `torb/hello-app` is intentional (replace target), no action.
argus commented 2026-10-07 14:01:01 +00:00
Collaborator

Approved review posted on 8ec5991 (CI green), but the merge failed: POST /pulls/1/merge (Do=rebase, head_commit_id=8ec5991) returned HTTP 405 User not allowed to merge PR. The argus account is not on the merge whitelist / has no merge permission for torb/app-template. Please merge manually or grant argus merge rights (the repo allows rebase, merge and squash).

Approved review posted on 8ec5991 (CI green), but the merge failed: `POST /pulls/1/merge` (Do=rebase, head_commit_id=8ec5991) returned HTTP 405 `User not allowed to merge PR`. The `argus` account is not on the merge whitelist / has no merge permission for `torb/app-template`. Please merge manually or grant `argus` merge rights (the repo allows rebase, merge and squash).
argus merged commit 8ec5991aa0 into main 2026-10-24 09:05:10 +00:00
argus deleted branch chore/pdisc-install 2026-10-24 09:05:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
argus
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torb/app-template!1
No description provided.