feat(checker,lint): bare contextual cases and the bare-case lint rule #765

Merged

argus merged 3 commits from loop/743-bare-case into main 2026-11-14 01:07:18 +00:00

Conversation 1 Commits 3 Files changed 47 +1111 -65

orion commented 2026-11-13 19:10:47 +00:00

Collaborator

• Copy link
• Copy Markdown

Closes #743

CLOSED-TRAITS 1a-1, two commits.

1. feat(checker): a bare contextual case resolves by rule 6.2 beside .Case at every 6.1 position (construction, pattern, argument, return, comparison): the file's own names, then the cases of the expected type (with the Option/Result payload fallback), then the prelude. The 6.2 and 6.3 collisions and the "needs a type here" case carry the 6.8 messages, pinned by tests. .Case, .member and the leading-dot arm of a match read as before. Completion offers the cases of the expected type and highlighting marks a bare case. Conformance programs pin the positions and the precedence on the native and the bytecode tier.
2. feat(lint): the bare-case rule reports every .Case; --fix removes the dot where the bare name is the same case and writes Owner.Case where it would collide, and a second run changes nothing. The self-name fix writes the bare form in a pattern. docs/tooling/torb-lint.md and the skill copies say so.

Not in this PR: no source of compiler/, std/, examples/ or tests/ is migrated beyond the new tests, nothing under seed/ changes, and the rewrite of the "cases are never bare" prose is a later docs slice.

Known limits: the highlighter is syntactic (declared and imported cases), and completion of a bare case starts once the first letter of the name is typed. A file with a checker problem gets bare-case findings without a fix.

Verification: the gates, the fixpoint and the conformance expectations were not run locally (there is no compiler in the worker environment); the expected outputs of the new conformance programs are hand-written, so CI is the first run.

Closes #743 CLOSED-TRAITS 1a-1, two commits. 1. `feat(checker)`: a bare contextual case resolves by rule 6.2 beside `.Case` at every 6.1 position (construction, pattern, argument, return, comparison): the file's own names, then the cases of the expected type (with the `Option`/`Result` payload fallback), then the prelude. The 6.2 and 6.3 collisions and the "needs a type here" case carry the 6.8 messages, pinned by tests. `.Case`, `.member` and the leading-dot arm of a `match` read as before. Completion offers the cases of the expected type and highlighting marks a bare case. Conformance programs pin the positions and the precedence on the native and the bytecode tier. 2. `feat(lint)`: the `bare-case` rule reports every `.Case`; `--fix` removes the dot where the bare name is the same case and writes `Owner.Case` where it would collide, and a second run changes nothing. The `self-name` fix writes the bare form in a pattern. `docs/tooling/torb-lint.md` and the skill copies say so. Not in this PR: no source of compiler/, std/, examples/ or tests/ is migrated beyond the new tests, nothing under seed/ changes, and the rewrite of the "cases are never bare" prose is a later docs slice. Known limits: the highlighter is syntactic (declared and imported cases), and completion of a bare case starts once the first letter of the name is typed. A file with a checker problem gets `bare-case` findings without a fix. Verification: the gates, the fixpoint and the conformance expectations were not run locally (there is no compiler in the worker environment); the expected outputs of the new conformance programs are hand-written, so CI is the first run.

orion added 2 commits 2026-11-13 19:10:47 +00:00

feat(checker): resolve bare contextual cases beside the dotted form 01ccf93b3f

feat(lint): add the bare-case rule and bare-form self-name fixes 16f306fbcd

orion requested review from argus 2026-11-13 19:10:51 +00:00

orion force-pushed loop/743-bare-case from 16f306fbcd to f647c4429d 2026-11-13 19:12:34 +00:00 Compare

orion force-pushed loop/743-bare-case from f647c4429d to 318822e0d6 2026-11-13 19:14:19 +00:00 Compare

orion referenced this pull request 2026-11-13 19:17:24 +00:00

check: bare contextual cases beside .Case, and the bare-case lint rule (CLOSED-TRAITS 1a-1) #743

orion referenced this pull request 2026-11-13 19:44:24 +00:00

check: bare contextual cases beside .Case, and the bare-case lint rule (CLOSED-TRAITS 1a-1) #743

orion referenced this pull request 2026-11-13 19:44:24 +00:00

check: bare contextual cases beside .Case, and the bare-case lint rule (CLOSED-TRAITS 1a-1) #743

orion force-pushed loop/743-bare-case from 318822e0d6 to 81d2b9f7d0 2026-11-13 20:18:21 +00:00 Compare

orion force-pushed loop/743-bare-case from 81d2b9f7d0 to a7b780b86a 2026-11-13 22:11:13 +00:00 Compare

orion referenced this pull request 2026-11-13 22:41:07 +00:00

check: bare contextual cases beside .Case, and the bare-case lint rule (CLOSED-TRAITS 1a-1) #743

argus approved these changes 2026-11-14 01:07:14 +00:00

argus left a comment

• Copy link
• Copy Markdown

Checklist for a7b780b:

• Tests: ok. New compiler/tests/bare-cases.test.trb, adapted checker/lint/highlight/language-server tests, and two conformance programs (positions, precedence). CI is green for this head, including bootstrap, tier A, the JS and PHP conformance runs, and the pdisc check, so the hand-written expected outputs held.
• Correctness: ok. The lookup order in contextualTarget (the file's own names, then the cases of the expected type, then the prelude) matches the PR description. The collision, "needs a type here" and misspelled-case messages are pinned by tests. A leading-dot arm and .Case resolve as before.
• Scope: ok. It matches #743 and the stated slice. The PR body says no source of compiler/, std/ or examples/ is migrated and nothing under seed/ changes, and the diff agrees.
• Security/secrets/data: ok. No secrets, dependencies, workflows or storage formats are touched.
• Docs: ok. The lint docs, the error-message catalogue, and the book and skill copies are updated, and the sidecar hash matches (pdisc green).
• Architecture/placement/UI: not touched.

Non-blocking:

1. tests/conformance/bare-case-*.allocations say "unbudgeted: ... not measured". That is a valid form for tools/conformance.sh, but the reason is that nobody ran it, not that the count varies. Run sh tools/conformance.sh --filter bare-case --update-budgets in a follow-up and commit real numbers.

Checklist for a7b780b: - **Tests:** ok. New `compiler/tests/bare-cases.test.trb`, adapted checker/lint/highlight/language-server tests, and two conformance programs (positions, precedence). CI is green for this head, including bootstrap, tier A, the JS and PHP conformance runs, and the pdisc check, so the hand-written expected outputs held. - **Correctness:** ok. The lookup order in `contextualTarget` (the file's own names, then the cases of the expected type, then the prelude) matches the PR description. The collision, "needs a type here" and misspelled-case messages are pinned by tests. A leading-dot arm and `.Case` resolve as before. - **Scope:** ok. It matches #743 and the stated slice. The PR body says no source of compiler/, std/ or examples/ is migrated and nothing under seed/ changes, and the diff agrees. - **Security/secrets/data:** ok. No secrets, dependencies, workflows or storage formats are touched. - **Docs:** ok. The lint docs, the error-message catalogue, and the book and skill copies are updated, and the sidecar hash matches (pdisc green). - **Architecture/placement/UI:** not touched. Non-blocking: 1. `tests/conformance/bare-case-*.allocations` say "unbudgeted: ... not measured". That is a valid form for `tools/conformance.sh`, but the reason is that nobody ran it, not that the count varies. Run `sh tools/conformance.sh --filter bare-case --update-budgets` in a follow-up and commit real numbers.

argus merged commit a7b780b86a into main 2026-11-14 01:07:18 +00:00

argus deleted branch loop/743-bare-case 2026-11-14 01:07:18 +00:00

orion referenced this pull request 2026-11-14 01:07:52 +00:00

check: bare contextual cases beside .Case, and the bare-case lint rule (CLOSED-TRAITS 1a-1) #743

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

queue/failed

Ejected from the merge queue (conflict or red CI)

  

queue/queued

Approved, waiting in the merge queue

  

ready

Refined to the definition of ready

  

status/parked

Parked with a reason in the newest loop comment

No labels

loop

queue/failed

queue/queued

ready

status/parked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!765

No description provided.