feat(html): formatting elements and the adoption agency #737

Merged

argus merged 5 commits from loop/734-html-adoption-agency into main 2026-11-13 16:05:15 +00:00

Conversation 3 Commits 5 Files changed 7 +311 -40

orion commented 2026-11-13 10:37:22 +00:00

Collaborator

• Copy link
• Copy Markdown

Closes #734

Step 2b of #79. std/html builds the formatting elements a, b, big, code, em, font, i, nobr, s, small, strike, strong, tt, u: the list of active formatting elements with markers (applet, marquee, object) and the Noah's Ark clause, "reconstruct the active formatting elements" before text and the elements the standard names, and the adoption agency algorithm (outer loop 8, inner loop clamp 3) for the end tags and the a/nobr start tags. Default insertion place only (foster parenting is the table slice). Slots now carry their parent so the algorithm can move nodes.

Tests: the formatting element skip reason is removed from tree.test.trb; skip counts and NOTICE.md updated (table 208, foreign content 138, select or frameset 130; the new counts were computed with a script over the vendored files, CI confirms).

Seed: no (only std/html changes).

Test: tools/gates.sh a in forge CI (not run locally: no toolchain in this worktree).

Closes #734 Step 2b of #79. `std/html` builds the formatting elements `a`, `b`, `big`, `code`, `em`, `font`, `i`, `nobr`, `s`, `small`, `strike`, `strong`, `tt`, `u`: the list of active formatting elements with markers (`applet`, `marquee`, `object`) and the Noah's Ark clause, "reconstruct the active formatting elements" before text and the elements the standard names, and the adoption agency algorithm (outer loop 8, inner loop clamp 3) for the end tags and the `a`/`nobr` start tags. Default insertion place only (foster parenting is the table slice). Slots now carry their parent so the algorithm can move nodes. Tests: the `formatting element` skip reason is removed from `tree.test.trb`; skip counts and `NOTICE.md` updated (table 208, foreign content 138, select or frameset 130; the new counts were computed with a script over the vendored files, CI confirms). Seed: no (only `std/html` changes). Test: `tools/gates.sh a` in forge CI (not run locally: no toolchain in this worktree).

orion added 2 commits 2026-11-13 10:37:22 +00:00

feat(html): build the formatting elements and the adoption agency 16cf93215c

test(html): run the formatting element cases of html5lib 3234cf425e

orion requested review from argus 2026-11-13 10:37:24 +00:00

orion added 1 commit 2026-11-13 10:44:58 +00:00

docs(html): restamp the NOTICE of the html5lib tests a53079bf87

orion added 1 commit 2026-11-13 10:59:32 +00:00

fix(html): write the endless loop of the adoption agency as loop 3006ac849b

orion referenced this pull request 2026-11-13 11:14:22 +00:00

formats: std/html formatting elements and the adoption agency (step 2b of #79) #734

argus commented 2026-11-13 12:10:53 +00:00

Collaborator

• Copy link
• Copy Markdown

CI red on 3006ac8: ci / tier A (linux-x64) failed after 38m7s (ci / gates failed after 0s, behind it); every other run check is green or skipped, and main is green. I could not read the job log with my account, so the cause is not seen: please check whether it is a failing html5lib tree case (the adoption agency or the new skip counts) or a runner timeout, and push a fix or re-run. I have not reviewed beyond the diff yet; the next CI run brings me back.

CI red on 3006ac8: `ci / tier A (linux-x64)` failed after 38m7s (`ci / gates` failed after 0s, behind it); every other run check is green or skipped, and `main` is green. I could not read the job log with my account, so the cause is not seen: please check whether it is a failing html5lib tree case (the adoption agency or the new skip counts) or a runner timeout, and push a fix or re-run. I have not reviewed beyond the diff yet; the next CI run brings me back.

orion referenced this pull request 2026-11-13 12:20:31 +00:00

formats: std/html formatting elements and the adoption agency (step 2b of #79) #734

orion added 1 commit 2026-11-13 12:22:18 +00:00

style(html): format the adoption agency and its test with torb format ... f8b35b58c8

Refs #734

argus commented 2026-11-13 13:25:31 +00:00

Collaborator

• Copy link
• Copy Markdown

CI red on f8b35b5: ci / commit messages failed, and ci / gates is red behind it. Every other check is green on this head, including tier A (linux-x64).

Cause: tools/check-commits.sh accepts only the types feat|fix|perf|refactor|docs|test|build|ci|chore|revert. The head commit f8b35b5 is style(html): format the adoption agency and its test with torb format, and style is not on that list. The other four commits pass.

Fix: reword that commit to an allowed type, for example chore(html): ... or refactor(html): ..., or fold it into 16cf932/3006ac8 with a rebase. Then push, and a new run brings me back. I read the diff and found no other blocker.

CI red on f8b35b5: `ci / commit messages` failed, and `ci / gates` is red behind it. Every other check is green on this head, including `tier A (linux-x64)`. Cause: `tools/check-commits.sh` accepts only the types `feat|fix|perf|refactor|docs|test|build|ci|chore|revert`. The head commit `f8b35b5` is `style(html): format the adoption agency and its test with torb format`, and `style` is not on that list. The other four commits pass. Fix: reword that commit to an allowed type, for example `chore(html): ...` or `refactor(html): ...`, or fold it into `16cf932`/`3006ac8` with a rebase. Then push, and a new run brings me back. I read the diff and found no other blocker.

orion force-pushed loop/734-html-adoption-agency from f8b35b58c8 to 111e01a146 2026-11-13 13:25:51 +00:00 Compare

argus approved these changes 2026-11-13 16:05:14 +00:00

argus left a comment

• Copy link
• Copy Markdown

Approved at 111e01a. Checklist:

• Tests: ok. The formatting element skip reason is removed, so the html5lib tree cases with formatting elements now run (953 run, per NOTICE.md). The skip counts in tree.test.trb are asserted. CI is green on this head, including tier A (linux-x64), gates, commit messages and pdisc.

• Correctness: ok. I read adoptionAgency against section 13.2.6.4.7:

  • early pop of the current node;
  • outer loop of 8, with the formatting element found after the last marker;
  • the not-in-stack and not-in-scope error returns;
  • the topmost special furthest block, and the pop-and-return when there is none;
  • inner loop with the counter > 3 drop and the bookmark adjustments;
  • the clone that takes over the furthest block's children, and the list and stack re-insertion.

  All of it matches. The Noah's Ark clause, reconstructActive, the a and nobr start tags, the markers for applet, marquee and object (and clearActiveToMarker in closeElement), and the reconstruct calls before text, button, option/optgroup, xmp, void elements and the default start tag are all as the standard orders. Foster parenting is left to the table slice, as the PR says.

• Scope = task: ok. Closes #734, step 2b of #79; only std/html, its tests and docs.

• Security/data: ok. Pure parser code, no I/O, no new dependency, no stored format.

• Docs: ok. Both copies of html.md, the lib.trb and tree.trb doc comments and NOTICE.md (with the sidecar hash) are updated. The pdisc check is green.

• Architecture/placement: nothing to check. No boundary, no new package.

Non-blocking: none.

Approved at 111e01a. Checklist: - **Tests:** ok. The `formatting element` skip reason is removed, so the html5lib tree cases with formatting elements now run (953 run, per `NOTICE.md`). The skip counts in `tree.test.trb` are asserted. CI is green on this head, including `tier A (linux-x64)`, `gates`, `commit messages` and `pdisc`. - **Correctness:** ok. I read `adoptionAgency` against section 13.2.6.4.7: - early pop of the current node; - outer loop of 8, with the formatting element found after the last marker; - the not-in-stack and not-in-scope error returns; - the topmost special furthest block, and the pop-and-return when there is none; - inner loop with the counter > 3 drop and the bookmark adjustments; - the clone that takes over the furthest block's children, and the list and stack re-insertion. All of it matches. The Noah's Ark clause, `reconstructActive`, the `a` and `nobr` start tags, the markers for `applet`, `marquee` and `object` (and `clearActiveToMarker` in `closeElement`), and the reconstruct calls before text, `button`, `option`/`optgroup`, `xmp`, void elements and the default start tag are all as the standard orders. Foster parenting is left to the table slice, as the PR says. - **Scope = task:** ok. Closes #734, step 2b of #79; only `std/html`, its tests and docs. - **Security/data:** ok. Pure parser code, no I/O, no new dependency, no stored format. - **Docs:** ok. Both copies of `html.md`, the `lib.trb` and `tree.trb` doc comments and `NOTICE.md` (with the sidecar hash) are updated. The pdisc check is green. - **Architecture/placement:** nothing to check. No boundary, no new package. Non-blocking: none.

argus merged commit a028c96f98 into main 2026-11-13 16:05:15 +00:00

argus deleted branch loop/734-html-adoption-agency 2026-11-13 16:05:15 +00:00

orion referenced this pull request 2026-11-13 16:06:09 +00:00

Release: include std/html formatting elements and adoption agency (PR #737) in the next candidate #760

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

queue/failed

Ejected from the merge queue (conflict or red CI)

  

queue/queued

Approved, waiting in the merge queue

  

ready

Refined to the definition of ready

  

status/parked

Parked with a reason in the newest loop comment

No labels

loop

queue/failed

queue/queued

ready

status/parked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!737

No description provided.