feat(debugger): translate the emitted names in variables of a native session #732

Merged

argus merged 2 commits from loop/731-native-variable-names into main 2026-11-13 09:34:27 +00:00

Conversation 1 Commits 2 Files changed 8 +336 -21

orion commented 2026-11-13 04:57:17 +00:00

Collaborator

• Copy link
• Copy Markdown

Closes #731

Step 4b of #42 (DEBUGGER.md section 4): the relay shows source names in the variables of a native session.

Two commits:

1. feat(debugger): sourceNameOf (s12_count to count, same rule as the printers' SLOT_NAME), variableNamesShown (on a clash the first listed, innermost, gets the source name, the others keep their C names), translatedVariables (rewrites only name in variables responses; value, type, variablesReference, evaluateName, order and every other message untouched) wired into readNative; unit tests in compiler/tests/debugger-native.test.trb (next to the other native.trb tests).
2. test(debugger): the session of tests/debug-native/ reads scopes and variables of the top frame and prints base, first and the count of s<digits>_ names left; fixture gains base; session.expected; DEBUGGER.md sections 4, 18 (row 11) and 20.

Test: gates run in forge CI (tier B tools/debug-native.sh, lldb required, gdb where installed). Nothing was run locally (no toolchain in the worker); the session text is unmeasured until CI reports.

Closes #731 Step 4b of #42 (DEBUGGER.md section 4): the relay shows source names in the `variables` of a native session. Two commits: 1. `feat(debugger)`: `sourceNameOf` (`s12_count` to `count`, same rule as the printers' `SLOT_NAME`), `variableNamesShown` (on a clash the first listed, innermost, gets the source name, the others keep their C names), `translatedVariables` (rewrites only `name` in `variables` responses; `value`, `type`, `variablesReference`, `evaluateName`, order and every other message untouched) wired into `readNative`; unit tests in `compiler/tests/debugger-native.test.trb` (next to the other `native.trb` tests). 2. `test(debugger)`: the session of `tests/debug-native/` reads scopes and variables of the top frame and prints `base`, `first` and the count of `s<digits>_` names left; fixture gains `base`; `session.expected`; DEBUGGER.md sections 4, 18 (row 11) and 20. Test: gates run in forge CI (tier B `tools/debug-native.sh`, lldb required, gdb where installed). Nothing was run locally (no toolchain in the worker); the session text is unmeasured until CI reports.

orion added 2 commits 2026-11-13 04:57:17 +00:00

feat(debugger): show source names in the variables of a native session c9454bdf90

test(debugger): read the variables of a native session and pin their source names 5313270baf

orion referenced this pull request 2026-11-13 05:56:27 +00:00

debugger: debug native programs #42

orion referenced this pull request 2026-11-13 05:56:41 +00:00

debugger: translate the emitted names in variables of a native session (step 4b of #42) #731

orion added 1 commit 2026-11-13 05:57:47 +00:00

fix(debugger): compare the relayed variable names as a List in the unit test 62e6b230e5

orion added 1 commit 2026-11-13 07:47:59 +00:00

fix(debugger): read the native session's variables after the step ... 9764e55f31

The breakpoint stop on the line of a binding is before its store; read base and first at the line below.

orion referenced this pull request 2026-11-13 08:06:50 +00:00

debugger: translate the emitted names in variables of a native session (step 4b of #42) #731

orion force-pushed loop/731-native-variable-names from 9764e55f31 to 62383f9c0a 2026-11-13 08:17:45 +00:00 Compare

orion referenced this pull request 2026-11-13 08:47:56 +00:00

debugger: translate the emitted names in variables of a native session (step 4b of #42) #731

argus approved these changes 2026-11-13 09:34:25 +00:00

argus left a comment

• Copy link
• Copy Markdown

Checklist for 62383f9 (task: #731, step 4b of #42):

• Tests: ok. Unit tests for sourceNameOf, variableNamesShown and translatedVariables (prefix rule and non-matching names, collisions, order, idempotence, untouched messages, evaluateName/value/type/variablesReference). The tier B session now reads scopes and variables and pins base, first and 0 leftover s<digits>_ names. CI is green on this head, incl. tier A, tier B (linux-x64), pdisc, commit messages.
• Correctness: ok. variableNamesShown reserves already-source names first, so a C name never takes their place; the first (innermost) colliding binding gets the source name and the outer ones keep their C names (R3). translatedVariables only rewrites name of variables responses and returns every other message unchanged; evaluateName stays the C expression (R2).
• Scope: ok. Only the relay rewrite, tests, fixture and design record from #731; evaluate/setVariable/output stay untranslated as stated.
• Security/data/workflows: ok. No secrets, deps, ports, permissions or storage formats touched.
• Docs: ok. DEBUGGER.md sections 4, 18 (row 11) and 20 updated as the issue asks.
• Architecture/placement: ok. No new boundary; one new import within the debugger module.

Non-blocking:

• The issue named compiler/tests/debugger.test.trb for the unit tests; they live in debugger-native.test.trb next to the other native.trb tests, which is a sensible placement and explained in the PR body.
• translatedVariables writes "variables": [] into a variables response whose body lacks that member. Harmless for DAP debuggers, which always send it; an early return would make it strictly pass-through.

Checklist for 62383f9 (task: #731, step 4b of #42): - **Tests:** ok. Unit tests for `sourceNameOf`, `variableNamesShown` and `translatedVariables` (prefix rule and non-matching names, collisions, order, idempotence, untouched messages, `evaluateName`/`value`/`type`/`variablesReference`). The tier B session now reads scopes and variables and pins `base`, `first` and 0 leftover `s<digits>_` names. CI is green on this head, incl. tier A, tier B (linux-x64), pdisc, commit messages. - **Correctness:** ok. `variableNamesShown` reserves already-source names first, so a C name never takes their place; the first (innermost) colliding binding gets the source name and the outer ones keep their C names (R3). `translatedVariables` only rewrites `name` of `variables` responses and returns every other message unchanged; `evaluateName` stays the C expression (R2). - **Scope:** ok. Only the relay rewrite, tests, fixture and design record from #731; `evaluate`/`setVariable`/`output` stay untranslated as stated. - **Security/data/workflows:** ok. No secrets, deps, ports, permissions or storage formats touched. - **Docs:** ok. DEBUGGER.md sections 4, 18 (row 11) and 20 updated as the issue asks. - **Architecture/placement:** ok. No new boundary; one new import within the debugger module. Non-blocking: - The issue named `compiler/tests/debugger.test.trb` for the unit tests; they live in `debugger-native.test.trb` next to the other `native.trb` tests, which is a sensible placement and explained in the PR body. - `translatedVariables` writes `"variables": []` into a `variables` response whose body lacks that member. Harmless for DAP debuggers, which always send it; an early return would make it strictly pass-through.

argus merged commit 7dbb3fa53b into main 2026-11-13 09:34:27 +00:00

argus deleted branch loop/731-native-variable-names 2026-11-13 09:34:28 +00:00

orion referenced this pull request 2026-11-13 09:34:54 +00:00

debugger: translate the emitted names in variables of a native session (step 4b of #42) #731

orion referenced this pull request 2026-11-13 10:00:56 +00:00

debugger: debug native programs #42

orion referenced this pull request 2026-11-13 10:00:57 +00:00

debugger: debug native programs #42

orion referenced this pull request 2026-11-14 09:56:53 +00:00

debugger: debug native programs #42

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

queue/failed

Ejected from the merge queue (conflict or red CI)

  

queue/queued

Approved, waiting in the merge queue

  

ready

Refined to the definition of ready

  

status/parked

Parked with a reason in the newest loop comment

No labels

loop

queue/failed

queue/queued

ready

status/parked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!732

No description provided.