docs(framework): worked example through every layer #604

Merged
argus merged 3 commits from loop/87-framework-design into main 2026-10-29 21:35:28 +00:00
Collaborator

Refs #87

A design with one example through every layer (orders: REST controller, service, repository, database, two profiles, events, middleware, one test slice per layer).

Done

  • docs/design/FRAMEWORK.md section 3 "The worked example": excerpts, Spring Boot and Symfony side-by-side, the their-word / our-word table, the readability judgement with line counts, gaps G1..G10, sign-off note; status line updated (example exists, framework still planned).
  • examples/framework/: package (domain, config + profile scripts, stand-in database, repository, service, events, web, module) and three test files (controller, service, repository).

Not verified locally: the host cannot run torb (GLIBC mismatch), so torb check, torb format --check and torb test are first run by CI. A red check is a finding to fix on this branch, not a reason to loosen the record. Only the 120-column limit was checked by script.

Left

  • Owner sign-off on the readability judgement (after merge, hence Refs and not Closes).
  • Fixes for whatever the first CI run reports.
Refs #87 A design with one example through every layer (orders: REST controller, service, repository, database, two profiles, events, middleware, one test slice per layer). **Done** - `docs/design/FRAMEWORK.md` section 3 "The worked example": excerpts, Spring Boot and Symfony side-by-side, the their-word / our-word table, the readability judgement with line counts, gaps G1..G10, sign-off note; status line updated (example exists, framework still planned). - `examples/framework/`: package (domain, config + profile scripts, stand-in database, repository, service, events, web, module) and three test files (controller, service, repository). **Not verified locally**: the host cannot run `torb` (GLIBC mismatch), so `torb check`, `torb format --check` and `torb test` are first run by CI. A red check is a finding to fix on this branch, not a reason to loosen the record. Only the 120-column limit was checked by script. **Left** - Owner sign-off on the readability judgement (after merge, hence Refs and not Closes). - Fixes for whatever the first CI run reports.
docs(examples): add the framework example package
Some checks failed
ci / commit messages (pull_request) Has been cancelled
ci / what the change touches (pull_request) Has been cancelled
ci / gates (pull_request) Has been cancelled
pdisc / pdisc (pull_request) Has been cancelled
1025420a69
docs(framework): worked example through every layer
Some checks failed
ci / commit messages (pull_request) Successful in 7s
ci / what the change touches (pull_request) Successful in 7s
ci / the VS Code extension (editors/vscode) (pull_request) Has been skipped
pdisc / pdisc (pull_request) Successful in 13s
ci / which runners exist (pull_request) Successful in 1s
ci / bootstrap and conformance (windows-x64) (pull_request) Has been skipped
ci / bootstrap and conformance (linux-arm64) (pull_request) Has been skipped
ci / bootstrap and conformance (macos-arm64) (pull_request) Has been skipped
ci / bootstrap (linux-x64) (pull_request) Successful in 15s
ci / tier B (linux-x64) (pull_request) Has been skipped
ci / tools/release-sync and tools/registry (linux-x64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (windows-x64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (linux-arm64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (macos-arm64) (pull_request) Has been skipped
ci / every host emits the same C (pull_request) Has been skipped
ci / the playground (torb as WebAssembly) (pull_request) Has been skipped
ci / tier A (linux-x64) (pull_request) Failing after 11m13s
ci / gates (pull_request) Has been cancelled
ci / pack the seed (pull_request) Has been cancelled
ci / archives (pull_request) Has been cancelled
b3ed7db07a
orion force-pushed loop/87-framework-design from b3ed7db07a
Some checks failed
ci / commit messages (pull_request) Successful in 7s
ci / what the change touches (pull_request) Successful in 7s
ci / the VS Code extension (editors/vscode) (pull_request) Has been skipped
pdisc / pdisc (pull_request) Successful in 13s
ci / which runners exist (pull_request) Successful in 1s
ci / bootstrap and conformance (windows-x64) (pull_request) Has been skipped
ci / bootstrap and conformance (linux-arm64) (pull_request) Has been skipped
ci / bootstrap and conformance (macos-arm64) (pull_request) Has been skipped
ci / bootstrap (linux-x64) (pull_request) Successful in 15s
ci / tier B (linux-x64) (pull_request) Has been skipped
ci / tools/release-sync and tools/registry (linux-x64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (windows-x64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (linux-arm64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (macos-arm64) (pull_request) Has been skipped
ci / every host emits the same C (pull_request) Has been skipped
ci / the playground (torb as WebAssembly) (pull_request) Has been skipped
ci / tier A (linux-x64) (pull_request) Failing after 11m13s
ci / gates (pull_request) Has been cancelled
ci / pack the seed (pull_request) Has been cancelled
ci / archives (pull_request) Has been cancelled
to 0f86e5cc1d
All checks were successful
ci / commit messages (pull_request) Successful in 7s
ci / what the change touches (pull_request) Successful in 5s
pdisc / pdisc (pull_request) Successful in 12s
ci / which runners exist (pull_request) Successful in 1s
ci / bootstrap and conformance (windows-x64) (pull_request) Has been skipped
ci / bootstrap and conformance (linux-arm64) (pull_request) Has been skipped
ci / bootstrap and conformance (macos-arm64) (pull_request) Has been skipped
ci / bootstrap (linux-x64) (pull_request) Successful in 12s
ci / cross-compiled on linux-x64 (windows-x64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (linux-arm64) (pull_request) Has been skipped
ci / cross-compiled on linux-x64 (macos-arm64) (pull_request) Has been skipped
ci / the VS Code extension (editors/vscode) (pull_request) Successful in 17s
ci / tools/release-sync and tools/registry (linux-x64) (pull_request) Successful in 4m17s
ci / every host emits the same C (pull_request) Successful in 9m21s
ci / the playground (torb as WebAssembly) (pull_request) Successful in 4m17s
ci / tier B (linux-x64) (pull_request) Successful in 20m58s
ci / tier A (linux-x64) (pull_request) Successful in 39m21s
ci / pack the seed (pull_request) Has been skipped
ci / archives (pull_request) Has been skipped
ci / gates (pull_request) Successful in 0s
2026-10-29 20:44:22 +00:00
Compare
argus approved these changes 2026-10-29 21:35:27 +00:00
argus left a comment

Checklist for 0f86e5c:

  • Tests/CI: ok. Combined status success; tier A runs check ., format --check and test of every example package, so the new examples/framework (controller, service, repository tests) was exercised, which the PR body had flagged as unverified locally. pdisc green.
  • Correctness: ok. Excerpts in FRAMEWORK.md section 3 match the package files; gaps G1..G11 are declared where the package stands in for missing std parts.
  • Scope: ok. Matches #87 (worked example in FRAMEWORK.md, owner sign-off left open, hence Refs).
  • Security/secrets: ok. No credentials; the prod profile takes the password through secret "DB_PASSWORD".
  • Data/architecture/placement: n/a. Docs and an example package only, no boundary change in the product.
  • Docs: ok. Status line updated, package README added.

Non-blocking: the line counts in 3.7 will drift as the package changes; consider regenerating them when the framework starts.

Checklist for 0f86e5c: - Tests/CI: ok. Combined status success; tier A runs `check .`, `format --check` and `test` of every example package, so the new `examples/framework` (controller, service, repository tests) was exercised, which the PR body had flagged as unverified locally. pdisc green. - Correctness: ok. Excerpts in FRAMEWORK.md section 3 match the package files; gaps G1..G11 are declared where the package stands in for missing `std` parts. - Scope: ok. Matches #87 (worked example in FRAMEWORK.md, owner sign-off left open, hence `Refs`). - Security/secrets: ok. No credentials; the prod profile takes the password through `secret "DB_PASSWORD"`. - Data/architecture/placement: n/a. Docs and an example package only, no boundary change in the product. - Docs: ok. Status line updated, package README added. Non-blocking: the line counts in 3.7 will drift as the package changes; consider regenerating them when the framework starts.
argus merged commit 114d93039c into main 2026-10-29 21:35:28 +00:00
argus deleted branch loop/87-framework-design 2026-10-29 21:35:28 +00:00
Sign in to join this conversation.
No reviewers
No labels
loop
ready
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torbscript/language!604
No description provided.