feat(runtime): add torb_file_system_path and its manifest row for systemPath #560

Merged

argus merged 1 commit from loop/559-system-path-native into main 2026-10-29 00:46:50 +00:00

Conversation 1 Commits 1 Files changed 10 +456 -312

orion commented 2026-10-28 23:28:42 +00:00

Collaborator

Copy link

Closes #559

Step 2b of #68, commit 1 of 2 of the two-commit rule for a new native: teach the runtime and the manifest, nothing in std/, compiler/ or tools/ calls it yet.

What

• runtime/file.c: torb_file_system_path(torb_text path), declared in runtime/include/torb.h outside the _WIN32 block with a doc comment.
• runtime/platform.c (the only file with #ifdef _WIN32): torb_platform_system_path_text. POSIX answers the text itself (a path is bytes there, no copy of the bytes, only a counted reference). Windows builds the text of torb_platform_system_path (backslashes, \\?\ above MAX_PATH) and converts it back with torb_platform_utf8.
• compiler/src/backend/c/natives.trb: row fileSystemPath -> torb_file_system_path; row in the audit record docs/design/NATIVES.md (keep 205, total 562).
• Generated files written by hand to exactly what torb natives --header writes (no bootstrap in the agent's exec; compiler/tests/natives.test.trb compares them with the generator): runtime/include/torb_natives.h (one prototype, sorted) and runtime/machine_natives.c (one thunk at index 98, the following thunks renumbered, table row, count 332).
• docs/design/PATH.md: one sentence in the status header (runtime half of systemPath in, std/fs function not; stays "partly implemented").

Decisions

• Signature. The issue names torb_file_system_path(torb_text path, torb_text *out). The private declaration native fn fileSystemPath(path: String): String is a plain Direct native (no Optional/Fallible shape fits a call that cannot fail), so the runtime answers the text as the return value, like torb_file_path: torb_text torb_file_system_path(torb_text path).
• No sandbox check. It is text arithmetic like torb_file_absolute_path_of; no file is touched.
• Manifest row without a std declaration. Not built here (no bootstrap in the agent's exec); the row is only data, and the natives tests read the manifest. If the forge CI rejects an unused row, the diagnostic will be quoted below and the row moves to the next step.

Tests

• POSIX: runtime/tests/file_test.c the_system_form_of_a_path_on_posix_is_the_path_itself (empty text, root, relative, .., non-ASCII name, a backslash) - runs in the forge CI with sh runtime/build.sh.
• Windows: runtime/tests/platform_test.c under #if defined(_WIN32): C:/a/b -> C:\a\b, a share, a non-ASCII name, the empty text, a path above MAX_PATH -> \\?\C:\..., a long share -> \\?\UNC\.... The forge CI cannot run these; the GitHub mirror's portable.yml builds them.

Seed

New native: the published seed has to contain this commit before step 2c (the std/fs wrapper) is pushed. Publishing the seed stays with Torben and the nightly.

Closes #559 Step 2b of #68, commit 1 of 2 of the two-commit rule for a new native: teach the runtime and the manifest, nothing in `std/`, `compiler/` or `tools/` calls it yet. ## What - `runtime/file.c`: `torb_file_system_path(torb_text path)`, declared in `runtime/include/torb.h` outside the `_WIN32` block with a doc comment. - `runtime/platform.c` (the only file with `#ifdef _WIN32`): `torb_platform_system_path_text`. POSIX answers the text itself (a path is bytes there, no copy of the bytes, only a counted reference). Windows builds the text of `torb_platform_system_path` (backslashes, `\\?\` above `MAX_PATH`) and converts it back with `torb_platform_utf8`. - `compiler/src/backend/c/natives.trb`: row `fileSystemPath` -> `torb_file_system_path`; row in the audit record `docs/design/NATIVES.md` (keep 205, total 562). - Generated files written by hand to exactly what `torb natives --header` writes (no bootstrap in the agent's exec; `compiler/tests/natives.test.trb` compares them with the generator): `runtime/include/torb_natives.h` (one prototype, sorted) and `runtime/machine_natives.c` (one thunk at index 98, the following thunks renumbered, table row, count 332). - `docs/design/PATH.md`: one sentence in the status header (runtime half of `systemPath` in, `std/fs` function not; stays "partly implemented"). ## Decisions - **Signature.** The issue names `torb_file_system_path(torb_text path, torb_text *out)`. The private declaration `native fn fileSystemPath(path: String): String` is a plain `Direct` native (no `Optional`/`Fallible` shape fits a call that cannot fail), so the runtime answers the text as the return value, like `torb_file_path`: `torb_text torb_file_system_path(torb_text path)`. - **No sandbox check.** It is text arithmetic like `torb_file_absolute_path_of`; no file is touched. - **Manifest row without a `std` declaration.** Not built here (no bootstrap in the agent's exec); the row is only data, and the natives tests read the manifest. If the forge CI rejects an unused row, the diagnostic will be quoted below and the row moves to the next step. ## Tests - POSIX: `runtime/tests/file_test.c` `the_system_form_of_a_path_on_posix_is_the_path_itself` (empty text, root, relative, `..`, non-ASCII name, a backslash) - runs in the forge CI with `sh runtime/build.sh`. - Windows: `runtime/tests/platform_test.c` under `#if defined(_WIN32)`: `C:/a/b` -> `C:\a\b`, a share, a non-ASCII name, the empty text, a path above `MAX_PATH` -> `\\?\C:\...`, a long share -> `\\?\UNC\...`. **The forge CI cannot run these**; the GitHub mirror's `portable.yml` builds them. ## Seed New native: the published seed has to contain this commit before step 2c (the `std/fs` wrapper) is pushed. Publishing the seed stays with Torben and the nightly.

orion added 1 commit 2026-10-28 23:28:42 +00:00

feat(runtime): add torb_file_system_path and its manifest row for systemPath f17e94f5c5

orion referenced this pull request 2026-10-28 23:50:08 +00:00

fs: systemPath runtime native (step 2b of #68, commit 1 of 2) #559

argus approved these changes 2026-10-29 00:46:48 +00:00

argus left a comment

Copy link

Checklist for f17e94f:

• Tests: ok. POSIX identity test in runtime/tests/file_test.c (empty, root, relative, .., non-ASCII, backslash); Windows cases in platform_test.c under _WIN32 (short, share, non-ASCII, empty, long \\?\, long UNC). CI green for this head (tier A/B, bootstrap, natives/conformance gates).
• Correctness: ok. torb_platform_system_path_text reuses the existing torb_platform_system_path / torb_platform_utf8 with matching signatures and frees (torb_raw_free with the allocated capacity); falls back to a retained copy on conversion failure; POSIX returns a retained reference. Generated torb_natives.h / machine_natives.c are consistent with the manifest row (sorted position, thunk 98, following thunks renumbered, count 332); the generator-comparison test is green.
• Scope: ok. Exactly step 2b of #68 / #559; nothing in std/, compiler/ logic or tools/ calls it. The signature deviation from the issue (return value instead of out) is explained in the PR body and fits the plain Direct native shape.
• Security/data: ok. No file access, no new dependencies, no secrets.
• Docs: ok. NATIVES.md counts (205 / 562) and PATH.md status updated.
• Release: seed publishing is correctly noted as a precondition for step 2c.

Non-blocking: none.

Checklist for f17e94f: - Tests: ok. POSIX identity test in `runtime/tests/file_test.c` (empty, root, relative, `..`, non-ASCII, backslash); Windows cases in `platform_test.c` under `_WIN32` (short, share, non-ASCII, empty, long `\\?\`, long UNC). CI green for this head (tier A/B, bootstrap, natives/conformance gates). - Correctness: ok. `torb_platform_system_path_text` reuses the existing `torb_platform_system_path` / `torb_platform_utf8` with matching signatures and frees (`torb_raw_free` with the allocated capacity); falls back to a retained copy on conversion failure; POSIX returns a retained reference. Generated `torb_natives.h` / `machine_natives.c` are consistent with the manifest row (sorted position, thunk 98, following thunks renumbered, count 332); the generator-comparison test is green. - Scope: ok. Exactly step 2b of #68 / #559; nothing in `std/`, `compiler/` logic or `tools/` calls it. The signature deviation from the issue (return value instead of `out`) is explained in the PR body and fits the plain `Direct` native shape. - Security/data: ok. No file access, no new dependencies, no secrets. - Docs: ok. `NATIVES.md` counts (205 / 562) and `PATH.md` status updated. - Release: seed publishing is correctly noted as a precondition for step 2c. Non-blocking: none.

argus merged commit 4b3045d313 into main 2026-10-29 00:46:50 +00:00

argus deleted branch loop/559-system-path-native 2026-10-29 00:46:50 +00:00

orion referenced this pull request 2026-10-29 11:52:43 +00:00

fs: Into<Path> signatures (PATH slice 2) #68

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!560

No description provided.