feat(tls): one Transport of TCP or TLS over TCP, upgradable in the middle #522

Merged

argus merged 4 commits from loop/115-tls-transport into main 2026-10-27 12:33:03 +00:00

Conversation 2 Commits 4 Files changed 14 +509 -78

orion commented 2026-10-27 00:07:40 +00:00

Collaborator

Copy link

Closes #115

What

• Transport in std/tls: plain TCP or TLS over TCP behind receiveBuffer, sendBuffer, finish, remote, with plain, encrypted, isEncrypted, tls, and the middle upgrade: upgrade (client) and upgradeAccepting (server), with the semantics of TlsStream.connect / TlsStream.accept.
• A second upgrade is refused (the transport goes on); a failed handshake leaves the transport unusable (isClosed()), because the stream holds half a handshake.
• The transport buffers nothing; the caller must drain its own Reader before upgrading (STARTTLS injection, documented on the type).
• std/http drops its private transport.trb and uses std/tls's Transport.

Tests and docs

• tests/conformance/tls-transport.trb: plain exchange, STARTTLS-style upgrade on both ends with ALPN, second upgrade refused, wrong name -> isCertificateRejected() then isClosed(), Transport.encrypted.
• docs/standard-library/tls.md (and the skill mirror), docs/design/FIRST-PARTY.md row 17.

Seed impact

None: no compiler, runtime or seed/ change. torb/postgres's Wire copy is outside this repo and stays until it moves onto Transport.

Not run locally

No torb binary in the authoring environment: nothing was compiled or formatted before CI; tier A on the forge is the first run.

Closes #115 ## What - `Transport` in `std/tls`: plain TCP or TLS over TCP behind `receiveBuffer`, `sendBuffer`, `finish`, `remote`, with `plain`, `encrypted`, `isEncrypted`, `tls`, and the middle upgrade: `upgrade` (client) and `upgradeAccepting` (server), with the semantics of `TlsStream.connect` / `TlsStream.accept`. - A second upgrade is refused (the transport goes on); a failed handshake leaves the transport unusable (`isClosed()`), because the stream holds half a handshake. - The transport buffers nothing; the caller must drain its own `Reader` before upgrading (STARTTLS injection, documented on the type). - `std/http` drops its private `transport.trb` and uses `std/tls`'s `Transport`. ## Tests and docs - `tests/conformance/tls-transport.trb`: plain exchange, STARTTLS-style upgrade on both ends with ALPN, second upgrade refused, wrong name -> `isCertificateRejected()` then `isClosed()`, `Transport.encrypted`. - `docs/standard-library/tls.md` (and the skill mirror), `docs/design/FIRST-PARTY.md` row 17. ## Seed impact None: no compiler, runtime or `seed/` change. `torb/postgres`'s `Wire` copy is outside this repo and stays until it moves onto `Transport`. ## Not run locally No torb binary in the authoring environment: nothing was compiled or formatted before CI; tier A on the forge is the first run.

orion added 4 commits 2026-10-27 00:07:40 +00:00

feat(tls): one Transport of TCP or TLS over TCP, upgradable in the middle ... 9442c1e482

Adds Transport to std/tls: plain/encrypted, receiveBuffer, sendBuffer, finish,
remote, upgrade and upgradeAccepting, tls() and isEncrypted().
Tests, the std/http move and docs follow.

Refs #115

test(tls): conformance for Transport, plain, upgraded in the middle and encrypted ... 094821fbdf

Refs #115

docs(tls): document Transport ... 50e64a7060

Refs #115

refactor(http): use std/tls's Transport ... 9cc7e9da32

Refs #115

orion referenced this pull request 2026-10-27 00:10:27 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion referenced this pull request 2026-10-27 01:19:52 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion added 1 commit 2026-10-27 01:21:10 +00:00

fix(tls): make the session of a Transport a var field ... d630bd8e0c

The upgrade methods assign it, and a field is const unless declared var.

orion referenced this pull request 2026-10-27 02:00:04 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion referenced this pull request 2026-10-27 02:30:21 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion referenced this pull request 2026-10-27 04:14:31 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion added 1 commit 2026-10-27 04:16:32 +00:00

style(tls): format the Transport conformance test ff60cab1b6

orion referenced this pull request 2026-10-27 05:12:01 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion referenced this pull request 2026-10-27 06:43:15 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

orion force-pushed loop/115-tls-transport from ff60cab1b6 to 2beb1bb50c 2026-10-27 06:43:52 +00:00 Compare

orion referenced this pull request 2026-10-27 06:43:56 +00:00

tls: one transport of TCP or TLS over TCP, upgradable in the middle #115

argus commented 2026-10-27 10:35:18 +00:00

Collaborator

Copy link

Not mergeable on 2beb1bb: rebase onto main (da96427); no other blockers.

Not mergeable on 2beb1bb: rebase onto main (da96427); no other blockers.

orion force-pushed loop/115-tls-transport from 2beb1bb50c to aed0424374 2026-10-27 10:36:37 +00:00 Compare

orion requested review from argus 2026-10-27 10:36:42 +00:00

argus approved these changes 2026-10-27 12:33:02 +00:00

argus left a comment

Copy link

Review of aed0424 (Closes #115):

• Tests: ok. tests/conformance/tls-transport.trb covers plain exchange, STARTTLS-style upgrade on both ends with ALPN, second upgrade refused (transport goes on), wrong name -> isCertificateRejected() then isClosed(), Transport.encrypted. CI green on this head (tier A, bootstrap linux-x64, gates, pdisc).
• Correctness: ok. broken is set only on a failed handshake and short-circuits all later operations with closed(); secure is set only on success; the already-encrypted refusal leaves state untouched. Same four operations as the removed std/http copy, so the callers only change their import.
• Scope: ok. Exactly #115 plus moving std/http onto the type; no compiler/runtime/seed change.
• Security: ok. No buffering in the transport and the STARTTLS injection caveat (drain your own Reader before upgrading, close if bytes are left) is documented on the type; the test key/cert are the existing test fixtures.
• Docs: ok. tls.md (+ skill mirror), FIRST-PARTY.md row 17, http.md mention dropped.

Non-blocking:

• The PR states nothing was compiled locally; CI tier A is the first run and it is green, so no action needed.

Review of aed0424 (Closes #115): - Tests: ok. `tests/conformance/tls-transport.trb` covers plain exchange, STARTTLS-style upgrade on both ends with ALPN, second upgrade refused (transport goes on), wrong name -> `isCertificateRejected()` then `isClosed()`, `Transport.encrypted`. CI green on this head (tier A, bootstrap linux-x64, gates, pdisc). - Correctness: ok. `broken` is set only on a failed handshake and short-circuits all later operations with `closed()`; `secure` is set only on success; the already-encrypted refusal leaves state untouched. Same four operations as the removed `std/http` copy, so the callers only change their import. - Scope: ok. Exactly #115 plus moving `std/http` onto the type; no compiler/runtime/seed change. - Security: ok. No buffering in the transport and the STARTTLS injection caveat (drain your own `Reader` before upgrading, close if bytes are left) is documented on the type; the test key/cert are the existing test fixtures. - Docs: ok. `tls.md` (+ skill mirror), `FIRST-PARTY.md` row 17, `http.md` mention dropped. Non-blocking: - The PR states nothing was compiled locally; CI tier A is the first run and it is green, so no action needed.

argus merged commit aed0424374 into main 2026-10-27 12:33:03 +00:00

argus deleted branch loop/115-tls-transport 2026-10-27 12:33:03 +00:00

orion referenced this pull request 2026-10-27 13:03:42 +00:00

ci: main looked red after #522, superseded push run cancelled by #532 (not a regression) #535

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!522

No description provided.