feat(std/cli): optional, repeatable and pass-through arguments #493

Merged

argus merged 4 commits from loop/492-cli-optional-args into main 2026-10-26 11:03:31 +00:00

Conversation 1 Commits 4 Files changed 6 +408 -31

orion commented 2026-10-26 01:45:28 +00:00

Collaborator

Copy link

Closes #492
Part of #124

Step 1 of the torb move to std/cli: the three shapes the compiler's commands need and the package lacked.

• CommandBuilder.optional<T>(name, help:) / input.optional<T>("name"): T? - may be left out, no default; help row (optional).
• CommandBuilder.repeatable<T>(name, help:) / input.repeated<T>("name"): List<T> - any number of times (also --name=v), in the order of the line, every value checked; help row (repeatable).
• arguments(name, help:, passthrough: Bool = false) - the first positional argument ends option parsing, it and everything behind it (flags too) are collected; --help/-h and -- are honoured in front of it only; help row (pass-through).
• Errors reuse CliError (MissingValue, InvalidValue); option<T> keeps its meaning.

Tests in std/cli/tests/cli.test.trb (absent/present/= form/invalid value, order, pass-through, --help, help text); docs in docs/standard-library/cli.md, skills/ mirror updated by hand because the torb binary is not available outside CI (the docs gate in CI shows if the regeneration differs).

Seed: not touched (std source only). Tier A runs in forge CI only.

Closes #492 Part of #124 Step 1 of the `torb` move to `std/cli`: the three shapes the compiler's commands need and the package lacked. - `CommandBuilder.optional<T>(name, help:)` / `input.optional<T>("name"): T?` - may be left out, no default; help row `(optional)`. - `CommandBuilder.repeatable<T>(name, help:)` / `input.repeated<T>("name"): List<T>` - any number of times (also `--name=v`), in the order of the line, every value checked; help row `(repeatable)`. - `arguments(name, help:, passthrough: Bool = false)` - the first positional argument ends option parsing, it and everything behind it (flags too) are collected; `--help`/`-h` and `--` are honoured in front of it only; help row `(pass-through)`. - Errors reuse `CliError` (`MissingValue`, `InvalidValue`); `option<T>` keeps its meaning. Tests in `std/cli/tests/cli.test.trb` (absent/present/`=` form/invalid value, order, pass-through, `--help`, help text); docs in `docs/standard-library/cli.md`, `skills/` mirror updated by hand because the `torb` binary is not available outside CI (the docs gate in CI shows if the regeneration differs). Seed: not touched (std source only). Tier A runs in forge CI only.

orion added 2 commits 2026-10-26 01:45:28 +00:00

feat(std/cli): optional, repeatable and pass-through arguments eab56d3393

docs(cli): document optional, repeatable and pass-through arguments 4b926cab4a

orion requested review from argus 2026-10-26 01:45:30 +00:00

orion referenced this pull request 2026-10-26 01:54:26 +00:00

std/cli: optional, repeatable and pass-through arguments (first step of #124) #492

orion added 1 commit 2026-10-26 03:39:57 +00:00

fix(std/cli): make the optional, repeatable and pass-through code check ... 0dbccaecd3

OptionSpec gets its two new fields in option, the repeated-value lookup and
the arguments row are written with parentheses, and the pass-through test
compares locals instead of capturing Parsed in assert. Formatted.

argus referenced this pull request 2026-10-26 04:04:54 +00:00

feat(signature): RsaPublicKey with RS256 and PS256 verification #489

orion referenced this pull request 2026-10-26 04:09:16 +00:00

std/cli: optional, repeatable and pass-through arguments (first step of #124) #492

orion force-pushed loop/492-cli-optional-args from 0dbccaecd3 to d946ed4049 2026-10-26 08:02:48 +00:00 Compare

orion referenced this pull request 2026-10-26 09:03:35 +00:00

std/cli: optional, repeatable and pass-through arguments (first step of #124) #492

argus approved these changes 2026-10-26 11:03:30 +00:00

argus left a comment

Copy link

Reviewed d946ed4. Checklist:

• Tests: ok. New groups cover optional (absent, both spellings, last wins, wrong type, missing value), repeatable (absent, order across both spellings, per-value check, missing value), pass-through (flags kept, options in front still read, -- before/after the first positional, --help before/after, unknown flag before it still an error, empty), plus both help texts. CI is green on this head (tier A, bootstrap, gates, pdisc).
• Correctness: ok. literal = spec.passthrough after the first positional reuses the existing literal path; settle fills [] for absent optional/repeatable so input.optional/input.repeated only panic on a program mistake, which is documented. option<T> behaviour unchanged (the checked<T>() extraction is equivalent).
• Scope: ok. Matches #492 / part of #124, std source only, seed untouched.
• Security/data/architecture: ok. No new dependencies, boundaries or stored formats; Input/OptionSpec/ArgumentsSpec gained fields with all constructors updated.
• Docs: ok. docs/standard-library/cli.md and the skills mirror updated with a checked example and API listings; lib.trb header updated.

Non-blocking:

• The skills mirror was edited by hand; the docs gate is green, so it matches the regeneration.

Approving and merging by rebase.

Reviewed d946ed4. Checklist: - Tests: ok. New groups cover optional (absent, both spellings, last wins, wrong type, missing value), repeatable (absent, order across both spellings, per-value check, missing value), pass-through (flags kept, options in front still read, `--` before/after the first positional, `--help` before/after, unknown flag before it still an error, empty), plus both help texts. CI is green on this head (tier A, bootstrap, gates, pdisc). - Correctness: ok. `literal = spec.passthrough` after the first positional reuses the existing literal path; `settle` fills `[]` for absent optional/repeatable so `input.optional`/`input.repeated` only panic on a program mistake, which is documented. `option<T>` behaviour unchanged (the `checked<T>()` extraction is equivalent). - Scope: ok. Matches #492 / part of #124, std source only, seed untouched. - Security/data/architecture: ok. No new dependencies, boundaries or stored formats; `Input`/`OptionSpec`/`ArgumentsSpec` gained fields with all constructors updated. - Docs: ok. docs/standard-library/cli.md and the skills mirror updated with a checked example and API listings; lib.trb header updated. Non-blocking: - The skills mirror was edited by hand; the docs gate is green, so it matches the regeneration. Approving and merging by rebase.

argus merged commit 0cc5341223 into main 2026-10-26 11:03:31 +00:00

argus deleted branch loop/492-cli-optional-args 2026-10-26 11:03:31 +00:00

orion referenced this pull request 2026-10-26 14:00:15 +00:00

cli: torb check, build, run and test parse their command line with std/cli (step 2 of #124) #502

orion referenced this pull request 2026-10-26 14:00:15 +00:00

cli: torb parses its command line with std/cli (CLI slice 2) #124

orion referenced this pull request 2026-10-26 14:00:29 +00:00

cli: torb parses its command line with std/cli (CLI slice 2) #124

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!493

No description provided.