torbscript/language
Watch
1
0
Fork
You've already forked language
 0
Code Issues 139 Pull requests 2 Projects Releases 18 Packages 3 Wiki Activity Actions

build: --explain-copies hint line for nested writes (take out, put back) #302

New issue
Closed
opened 2026-10-10 02:07:23 +00:00 by orion · 3 comments
orion commented 2026-10-10 02:07:23 +00:00
Collaborator
Copy link

Context

torb build --explain-copies (#61) reports each copy the compiler can prove, with its source span and the reason. PERFORMANCE.md section 6 also shows a second = line that says how to avoid the copy (take the row out and put it back, removeAt ... insert). #61 deliberately ships without it.

Acceptance criteria

  • For a copy of a nested write (a[i][j] = ... where a[i] is shared), the --explain-copies note gains the second = line from PERFORMANCE.md section 6 naming the take-out / put-back rewrite with the user's own variable names.
  • The hint appears only when the rewrite is valid for the written container type (a list or map owner); other reasons keep the single reason line.
  • A test in compiler/tests/ pins the full text of one note with the hint and one without.
  • docs/tooling/torb-build.md shows the extended note.

Dependencies

  • Blocked by #61 (the flag, the report and the note format).

Seed impact

None: the flag is not used by the compiler's own build (tools/bootstrap.sh passes only build ./compiler --output), so one commit.

## Context `torb build --explain-copies` (#61) reports each copy the compiler can prove, with its source span and the reason. [PERFORMANCE.md section 6](https://git.torb.dev/torbscript/language/src/branch/main/docs/PERFORMANCE.md) also shows a second `= ` line that says how to avoid the copy (take the row out and put it back, `removeAt` ... `insert`). #61 deliberately ships without it. ## Acceptance criteria - [ ] For a copy of a nested write (`a[i][j] = ...` where `a[i]` is shared), the `--explain-copies` note gains the second `= ` line from PERFORMANCE.md section 6 naming the take-out / put-back rewrite with the user's own variable names. - [ ] The hint appears only when the rewrite is valid for the written container type (a list or map owner); other reasons keep the single reason line. - [ ] A test in `compiler/tests/` pins the full text of one note with the hint and one without. - [ ] `docs/tooling/torb-build.md` shows the extended note. ## Dependencies - Blocked by #61 (the flag, the report and the note format). ## Seed impact None: the flag is not used by the compiler's own build (`tools/bootstrap.sh` passes only `build ./compiler --output`), so one commit.
orion commented 2026-10-20 22:00:44 +00:00
Author
Collaborator
Copy link

[loop:torbscript] intake: in scope, no duplicate, dependencies closed (#61 / #111), definition of ready met (goal, acceptance criteria, design, no seed impact). Set ready. next: implement

[loop:torbscript] intake: in scope, no duplicate, dependencies closed (#61 / #111), definition of ready met (goal, acceptance criteria, design, no seed impact). Set `ready`. next: implement
orion commented 2026-10-20 22:00:44 +00:00
Author
Collaborator
Copy link

[loop:torbscript] claim implement by session:loop-torbscript-20261021 until 2026-10-21T04:00:43Z

[loop:torbscript] claim implement by session:loop-torbscript-20261021 until 2026-10-21T04:00:43Z
orion commented 2026-10-20 22:32:04 +00:00
Author
Collaborator
Copy link

[loop:torbscript] implement: PR #394 opened from loop/302-explain-copies-hint (one Conventional Commit, Closes #302). A note for a write into an element of a list a variable holds now gets the second = line with the take-out / put-back rewrite in the program's own names; fields, deeper paths and arrays keep the single reason line. Tests pin one note with and one without the hint; torb-build.md, PERFORMANCE.md section 6 and the generated skills copy show it. Forge CI green on 917f6bd0 (tier A and B, gates, commit messages; the first push failed only format --check, fixed by writing one call as a command). Map owners: the analysis reports no nested map writes today, so there is nothing to hint at. Worker usage: about 0.1M tokens (Sonnet), next: review

[loop:torbscript] implement: PR https://git.torb.dev/torbscript/language/pulls/394 opened from `loop/302-explain-copies-hint` (one Conventional Commit, `Closes #302`). A note for a write into an element of a list a variable holds now gets the second `=` line with the take-out / put-back rewrite in the program's own names; fields, deeper paths and arrays keep the single reason line. Tests pin one note with and one without the hint; torb-build.md, PERFORMANCE.md section 6 and the generated skills copy show it. Forge CI green on 917f6bd0 (tier A and B, gates, commit messages; the first push failed only `format --check`, fixed by writing one call as a command). Map owners: the analysis reports no nested map writes today, so there is nothing to hint at. Worker usage: about 0.1M tokens (Sonnet), next: review
argus closed this issue 2026-10-20 22:32:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
loop/705-default-shadow
loop/691-tensor-core
loop/705-fix-candidate
orion/456-tierb-probe
loop/164-measure2
loop/207-measure
loop/164-prototype
probe/207-count
loop/205-measure
loop/140-hide-staged
nightly-20261103
nightly-20261031
nightly-20261029
nightly-20261027
nightly-20261026
nightly-20261025
nightly-20261024
nightly-20261023
nightly-20261021
nightly-20261020
nightly-20261015
nightly-20261014
nightly-20261013
nightly-20261011
nightly-20261010
nightly-20261009
nightly-20261008
seeds
Labels
Clear labels   
loop
Backlog item of the project loop (Orion), see CONTRIBUTING

  
ready
Refined to the definition of ready

No labels
loop
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torbscript/language#302
No description provided.