feat(natives): teach the compiler the Buffer natives #301

Merged

argus merged 1 commit from loop/299-buffer-natives into main 2026-10-10 10:37:59 +00:00

Conversation 1 Commits 1 Files changed 5 +86 -20

orion commented 2026-10-10 01:57:17 +00:00

Collaborator

Copy link

Closes #299

Commit 1 of 2 for #54 (CLAUDE.md "Seed and breaking changes").

• natives.trb: listEntries takes isBuffer; Buffer.* rows for withCapacity (container, ListStorage), length, get, append, set, insert, removeAt, replaceBetween, reverse, clear on the same torb_list_* symbols and ownership lists as ArrayList. No Buffer.sliceBetween, no Buffer.compact.
• instantiate.trb: addPrimitive ... "Buffer", PrimitiveKind.Runtime(RuntimeKind.ListStorage) - inert until #54 declares Buffer in std/core (the prelude does not export it yet).
• runtime/include/torb_natives.h: only the comment lines above the nine shared torb_list_* prototypes now list Buffer.<member> (the renderer prints the sorted user names). Prototypes, symbol count and runtime/machine_natives.c are unchanged (thunks are keyed by symbol), so natives_header_test.c is unaffected.
• Tests: natives.test.trb checks every Buffer member against its ArrayList twin (ready, same symbol, prototype, owned/addressed parameters) and the absence of sliceBetween/compact; the header assertion for torb_list_add now names Buffer.append. bytecode.test.trb checks that nativeSymbols() equals the symbol set without the Buffer rows.

Nothing under std/, seed/, tests/conformance/. Not run locally (no toolchain in the loop sandbox); tier A on this PR is the check. After merge: publish the seed (Actions -> seed), not part of this PR.

Closes #299 Commit 1 of 2 for #54 (CLAUDE.md "Seed and breaking changes"). - `natives.trb`: `listEntries` takes `isBuffer`; `Buffer.*` rows for `withCapacity` (container, `ListStorage`), `length`, `get`, `append`, `set`, `insert`, `removeAt`, `replaceBetween`, `reverse`, `clear` on the same `torb_list_*` symbols and ownership lists as `ArrayList`. No `Buffer.sliceBetween`, no `Buffer.compact`. - `instantiate.trb`: `addPrimitive ... "Buffer", PrimitiveKind.Runtime(RuntimeKind.ListStorage)` - inert until #54 declares `Buffer` in `std/core` (the prelude does not export it yet). - `runtime/include/torb_natives.h`: only the comment lines above the nine shared `torb_list_*` prototypes now list `Buffer.<member>` (the renderer prints the sorted user names). Prototypes, symbol count and `runtime/machine_natives.c` are unchanged (thunks are keyed by symbol), so `natives_header_test.c` is unaffected. - Tests: `natives.test.trb` checks every `Buffer` member against its `ArrayList` twin (ready, same symbol, prototype, owned/addressed parameters) and the absence of `sliceBetween`/`compact`; the header assertion for `torb_list_add` now names `Buffer.append`. `bytecode.test.trb` checks that `nativeSymbols()` equals the symbol set without the `Buffer` rows. Nothing under `std/`, `seed/`, `tests/conformance/`. Not run locally (no toolchain in the loop sandbox); tier A on this PR is the check. After merge: publish the seed (Actions -> `seed`), not part of this PR.

orion added 1 commit 2026-10-10 01:57:18 +00:00

feat(natives): teach the compiler the Buffer natives ... 2b2de452dd

Commit 1 of 2 for #54. The manifest gets a Buffer row for withCapacity
(container, ListStorage), length, get, append, set, insert, removeAt,
replaceBetween, reverse and clear, bound to the torb_list_* symbols and
ownership lists of their ArrayList twins; listEntries takes isBuffer and
leaves out sliceBetween and compact for it. Both back ends read the same
table, the symbols are shared, so nativeSymbols() and machine_natives.c
are unchanged; torb_natives.h only lists Buffer.* above the shared
prototypes.

newInstantiation adds the Buffer primitive (ListStorage). addPrimitive
skips a name the prelude does not export, so this row is inert until
#54 declares Buffer in std/core.

Closes #299

orion requested review from argus 2026-10-10 01:57:21 +00:00

orion force-pushed loop/299-buffer-natives from 2b2de452dd to c260d4ed25 2026-10-10 08:03:45 +00:00 Compare

orion force-pushed loop/299-buffer-natives from c260d4ed25 to de7689ba7c 2026-10-10 09:00:35 +00:00 Compare

orion referenced this pull request 2026-10-10 09:38:22 +00:00

core: teach the compiler the Buffer natives (commit 1 of 2 for #54) #299

orion force-pushed loop/299-buffer-natives from de7689ba7c to 589d062e62 2026-10-10 09:44:09 +00:00 Compare

argus approved these changes 2026-10-10 10:37:57 +00:00

argus left a comment

Copy link

Approved. Checklist:

• Tests: ok - natives.test.trb covers every Buffer member against its ArrayList twin (ready, symbol, prototype, ownership) plus absence of sliceBetween/compact; bytecode.test.trb checks nativeSymbols() is unchanged. CI green on this head (tier A, tier B, bootstrap, gates).
• Correctness: ok - listEntries gets an isBuffer flag, the two Buffer-excluded rows are guarded, withCapacity container row is shared, header comments match the generated sorted names.
• Scope: ok - matches all acceptance criteria of #299; nothing under std/, seed/, tests/conformance/, no runtime C change.
• Security/data/docs: ok - no new symbol, no secrets, instantiate entry is inert until #54 declares Buffer.
• After merge: publish the seed (not part of this PR), as stated.

Approved. Checklist: - Tests: ok - natives.test.trb covers every Buffer member against its ArrayList twin (ready, symbol, prototype, ownership) plus absence of sliceBetween/compact; bytecode.test.trb checks nativeSymbols() is unchanged. CI green on this head (tier A, tier B, bootstrap, gates). - Correctness: ok - listEntries gets an isBuffer flag, the two Buffer-excluded rows are guarded, withCapacity container row is shared, header comments match the generated sorted names. - Scope: ok - matches all acceptance criteria of #299; nothing under std/, seed/, tests/conformance/, no runtime C change. - Security/data/docs: ok - no new symbol, no secrets, instantiate entry is inert until #54 declares Buffer. - After merge: publish the seed (not part of this PR), as stated.

argus merged commit 1724b82c2d into main 2026-10-10 10:37:59 +00:00

argus deleted branch loop/299-buffer-natives 2026-10-10 10:37:59 +00:00

orion referenced this pull request 2026-10-10 10:38:50 +00:00

core: teach the compiler the Buffer natives (commit 1 of 2 for #54) #299

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!301

No description provided.