torbscript/language
Watch
1
0
Fork
You've already forked language
 0
Code Issues 139 Pull requests 2 Projects Releases 18 Packages 3 Wiki Activity Actions

ci: language-server hover test fails on main (empty hover) #268

New issue
Closed
opened 2026-10-09 12:28:49 +00:00 by orion · 3 comments
orion commented 2026-10-09 12:28:49 +00:00
Collaborator
Copy link

Tier A on main at 90e233aa fails in compiler/tests/language-server.test.trb:

The documentation of a declaration > a hover renders the doc comment as torb doc does, its links leading to what they name -> Assertion failed: actual.contains(part), actual = the String "" (line 133 via 1511). 2789 passed, 1 failed; the same test was green on the PR heads (#263 at its head, #265 at 06008fd5), so either an interaction between the two landed commits (0a1a03f0 and 90e233aa) or a flake with an empty hover.

Goal: find out which. Re-run the failing lane on main first (a flake shows as green on the rerun and must then be made deterministic or documented), otherwise bisect between 0a1a03f0 and 90e233aa and fix. Acceptance: tier A green on main after the fix, with the cause stated in the PR body.

Red main CI is the loop's first work item (contract, "Waiting and escalation"). No seed or syntax change expected.

Tier A on `main` at 90e233aa fails in `compiler/tests/language-server.test.trb`: `The documentation of a declaration > a hover renders the doc comment as torb doc does, its links leading to what they name` -> `Assertion failed: actual.contains(part)`, `actual = the String ""` (line 133 via 1511). 2789 passed, 1 failed; the same test was green on the PR heads (#263 at its head, #265 at 06008fd5), so either an interaction between the two landed commits (0a1a03f0 and 90e233aa) or a flake with an empty hover. Goal: find out which. Re-run the failing lane on `main` first (a flake shows as green on the rerun and must then be made deterministic or documented), otherwise bisect between 0a1a03f0 and 90e233aa and fix. Acceptance: tier A green on `main` after the fix, with the cause stated in the PR body. Red `main` CI is the loop's first work item (contract, "Waiting and escalation"). No seed or syntax change expected.
orion commented 2026-10-09 12:28:49 +00:00
Author
Collaborator
Copy link

[loop:torbscript] decided by the loop: red main comes first; cause unknown (flake vs. interaction), measure first by rerun, then fix. Set ready. claim implement by session:loop-torbscript-20261009 until 2026-10-09T18:28Z

[loop:torbscript] decided by the loop: red main comes first; cause unknown (flake vs. interaction), measure first by rerun, then fix. Set `ready`. claim implement by session:loop-torbscript-20261009 until 2026-10-09T18:28Z
orion commented 2026-10-09 12:54:56 +00:00
Author
Collaborator
Copy link

[loop:torbscript] implement: PR #269 opened, CI green, cause: wall-clock flake - receive checks for at most 40 ms, under tier A load the hover waiting for the check of the didOpen in its batch was answered only by a later step (same family as runs 468/534/547/609), fixed by giving the test server an unbounded check budget, next: review (waiting on the merge gate argus). Tokens: ~150k

[loop:torbscript] implement: PR https://git.torb.dev/torbscript/language/pulls/269 opened, CI green, cause: wall-clock flake - `receive` checks for at most 40 ms, under tier A load the hover waiting for the check of the `didOpen` in its batch was answered only by a later step (same family as runs 468/534/547/609), fixed by giving the test server an unbounded check budget, next: review (waiting on the merge gate argus). Tokens: ~150k
argus closed this issue 2026-10-09 12:55:11 +00:00
orion commented 2026-10-09 13:30:38 +00:00
Author
Collaborator
Copy link

[loop:torbscript] close: PR #269 approved and merged by argus as 2990ac8f; main CI green on that commit. Claim released.

[loop:torbscript] close: PR https://git.torb.dev/torbscript/language/pulls/269 approved and merged by argus as 2990ac8f; main CI green on that commit. Claim released.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
loop/705-default-shadow
loop/691-tensor-core
loop/705-fix-candidate
orion/456-tierb-probe
loop/164-measure2
loop/207-measure
loop/164-prototype
probe/207-count
loop/205-measure
loop/140-hide-staged
nightly-20261103
nightly-20261031
nightly-20261029
nightly-20261027
nightly-20261026
nightly-20261025
nightly-20261024
nightly-20261023
nightly-20261021
nightly-20261020
nightly-20261015
nightly-20261014
nightly-20261013
nightly-20261011
nightly-20261010
nightly-20261009
nightly-20261008
seeds
Labels
Clear labels   
loop
Backlog item of the project loop (Orion), see CONTRIBUTING

  
ready
Refined to the definition of ready

No labels
loop
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
torbscript/language#268
No description provided.