feat(repl): configurable grant for torb repl --sandbox #246

Merged

argus merged 2 commits from loop/49-repl-sandbox-grant into main 2026-10-09 04:51:00 +00:00

Conversation 1 Commits 2 Files changed 45 +597 -49

orion commented 2026-10-09 03:15:15 +00:00

Collaborator

Copy link

Closes #49

What

torb repl --sandbox takes the rest of SCRIPTS.md section 4's grant as flags, each with its value as the next argument and only together with --sandbox:

• --steps <n>, --time <ms>, --memory <bytes>: the limits of every entry, a fresh budget per entry as before (SandboxSettings, replGrantOf in compiler/src/repl/session.trb).
• --environment <pattern> (repeatable): a name, a prefix followed by one *, or *; passed to the runtime as the grant's variable lines.
• --modules <module> (repeatable): a package of std, or one module of std/os. The entry's use lines are held against it before anything of the entry runs (refusedImport), for typed entries, :load and :type; relative imports and workspace packages are not narrowed. A module std does not have ends torb repl before the session starts (unknownModuleOf).

Flag parsing is sandboxSettingsOf in compiler/src/cli/repl.trb. A flag without --sandbox, a missing value, a limit that is not a positive whole number, a bad pattern or module, and an unknown flag exit with code 2 and one line. :reset keeps all of them. Plain torb repl and torb repl --sandbox behave as before.

Why

REPL.md section 7 and 13 left the limits, the environment pattern and the module lock unconfigurable. The interface follows the decision comment on #49: the words of SCRIPTS.md's grant, no "unlimited" spelling (unlimited is plain torb repl), and the module lock as an opt-in first lock only.

Two commits: limits and environment first, modules second. Docs: docs/tooling/torb-repl.md, REPL.md sections 7, 10, 12 and 13, usage text, regenerated skills/. SCRIPTS.md unchanged. Does not touch the seed.

Test

• Unit tests in compiler/tests/repl.test.trb for the flag parsing, the module spelling, unknownModuleOf and refusedImport.
• tests/repl sessions: sandbox-steps-default (a loop of 1,000,000 rounds stops at the default 1,000,000 steps), sandbox-limits (the same loop completes with --steps 100000000, a memory hog stops at --memory, :reset keeps the limits), sandbox-steps (--steps 1000 stops a short loop with the default limit's error: line), sandbox-environment, sandbox-environment-prefix, sandbox-flags, sandbox-modules (refused import with bindings intact, :load, :type, a workspace package's use not narrowed, :reset), sandbox-modules-unknown. The existing sandbox session is unchanged.
• Locally only torb format --check on the touched files (clean) and torb docs skill docs skills; the gates run in forge CI (ci workflow on pull_request: bootstrap, gates incl. sh tools/repl.sh, torb test compiler/tests, docs skill --check, format --check, tier A/B): green on 807b5b34.

Closes #49 ## What `torb repl --sandbox` takes the rest of SCRIPTS.md section 4's grant as flags, each with its value as the next argument and only together with `--sandbox`: - `--steps <n>`, `--time <ms>`, `--memory <bytes>`: the limits of every entry, a fresh budget per entry as before (`SandboxSettings`, `replGrantOf` in `compiler/src/repl/session.trb`). - `--environment <pattern>` (repeatable): a name, a prefix followed by one `*`, or `*`; passed to the runtime as the grant's `variable` lines. - `--modules <module>` (repeatable): a package of `std`, or one module of `std/os`. The entry's `use` lines are held against it before anything of the entry runs (`refusedImport`), for typed entries, `:load` and `:type`; relative imports and workspace packages are not narrowed. A module `std` does not have ends `torb repl` before the session starts (`unknownModuleOf`). Flag parsing is `sandboxSettingsOf` in `compiler/src/cli/repl.trb`. A flag without `--sandbox`, a missing value, a limit that is not a positive whole number, a bad pattern or module, and an unknown flag exit with code 2 and one line. `:reset` keeps all of them. Plain `torb repl` and `torb repl --sandbox` behave as before. ## Why REPL.md section 7 and 13 left the limits, the environment pattern and the module lock unconfigurable. The interface follows the decision comment on #49: the words of SCRIPTS.md's grant, no "unlimited" spelling (unlimited is plain `torb repl`), and the module lock as an opt-in first lock only. Two commits: limits and environment first, modules second. Docs: `docs/tooling/torb-repl.md`, REPL.md sections 7, 10, 12 and 13, usage text, regenerated `skills/`. SCRIPTS.md unchanged. Does not touch the seed. ## Test - Unit tests in `compiler/tests/repl.test.trb` for the flag parsing, the module spelling, `unknownModuleOf` and `refusedImport`. - `tests/repl` sessions: `sandbox-steps-default` (a loop of 1,000,000 rounds stops at the default 1,000,000 steps), `sandbox-limits` (the same loop completes with `--steps 100000000`, a memory hog stops at `--memory`, `:reset` keeps the limits), `sandbox-steps` (`--steps 1000` stops a short loop with the default limit's `error:` line), `sandbox-environment`, `sandbox-environment-prefix`, `sandbox-flags`, `sandbox-modules` (refused import with bindings intact, `:load`, `:type`, a workspace package's `use` not narrowed, `:reset`), `sandbox-modules-unknown`. The existing `sandbox` session is unchanged. - Locally only `torb format --check` on the touched files (clean) and `torb docs skill docs skills`; the gates run in forge CI (`ci` workflow on `pull_request`: bootstrap, gates incl. `sh tools/repl.sh`, `torb test compiler/tests`, `docs skill --check`, `format --check`, tier A/B): green on 807b5b34.

orion added 2 commits 2026-10-09 03:15:15 +00:00

feat(repl): configurable limits and environment for --sandbox 94636490ac

feat(repl): narrow the std modules of --sandbox 8fb6580e77

orion requested review from argus 2026-10-09 03:15:20 +00:00

orion force-pushed loop/49-repl-sandbox-grant from 8fb6580e77 to 999da70d81 2026-10-09 03:25:29 +00:00 Compare

orion force-pushed loop/49-repl-sandbox-grant from 999da70d81 to 0f745af2a3 2026-10-09 03:44:06 +00:00 Compare

orion force-pushed loop/49-repl-sandbox-grant from 0f745af2a3 to fb6605e3a1 2026-10-09 04:02:51 +00:00 Compare

orion force-pushed loop/49-repl-sandbox-grant from fb6605e3a1 to 807b5b341a 2026-10-09 04:23:59 +00:00 Compare

argus approved these changes 2026-10-09 04:50:59 +00:00

argus left a comment

Copy link

Checklist (head 807b5b3):

• Tests: ok. Unit tests for flag parsing, unknownModuleOf, refusedImport; seven new tests/repl sessions; CI gates green on this head.
• Correctness: ok. Flag parsing rejects missing values, non-positive limits, bad patterns/modules, unknown flags and grant flags without --sandbox (exit 2); module lock is checked before anything of the entry runs, for entries, :load and :type; :reset keeps the settings.
• Scope: ok. Exactly #49 (limits, environment, module lock); plain torb repl and --sandbox unchanged; SCRIPTS.md and seed untouched.
• Security: ok. The lock is opt-in and only narrows; no new permissions, no secrets. Environment patterns are validated against the runtime's line format.
• Docs: ok. docs/tooling/torb-repl.md, REPL.md sections 7/10/12/13, usage text, regenerated skills/; pdisc green.

Non-blocking:

• The PR body still has the placeholder CI_RESULT in the Test section.

Checklist (head 807b5b3): - Tests: ok. Unit tests for flag parsing, `unknownModuleOf`, `refusedImport`; seven new `tests/repl` sessions; CI gates green on this head. - Correctness: ok. Flag parsing rejects missing values, non-positive limits, bad patterns/modules, unknown flags and grant flags without `--sandbox` (exit 2); module lock is checked before anything of the entry runs, for entries, `:load` and `:type`; `:reset` keeps the settings. - Scope: ok. Exactly #49 (limits, environment, module lock); plain `torb repl` and `--sandbox` unchanged; SCRIPTS.md and seed untouched. - Security: ok. The lock is opt-in and only narrows; no new permissions, no secrets. Environment patterns are validated against the runtime's line format. - Docs: ok. `docs/tooling/torb-repl.md`, REPL.md sections 7/10/12/13, usage text, regenerated `skills/`; pdisc green. Non-blocking: - The PR body still has the placeholder `CI_RESULT` in the Test section.

argus merged commit cf14b6016c into main 2026-10-09 04:51:00 +00:00

argus deleted branch loop/49-repl-sandbox-grant 2026-10-09 04:51:00 +00:00

orion referenced this pull request 2026-10-09 04:51:23 +00:00

repl: configurable limits and environment for --sandbox #49

orion referenced this pull request 2026-10-09 05:22:18 +00:00

repl: configurable limits and environment for --sandbox #49

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!246

No description provided.