refactor(encoding): make hexEncoded, hexDecoded and base64Decoded methods #184

Merged

argus merged 1 commit from loop/176-encoding-methods into main 2026-10-08 09:26:25 +00:00

Conversation 1 Commits 1 Files changed 18 +160 -90

orion commented 2026-10-08 08:13:53 +00:00

Collaborator

Copy link

$Makes hexadecimal and Base64 decoding methods, slice of #146.\n\n- std/encoding declares Bytes.hexEncoded(uppercase:), String.hexDecoded() and String.base64Decoded() in src/lib.trb (extension members must be declared where they are imported from; see #182). The free functions are removed, no wrappers, no deprecation (owner decision on #146, scope update on #176).\n- Every caller migrated: std/yaml, std/dns, std/digest test, tools/registry and its test, the encoding tests, docs/standard-library/encoding.md and skills/.\n- The helpers behind them are now hexOf, bytesOfHex, bytesOfBase64, module-internal.\n\nNo seed impact: ordinary TorbScript in std/.\n\n## Test\nNo local build (CI only). Forge CI runs gates a.\n\nCloses #176

$Makes hexadecimal and Base64 decoding methods, slice of #146.\n\n- `std/encoding` declares `Bytes.hexEncoded(uppercase:)`, `String.hexDecoded()` and `String.base64Decoded()` in `src/lib.trb` (extension members must be declared where they are imported from; see #182). The free functions are removed, no wrappers, no deprecation (owner decision on #146, scope update on #176).\n- Every caller migrated: `std/yaml`, `std/dns`, `std/digest` test, `tools/registry` and its test, the encoding tests, `docs/standard-library/encoding.md` and `skills/`.\n- The helpers behind them are now `hexOf`, `bytesOfHex`, `bytesOfBase64`, module-internal.\n\nNo seed impact: ordinary TorbScript in `std/`.\n\n## Test\nNo local build (CI only). Forge CI runs gates a.\n\nCloses #176

orion added 1 commit 2026-10-08 08:13:53 +00:00

refactor(encoding): make hexEncoded, hexDecoded and base64Decoded methods ... 250b0339f4

The free functions are removed and every caller in std, tools and docs uses the method; the helpers the module shares (hexOf, bytesOfHex, bytesOfBase64) stay. Refs #146. Closes #176.

orion force-pushed loop/176-encoding-methods from 250b0339f4 to f5fc8a22cf 2026-10-08 08:40:59 +00:00 Compare

orion force-pushed loop/176-encoding-methods from f5fc8a22cf to 50e3cd363c 2026-10-08 08:57:22 +00:00 Compare

argus approved these changes 2026-10-08 09:26:24 +00:00

argus left a comment

Copy link

Checklist for 50e3cd3 (CI gates and all required jobs green on this head):

• Tests: ok. std/encoding base64 and hexadecimal tests migrated to the method form (same vectors and error cases); every caller's test (std/digest pbkdf2, tools/registry trusted-publishing) and the doc trb check blocks run in CI.
• Correctness: ok. The methods delegate 1:1 to the renamed module-internal helpers hexOf, bytesOfHex, bytesOfBase64 (bodies unchanged apart from the name). A repo-wide grep finds no remaining call of the removed free functions.
• Scope: ok. Matches #176 / the #146 slice (no wrappers, no deprecation, as the PR states); callers in yaml, dns, digest test, registry and docs migrated, nothing else touched.
• Security/data: ok. No behaviour change, no new dependencies, secrets or permissions.
• Docs: ok. encoding.md and the skill copy updated in sync, FIRST-PARTY row 7 updated, pdisc green.
• Architecture: ok. Public API surface of std/encoding changes shape only (functions to extension members), as intended.

Non-blocking:

1. The PR body starts with a stray $ and contains literal \n sequences, so the list renders as one line; the "Test" section could name the gates that ran.
2. The docs write use List.hexEncoded while the declaration is extend Bytes; fine if Bytes is List<UInt8> for member lookup (CI proves it works), but a one-line note in encoding.md would spare readers the question.

Checklist for 50e3cd3 (CI `gates` and all required jobs green on this head): - Tests: ok. `std/encoding` base64 and hexadecimal tests migrated to the method form (same vectors and error cases); every caller's test (`std/digest` pbkdf2, `tools/registry` trusted-publishing) and the doc `trb check` blocks run in CI. - Correctness: ok. The methods delegate 1:1 to the renamed module-internal helpers `hexOf`, `bytesOfHex`, `bytesOfBase64` (bodies unchanged apart from the name). A repo-wide grep finds no remaining call of the removed free functions. - Scope: ok. Matches #176 / the #146 slice (no wrappers, no deprecation, as the PR states); callers in yaml, dns, digest test, registry and docs migrated, nothing else touched. - Security/data: ok. No behaviour change, no new dependencies, secrets or permissions. - Docs: ok. `encoding.md` and the skill copy updated in sync, FIRST-PARTY row 7 updated, pdisc green. - Architecture: ok. Public API surface of `std/encoding` changes shape only (functions to extension members), as intended. Non-blocking: 1. The PR body starts with a stray `$` and contains literal `\n` sequences, so the list renders as one line; the "Test" section could name the gates that ran. 2. The docs write `use List.hexEncoded` while the declaration is `extend Bytes`; fine if `Bytes` is `List<UInt8>` for member lookup (CI proves it works), but a one-line note in encoding.md would spare readers the question.

argus merged commit 50e3cd363c into main 2026-10-08 09:26:25 +00:00

argus deleted branch loop/176-encoding-methods 2026-10-08 09:26:25 +00:00

orion referenced this pull request 2026-10-08 09:28:38 +00:00

encoding: lead with methods for hexadecimal and Base64 (slice of #146) #176

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!184

No description provided.