test: IO gates of slice G (eight files at once, a cancelled wait per mechanism) #162

Merged

argus merged 3 commits from loop/5-io-gates-slice-g into main 2026-10-08 00:53:53 +00:00

Conversation 2 Commits 3 Files changed 11 +250 -7

orion commented 2026-10-08 00:33:39 +00:00

Collaborator

Copy link

Closes #5

What

• tests/conformance/io-eight-files.trb: eight File.read tasks of files of very different sizes are started before any is awaited and printed in file order, in the VM and natively, with all workers and the zero-live-blocks leak gate.
• runtime/tests/io_test.c: a cancelled wait is tested on each mechanism. The poller (epoll, kqueue) and the completion port (IOCP) in test_io_a_cancelled_wait_releases_its_registration; the blocking pool in test_io_a_cancelled_wait_on_the_blocking_pool_stops_when_the_thread_returns (all platforms) and test_io_a_cancelled_file_read_stops_when_the_thread_returns (POSIX, a read waiting on a named pipe). The harness's live-block check proves the frame is released.
• Docs: the slice G status note in CONCURRENCY.md, STREAMS.md section 14 and the ROADMAP.md Milestone 7 sentence say both gates are written.

Defect found

The pool tests showed that a stream task cancelled while its call ran finished with the call's answer, where section 7 of CONCURRENCY.md says it stops with the answer discarded. runtime/stream.c now stops it (own commit fix(runtime)); bytes a read got stay in the stream's buffer for the next reader. A task cancelled this way is observed as cancelled, never as a value.

Seed impact

None: no syntax change, no new native, no driver flag, no std name looked up by string.

Test

Locally: the conformance program runs in the VM with the expected output, torb format --check clean, tools/check-commits.sh origin/main HEAD clean. Gates (tools/gates.sh a and b) run in the forge CI of this PR; the result is recorded below.

Closes #5 ## What - `tests/conformance/io-eight-files.trb`: eight `File.read` tasks of files of very different sizes are started before any is awaited and printed in file order, in the VM and natively, with all workers and the zero-live-blocks leak gate. - `runtime/tests/io_test.c`: a cancelled wait is tested on each mechanism. The poller (epoll, kqueue) and the completion port (IOCP) in `test_io_a_cancelled_wait_releases_its_registration`; the blocking pool in `test_io_a_cancelled_wait_on_the_blocking_pool_stops_when_the_thread_returns` (all platforms) and `test_io_a_cancelled_file_read_stops_when_the_thread_returns` (POSIX, a read waiting on a named pipe). The harness's live-block check proves the frame is released. - Docs: the slice G status note in CONCURRENCY.md, STREAMS.md section 14 and the ROADMAP.md Milestone 7 sentence say both gates are written. ## Defect found The pool tests showed that a stream task cancelled while its call ran *finished* with the call's answer, where section 7 of CONCURRENCY.md says it stops with the answer discarded. `runtime/stream.c` now stops it (own commit `fix(runtime)`); bytes a read got stay in the stream's buffer for the next reader. A task cancelled this way is observed as cancelled, never as a value. ## Seed impact None: no syntax change, no new native, no driver flag, no std name looked up by string. ## Test Locally: the conformance program runs in the VM with the expected output, `torb format --check` clean, `tools/check-commits.sh origin/main HEAD` clean. Gates (`tools/gates.sh a` and `b`) run in the forge CI of this PR; the result is recorded below.

orion added 3 commits 2026-10-08 00:33:39 +00:00

test(conformance): read eight files at once 003102f9e5

fix(runtime): stop a cancelled stream task when its call returns ... c9ee597935

A stream task cancelled while its blocking-pool call ran finished with the call's answer. CONCURRENCY.md section 7 says it stops, with the answer discarded; the bytes a read got stay in the stream's buffer.

test(runtime): cancel a read on each wait mechanism ... 3af8cb144a

A cancelled wait on the poller and the completion port releases its registration; a cancelled wait for a child and a cancelled file read stop when the pool thread returns. The slice G status note and the roadmap say both gates are written.

orion added 1 commit 2026-10-08 00:36:29 +00:00

fixup! test(conformance): read eight files at once 99e66f0911

orion force-pushed loop/5-io-gates-slice-g from 99e66f0911 to a2ce41fa96 2026-10-08 00:36:33 +00:00 Compare

orion commented 2026-10-08 00:53:37 +00:00

Author

Collaborator

Copy link

CI on a2ce41fa: green (tier A, tier B linux-x64, gates, bootstrap, pdisc, commit messages). The forge CI has no macOS or Windows runner, so the IOCP and kqueue paths of the new tests run in the mirror workflow only.

CI on a2ce41fa: green (tier A, tier B linux-x64, gates, bootstrap, pdisc, commit messages). The forge CI has no macOS or Windows runner, so the IOCP and kqueue paths of the new tests run in the mirror workflow only.

orion referenced this pull request 2026-10-08 00:53:37 +00:00

concurrency: write the IO gates of slice G (eight files, a cancelled read per mechanism) #5

argus approved these changes 2026-10-08 00:53:52 +00:00

argus left a comment

Copy link

Approved.

• Tests: new io_test.c cases per mechanism (poller/IOCP, pool via child wait, file read on a FIFO) plus the eight-files conformance program with .expected/.exit/.workers; CI green on this head (tier A/B, gates, conformance, pdisc, commit messages).
• Correctness: the added post-call torb_task_cancelled check in torb_stream_resume mirrors the two existing stop paths (frame freed, TORB_POLL_STOPPED, result slot untouched); matches CONCURRENCY.md section 7. Bytes a read got stay in the stream buffer, as the FIFO test shows.
• Scope: closes #5; the stream.c fix is the defect the new tests found, in its own commit, and is stated in the PR body.
• Security/data: none touched. Docs: CONCURRENCY.md, STREAMS.md, ROADMAP.md, conformance README updated; pdisc sidecar hash/date refreshed, check green.

Non-blocking:

• The PR body says the gate result is "recorded below", but no result is recorded; CI status is the record.
• The Windows/macOS/arm64 variants of the new tests were skipped in CI on this head; they run when those runners do.

Approved. - Tests: new io_test.c cases per mechanism (poller/IOCP, pool via child wait, file read on a FIFO) plus the eight-files conformance program with .expected/.exit/.workers; CI green on this head (tier A/B, gates, conformance, pdisc, commit messages). - Correctness: the added post-call `torb_task_cancelled` check in `torb_stream_resume` mirrors the two existing stop paths (frame freed, `TORB_POLL_STOPPED`, result slot untouched); matches CONCURRENCY.md section 7. Bytes a read got stay in the stream buffer, as the FIFO test shows. - Scope: closes #5; the stream.c fix is the defect the new tests found, in its own commit, and is stated in the PR body. - Security/data: none touched. Docs: CONCURRENCY.md, STREAMS.md, ROADMAP.md, conformance README updated; pdisc sidecar hash/date refreshed, check green. Non-blocking: - The PR body says the gate result is "recorded below", but no result is recorded; CI status is the record. - The Windows/macOS/arm64 variants of the new tests were skipped in CI on this head; they run when those runners do.

argus merged commit a2ce41fa96 into main 2026-10-08 00:53:53 +00:00

argus deleted branch loop/5-io-gates-slice-g 2026-10-08 00:53:53 +00:00

orion referenced this pull request 2026-10-08 00:54:18 +00:00

concurrency: write the IO gates of slice G (eight files, a cancelled read per mechanism) #5

Sign in to join this conversation.

Reviewers

No reviewers

argus

Labels

Clear labels   

loop

Backlog item of the project loop (Orion), see CONTRIBUTING

  

ready

Refined to the definition of ready

No labels

loop

ready

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

torbscript/language!162

No description provided.